Rare (?) test failure in test_extend_ntor
I haven't seen this one before. I'll mention it here, in case it's something to look at—I know @gabi-250 and @dgoulet have been talking about code related to this?
FAIL [ 0.014s] tor-proto circuit::test::test_extend_ntor
──── STDOUT: tor-proto circuit::test::test_extend_ntor
running 1 test
2025-01-30T18:57:08.638526Z TRACE tor_proto::channel::reactor: UniqId(0): Running reactor
2025-01-30T18:57:08.638572Z TRACE tor_proto::circuit::reactor: Circ 23.17: Running circuit reactor
2025-01-30T18:57:08.638943Z TRACE tor_proto::circuit::reactor: Circ 23.17: reactor received AddFakeHop { relay_cell_format: V0, fwd_lasthop: false, rev_lasthop: false, params: CircParameters { extend_by_ed25519_id: true, ccontrol: CongestionControlParams { alg: FixedWindow(FixedWindowParams { circ_window_start: 1000, circ_window_min: 100, circ_window_max: 1000 }), cwnd_params: CongestionWindowParams { cwnd_init: 124, cwnd_inc_pct_ss: Percentage { value: 100 }, cwnd_inc: 1, cwnd_inc_rate: 31, cwnd_min: 124, cwnd_max: 4294967295, sendme_inc: 31 }, rtt_params: RoundTripEstimatorParams { ewma_cwnd_pct: Percentage { value: 50 }, ewma_max: 10, ewma_ss_max: 2, rtt_reset_pct: Percentage { value: 100 } } } }, done: Sender { complete: false } }
2025-01-30T18:57:08.639060Z TRACE tor_proto::circuit::reactor: Circ 23.17: reactor received AddFakeHop { relay_cell_format: V0, fwd_lasthop: true, rev_lasthop: true, params: CircParameters { extend_by_ed25519_id: true, ccontrol: CongestionControlParams { alg: FixedWindow(FixedWindowParams { circ_window_start: 1000, circ_window_min: 100, circ_window_max: 1000 }), cwnd_params: CongestionWindowParams { cwnd_init: 124, cwnd_inc_pct_ss: Percentage { value: 100 }, cwnd_inc: 1, cwnd_inc_rate: 31, cwnd_min: 124, cwnd_max: 4294967295, sendme_inc: 31 }, rtt_params: RoundTripEstimatorParams { ewma_cwnd_pct: Percentage { value: 50 }, ewma_max: 10, ewma_ss_max: 2, rtt_reset_pct: Percentage { value: 100 } } } }, done: Sender { complete: false } }
2025-01-30T18:57:08.639120Z TRACE tor_proto::circuit::reactor: Circ 23.17: reactor received ExtendNtor { peer_id: OwnedChanTarget { addrs: [], method: Direct([]), ids: RelayIds { ed_identity: Some(Ed25519Identity { BgYGBgYGBgYGBgYGBgYGBgYGBgYGBgYGBgYGBgYGBgY }), rsa_identity: Some(RsaIdentity { $0a0a0a0a0a0a0a0a0a0a0a0a0a0a0a0a0a0a0a0a }) } }, public_key: NtorPublicKey { id: RsaIdentity { $0a0a0a0a0a0a0a0a0a0a0a0a0a0a0a0a0a0a0a0a }, pk: PublicKey(MontgomeryPoint([57, 92, 178, 107, 131, 179, 205, 75, 145, 219, 169, 145, 62, 86, 42, 232, 125, 33, 236, 221, 86, 132, 61, 167, 202, 147, 154, 106, 105, 0, 18, 83])) }, linkspecs: [EncodedLinkSpec { lstype: LinkSpecType(RSAID), body: [10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10] }, EncodedLinkSpec { lstype: LinkSpecType(ED25519ID), body: [6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6] }], params: CircParameters { extend_by_ed25519_id: true, ccontrol: CongestionControlParams { alg: FixedWindow(FixedWindowParams { circ_window_start: 1000, circ_window_min: 100, circ_window_max: 1000 }), cwnd_params: CongestionWindowParams { cwnd_init: 124, cwnd_inc_pct_ss: Percentage { value: 100 }, cwnd_inc: 1, cwnd_inc_rate: 31, cwnd_min: 124, cwnd_max: 4294967295, sendme_inc: 31 }, rtt_params: RoundTripEstimatorParams { ewma_cwnd_pct: Percentage { value: 50 }, ewma_max: 10, ewma_ss_max: 2, rtt_reset_pct: Percentage { value: 100 } } } }, done: Sender { complete: false } }
2025-01-30T18:57:08.639299Z TRACE tor_proto::circuit::reactor::extender: Circ 23.17: Extending circuit to hop 4 with [EncodedLinkSpec { lstype: LinkSpecType(RSAID), body: [10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10] }, EncodedLinkSpec { lstype: LinkSpecType(ED25519ID), body: [6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6] }]
2025-01-30T18:57:08.639313Z TRACE tor_proto::circuit::reactor::extender: Circ 23.17: waiting for EXTENDED2 cell
2025-01-30T18:57:08.639349Z TRACE tor_proto::channel: Chan 0: Sending RELAY_EARLY for 128
Using RNG seed ARTI_TEST_PRNG=0cd2e07b2bee00b5baa16461a266ad407d335048cae5b01996a6c69b75dba4bf
Using RNG seed ARTI_TEST_PRNG=6ecfcedc4acdf49539cc7875481fb51f389d54952a5b34d3a9760413ce394d37
2025-01-30T18:57:08.640406Z TRACE tor_proto::channel::reactor::test: got sink error: SendError { kind: Disconnected }
2025-01-30T18:57:08.640424Z DEBUG tor_proto::channel::reactor: UniqId(0): Reactor stopped: Err(ChanProto("dummy message"))
2025-01-30T18:57:08.640456Z TRACE tor_proto::circuit::reactor: Circ 23.17: Circuit reactor stopped: Err(ChannelClosed(ChannelClosed))
test circuit::test::test_extend_ntor ... FAILED
failures:
failures:
circuit::test::test_extend_ntor
test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 143 filtered out; finished in 0.01s
──── STDERR: tor-proto circuit::test::test_extend_ntor
thread 'circuit::test::test_extend_ntor' panicked at crates/tor-proto/src/circuit.rs:1744:81:
called `Result::unwrap()` on an `Err` value: CircuitClosed
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Cancelling due to test failure: 23 tests still running