Try harder to avoid logging HsIDs.
HsIds, like all addresses that the client is trying to connect to, should probably get marked as Sensitive or something, so they can be logged as [...], or in a redacted form, unless "log_sensitive_info" is enabled.
I saw this error message while debugging an issue on !3007 (merged):
2025-05-22T15:18:36Z WARN tor_hsclient::connect: hs conn to duckduckgogg42xjoc72x3sjasowoarfbgcmvfimaftt6twagswzczad.onion: actual error removed
Now, I don't mind people knowing that I tried to visit duckduckgo, but in general we shouldn't be logging stuff like this.
There are two possible solutions here:
- Audit every hsid to make sure we aren't logging it without wrapping it in Sensitive.
- Make hsid internally sensitive.
We might also want to audit every place where we log a target address