Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Arti Arti
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 230
    • Issues 230
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 19
    • Merge requests 19
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • Core
  • ArtiArti
  • Issues
  • #217
Closed
Open
Issue created Nov 02, 2021 by eta@eta💚Maintainer

Do some small refactors in `tor-proto`

Some of the code in tor-proto could probably do with cleaning up a bit / refactoring. Eventually I'd rather like to redesign how the reactors work somewhat considerably (also see #205 (closed)), but that's also going to require thinking about how to incorporate fairness.

For now, there are probably some small quick wins that can be had — copy-and-pasting from my notes from reading through the code yesterday, and I'll probably add to this:

  • why make oneshot channels when you can just have an unbounded channel, for which sends never block?
  • why does the RawCellStream have a Mutex of an mpsc::Receiver?
    • it could either be an MPMC channel (as provided by crossbeam), or it could just not be shared
  • should some of the information in StreamTarget be handled inside the reactor?
    • doing this probably means the sendme windows don't need to have locks inside them, either
Edited Nov 02, 2021 by eta
Assignee
Assign to
Time tracking