Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Arti Arti
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 230
    • Issues 230
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 19
    • Merge requests 19
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • Core
  • ArtiArti
  • Issues
  • #218
Closed
Open
Issue created Nov 02, 2021 by eta@eta💚Maintainer

Guard against use of `dbg!` in production code

Looks like at least one dbg! slipped into the 0.0.1 release; I got this while running arti @ e9cbf8c5 during consensus download:

[crates/tor-dirmgr/src/state.rs:637] "Adding 1 from download" = "Adding 1 from download"

@nickm said he'd fix this particular instance, but it's worth adding some checks to ensure things like this don't slip through in future.

There's Clippy's dbg_macro lint, but we probably don't want to #![deny(..)] that in the actual code, because then debugging would be painful.

What we should probably do is run clippy with -D clippy::dbg_macro in CI, or something like that.

Assignee
Assign to
Time tracking