Skip to content

maint/add_warning

I ran maint/add_warning crates/*/src/{lib,main}.rs as advised by its usage message. I observe that:

  • It made some changes. But, surely, if we have a program like this which rewrites files, that ought to be the canonical location of this information. So something in the CI should check that maint/add_warning is a no-op.

  • It doesn't seem like it's capable of removing clippy instructions.

  • I wanted to use it to add an allow but when I tried that it crashed with a python exception.

  • It starts with #! /usr/bin/python. I assume (hope!) it's actually Python 3. So it should start #! /usr/bin/python3. (Yes, upstream doctrine suggests that /usr/bin/python should be totally incompatible with previous /usr/bin/python but that is very bad. The fact that some distros actually did this does not make it reasonable.)