main doesn't build with bridges but no PTs
cargo check -p arti-client --features=bridge-client
Checking tor-guardmgr v0.7.0 (/home/ian/Rustup/Arti/arti/crates/tor-guardmgr)
error[E0004]: non-exhaustive patterns: `&ChannelMethod::Pluggable(_)` not covered
--> crates/tor-guardmgr/src/bridge/config.rs:341:30
|
341 | let settings = match addrs {
| ^^^^^ pattern `&ChannelMethod::Pluggable(_)` not covered
|
note: `ChannelMethod` defined here
--> /home/ian/Rustup/Arti/arti/crates/tor-linkspec/src/transport.rs:407:5
Problems:
-
this is due to arti-client
unconditionally depending ontor-ptmgr
which unconditionally enables thept-client
feature oftor-linkspec
. Then we havetor-linkspec/pt-client
buttor-guardmgr/!pt-client
which is fail. -
I think adding variants to an exhaustive enum is not cargo-feature-additive. So I think we need to make ChannelMethod
non-exhaustive which will be annoying. -
we apparently never try to build with bridges but not PTs in CI.
Edited by Ian Jackson