lunar has a broken repository (missing repropro package on arm64) and
causing ci to fail

tpo/tpa/base-images now has ubuntu images

dockerhub rate limits our image pulls; switch to containers.torproject.org and remove all the things we do not have images for (leaves only modern debians and only amd64

* debian-ci:
  Do not build Noble and Oracular on i386.
  Add noble and oracular to the Debian CI.
  Mark safe directories before cloning.

* debian-merge:
  New upstream version: 0.4.8.12
  version: Bump version to 0.4.8.12
  release: ChangeLog and ReleaseNotes for 0.4.8.12
  fallbackdir: Update list generated on June 06, 2024
  Update geoip files to match ipfire location db, 2024/06/06.
  Update OverloadStatistics to match prop 328
  scripts: Fix Python3 warnings
  dirauth: Add new faravahar
  Fix typo in tor-relays list address
  circuit: Remove log_warn triggered by a proto violation
  conflux: Don't process a closed circuit on get packaged window
  conflux: Avoid noting a cell was sent on a closed circuit
  version: Bump version to 0.4.8.11-dev

Tor 0.4.8.12

# -----BEGIN PGP SIGNATURE-----
#
# iQEzBAABCAAdFiEEt0QX7d8irJ+ekPSRQuhqKhH0jTYFAmZhyBcACgkQQuhqKhH0
# jTbc2ggAgoyYr3gOv1mmoEapr/8WLtzlic38wi91XxA78GmFEFF2fqMOAGzqAtaE
# FNLy86oFdooKdvZqv6iF+JnmjoyOdZWKMOlOj3pcDMlGIqwAnhhRNV6pqe9+NEC8
# GR9XEx/gfq37//kMGfgUrUGjISYrbkAvJi0y8GeFqxZGK8MV/tCCnY0CHtKsYwJQ
# Ncq3jMGjC88vleX/HY67Wezn1YOGDo12QQ7O25ygWPptCG/CsjWspM1ezcQdULHO
# Y8Z3RbXm4PncIMRWw1HBGGrHnlZKepNs98KNrRpvuuuWh7Ya+l2HK4zaAzSm/ICL
# 0vTHo+aMCE2+oIF/4ATlK9PZQFbZ7g==
# =TK8r
# -----END PGP SIGNATURE-----
# gpg: Signature made Thu Jun  6 16:30:47 2024 CEST
# gpg:                using RSA key B74417EDDF22AC9F9E90F49142E86A2A11F48D36
# gpg: please do a --check-trustdb
# gpg: Good signature from "David Goulet <dgoulet@ev0ke.net>" [unknown]
# gpg:                 aka "David Goulet <dgoulet@riseup.net>" [unknown]
# gpg:                 aka "David Goulet <dgoulet@torproject.org>" [unknown]
# gpg: WARNING: This key is not certified with a trusted signature!
# gpg:          There is no indication that the signature belongs to the owner.
# Primary key fingerprint: B744 17ED DF22 AC9F 9E90  F491 42E8 6A2A 11F4 8D36

* tag 'tor-0.4.8.12':
  version: Bump version to 0.4.8.12
  release: ChangeLog and ReleaseNotes for 0.4.8.12
  fallbackdir: Update list generated on June 06, 2024
  Update geoip files to match ipfire location db, 2024/06/06.
  Update OverloadStatistics to match prop 328
  scripts: Fix Python3 warnings
  dirauth: Add new faravahar
  Fix typo in tor-relays list address
  circuit: Remove log_warn triggered by a proto violation
  conflux: Don't process a closed circuit on get packaged window
  conflux: Avoid noting a cell was sent on a closed circuit
  version: Bump version to 0.4.8.11-dev

Georg Koppen authored 10 months ago and David Goulet committed 9 months ago

Closes: #40940.

Signed-off-by: David Goulet <dgoulet@torproject.org>

Brand new address, brand new keys, brand new day.

Closes #40689

Signed-off-by: David Goulet <dgoulet@torproject.org>

* debian-ci:
  auto-retry binary builds on runner system failure

Try to work around broken build results because runners go away.

Fixes #40932

Signed-off-by: David Goulet <dgoulet@torproject.org>

Signed-off-by: David Goulet <dgoulet@torproject.org>

It turns out that circuit_package_relay_cell() returns 0 in order to drop a
cell but there is a code path, if the circuit queue is full, that also silently
closes the circuit and returns 0.

This lead to Conflux thinking a cell was sent but actually the cell was not and
the circuit was closed leading to the hard assert.

And so this function makes sure that circuit_package_relay_cell() and
append_cell_to_circuit_queue() returns a value that indicate what happened with
the cell and circuit so the caller can make an informed decision with it.

This change makes it that we do NOT enter the Conflux subsystem if the cell is
not queued on the circuit.

Fixes #40921

Signed-off-by: David Goulet <dgoulet@torproject.org>

* debian-merge:
  New upstream version: 0.4.8.11
  version: Bump version to 0.4.8.11
  release: ChangeLog and ReleaseNotes for 0.4.8.11
  fallbackdir: Update list generated on April 10, 2024
  Update geoip files to match ipfire location db, 2024/04/10.
  dirauth: New keys and address for tor26
  Try to appease the changefile format checker
  Update test strings
  Add a changes file
  dirauth: Warn when failing to post during a vote
  dirauth: Reject 0.4.7.x series at the authority level
  bwauth: Allow "node_id" KeyValue without "$"
  add release note and changelog entry for #40819
  version: Bump version to 0.4.8.10-dev