Skip to content
  • David Goulet's avatar
    config: Do not compare for duplicate ORPorts with different addresses · dfcb050b
    David Goulet authored
    
    
    We were just looking at the family which is not correct because it is possible
    to have two explicit ORPort for the same family but different addresses. One
    example is:
    
      ORPort 127.0.0.1:9001 NoAdvertise
      ORPort 1.2.3.4:9001 NoListen
    
    Thus, this patch now ignores ports that have different addresses iff they are
    both explicits. That is, if we have this example, also two different
    addresses:
    
      ORPort 9001
      ORPort 127.0.0.1:9001 NoAdvertise
    
    The first one is implicit and second one is explicit and thus we have to
    consider them for removal which in this case would remove the "ORPort 9001" in
    favor of the second port.
    
    Fixes #40289
    
    Signe-off-by: David Goulet's avatarDavid Goulet <dgoulet@torproject.org>
    dfcb050b