Commit 0eb21427 authored by Nick Mathewson's avatar Nick Mathewson 🤹
Browse files

Don't add redundant quotes with escaped() in log messages. 

The escaped() function and its kin already wrap their output in
quotes: there's no reason to do so twice.

I am _NOT_ making a corresponding change in calls that make the same
mistake in controller-related functions, however, due to the risk of
a compatibility break. :(

Closes #22723.
parent 1d6470a2

changes/log-quotes

0 → 100644
+3 −0
Original line number Diff line number Diff line 
  o Minor bugfixes (logging):

    - Avoid ""double-quoting"" strings in several log messages.

      Fixes bug 22723; bugfix on 0.1.2.2-alpha.

src/feature/dirauth/process_descs.c

+1 −1
Original line number Diff line number Diff line
@@ -110,7 +110,7 @@ add_rsa_fingerprint_to_dir(const char *fp, authdir_config_t *list, 
  tor_strstrip(fingerprint, " ");

  if (base16_decode(d, DIGEST_LEN,

                    fingerprint, strlen(fingerprint)) != DIGEST_LEN) {

    log_warn(LD_DIRSERV, "Couldn't decode fingerprint \"%s\"",

    log_warn(LD_DIRSERV, "Couldn't decode fingerprint %s",

             escaped(fp));

    tor_free(fingerprint);

    return -1;

src/feature/relay/dns.c

+2 −2
Original line number Diff line number Diff line
@@ -768,11 +768,11 @@ dns_resolve_impl,(edge_connection_t *exitconn, int is_resolve, 


    if (!is_reverse || !is_resolve) {

      if (!is_reverse)

        log_info(LD_EXIT, "Bad .in-addr.arpa address \"%s\"; sending error.",

        log_info(LD_EXIT, "Bad .in-addr.arpa address %s; sending error.",

                 escaped_safe_str(exitconn->base_.address));

      else if (!is_resolve)

        log_info(LD_EXIT,

                 "Attempt to connect to a .in-addr.arpa address \"%s\"; "

                 "Attempt to connect to a .in-addr.arpa address %s; "

                 "sending error.",

                 escaped_safe_str(exitconn->base_.address));