From 16351d655d5f2cf8a69323b69f55f89c96d91beb Mon Sep 17 00:00:00 2001
From: David Goulet <dgoulet@torproject.org>
Date: Tue, 17 Nov 2020 13:23:29 -0500
Subject: [PATCH] sendme: Turn log warning into debug
When sending the stream level SENDME, it is possible the cirucit was marked
for close or any other failures that can occur. These events can occur
naturally.
Fixes #40142
Signed-off-by: David Goulet <dgoulet@torproject.org>
---
changes/ticket40142 | 3 +++
src/core/or/sendme.c | 4 ++--
2 files changed, 5 insertions(+), 2 deletions(-)
create mode 100644 changes/ticket40142
diff --git a/changes/ticket40142 b/changes/ticket40142
new file mode 100644
index 0000000000..25a96b3df3
--- /dev/null
+++ b/changes/ticket40142
@@ -0,0 +1,3 @@
+ o Minor bugfixes (logging, flow control):
+ - Turn a SENDME failure log warning into a debug. It can actually happen
+ naturally. Fixes bug 40142; bugfix on 0.4.1.1-alpha.
diff --git a/src/core/or/sendme.c b/src/core/or/sendme.c
index 7b4595c1ac..9cad245b29 100644
--- a/src/core/or/sendme.c
+++ b/src/core/or/sendme.c
@@ -398,8 +398,8 @@ sendme_connection_edge_consider_sending(edge_connection_t *conn)
conn->deliver_window += STREAMWINDOW_INCREMENT;
if (connection_edge_send_command(conn, RELAY_COMMAND_SENDME,
NULL, 0) < 0) {
- log_warn(LD_BUG, "connection_edge_send_command failed while sending "
- "a SENDME. Circuit probably closed, skipping.");
+ log_debug(LD_CIRC, "connection_edge_send_command failed while sending "
+ "a SENDME. Circuit probably closed, skipping.");
goto end; /* The circuit's closed, don't continue */
}
}
--
GitLab