Commit 1c0e87f6 authored by Nick Mathewson's avatar Nick Mathewson 🦞
Browse files

Add a pointless 2-byte memset in cell_pack 

There is probably no code that can write the 2 bytes at the end of the
packed_cell_t when the cell is only a 512-byte cell, but let's not get
overconfident there.
parent bfffc1f0

src/or/connection_or.c

+1 −0
Original line number Diff line number Diff line
@@ -361,6 +361,7 @@ cell_pack(packed_cell_t *dst, const cell_t *src, int wide_circ_ids) 
  } else {

    set_uint16(dest, htons(src->circ_id));

    dest += 2;

    memset(dest+CELL_MAX_NETWORK_SIZE-2, 0, 2); /*make sure it's clear */

  }

  set_uint8(dest, src->command);

  memcpy(dest+1, src->payload, CELL_PAYLOAD_SIZE);