GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

Commit 5248d08e authored by Guinness's avatar Guinness Committed by Nick Mathewson

Consider 301 as an error like 404

Tor does not follow redirects when bootstraping so we encountered an
error.

Fixes #40053
parent bb249a22
o Minor features (logging):
- Consider 301 as an error like a 404 when processing the response to a
request for a group of server descriptors or an extrainfo documents.
Closes ticket 40053.
......@@ -2505,9 +2505,12 @@ handle_response_fetch_desc(dir_connection_t *conn,
}
if (status_code != 200) {
int dir_okay = status_code == 404 ||
(status_code == 400 && !strcmp(reason, "Servers unavailable."));
(status_code == 400 && !strcmp(reason, "Servers unavailable.")) ||
status_code == 301;
/* 404 means that it didn't have them; no big deal.
* Older (pre-0.1.1.8) servers said 400 Servers unavailable instead. */
* Older (pre-0.1.1.8) servers said 400 Servers unavailable instead.
* 301 is considered as an error since Tor does not follow redirects,
* which means we failed to reach the server we wanted. */
log_fn(dir_okay ? LOG_INFO : LOG_WARN, LD_DIR,
"Received http status code %d (%s) from server %s "
"while fetching \"/tor/server/%s\". I'll try again soon.",
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment