Commit 56f1cab9 authored by Nick Mathewson's avatar Nick Mathewson 🎨
Browse files

Don't log supported-protover warnings if consensus is older than Tor.

Previously we would warn in this case... but there's really no
justification for doing so, and it can only cause confusion.

Fixes bug #40281; bugfix on
parent 49c61c1b
o Minor bugfixes (logging):
- Avoid a spurious log message about missing subprotocol versions, when
the consensus that we're reading from is older than the current
release. . Previously we had made this message nonfatal in this case,
but in practice, it is never relevant when the consensus is older than
the current release. Fixes bug 40281; bugfix on
......@@ -2713,6 +2713,13 @@ networkstatus_check_required_protocols(const networkstatus_t *ns,
const bool consensus_postdates_this_release =
ns->valid_after >= tor_get_approx_release_date();
if (! consensus_postdates_this_release) {
// We can't meaningfully warn about this case: This consensus is from
// before we were released, so whatever is says about required or
// recommended versions may no longer be true.
return 0;
if (client_mode) {
......@@ -2730,7 +2737,7 @@ networkstatus_check_required_protocols(const networkstatus_t *ns,
"%s on the Tor network. The missing protocols are: %s",
func, missing);
return consensus_postdates_this_release ? 1 : 0;
return 1;
if (! protover_all_supported(recommended, &missing)) {
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment