Commit 616fd790 authored by Nick Mathewson's avatar Nick Mathewson 🤹
Browse files

Merge remote-tracking branch 'origin/maint-0.2.4'

parents a64d062c fff9386a

changes/bug2077_share_delete

deleted100644 → 0
+0 −7
Original line number Diff line number Diff line 
  o Major bugfixes (windows):

    - Open files to be mapped with FILE_SHARE_DELETE so that we can

      replace them before closing the mapping. This is a likely cause of

      warnings and crashes when replacing the microdescriptor cache

      file. Diagnosed based on comments by "doorss" and by Robert

      Ransom. Possible fix for bug 2077; bugfix on 0.2.2.6-alpha.

src/common/compat.c

+1 −1
Original line number Diff line number Diff line
@@ -248,7 +248,7 @@ tor_mmap_file(const char *filename) 
  strlcpy(tfilename,filename,MAX_PATH);

#endif

  file_handle = CreateFile(tfilename,

                           GENERIC_READ, FILE_SHARE_READ|FILE_SHARE_DELETE,

                           GENERIC_READ, FILE_SHARE_READ,

                           NULL,

                           OPEN_EXISTING,

                           FILE_ATTRIBUTE_NORMAL,