Commit 6a2f0451 authored by Roger Dingledine's avatar Roger Dingledine
Browse files

extra points for making the function name reflect what it does 


svn:r10608
parent 73f7310d

src/or/directory.c

+1 −1
Original line number Diff line number Diff line
@@ -1804,7 +1804,7 @@ directory_handle_command_get(dir_connection_t *conn, const char *headers, 
      smartlist_free(dir_fps);

      return 0;

    }

    if (dirserv_statuses_are_old(dir_fps, if_modified_since)) {

    if (dirserv_remove_old_statuses(dir_fps, if_modified_since)) {

      write_http_status_line(conn, 304, "Not modified");

      /* no need to free dir_fps's elements, since

       * dirserv_statuses_are_old() already did. */

src/or/dirserv.c

+1 −1
Original line number Diff line number Diff line
@@ -2545,7 +2545,7 @@ dirserv_test_reachability(int try_all) 
 * Return 1 if no keys remain, else return 0.

 */

int

dirserv_statuses_are_old(smartlist_t *fps, time_t cutoff)

dirserv_remove_old_statuses(smartlist_t *fps, time_t cutoff)

{

  SMARTLIST_FOREACH(fps, char *, digest,

  {

src/or/or.h

+1 −1
Original line number Diff line number Diff line
@@ -2739,7 +2739,7 @@ void dirserv_test_reachability(int try_all); 
int authdir_wants_to_reject_router(routerinfo_t *ri, const char **msg,

                                   int complain);

int dirserv_would_reject_router(routerstatus_t *rs);

int dirserv_statuses_are_old(smartlist_t *fps, time_t cutoff);

int dirserv_remove_old_statuses(smartlist_t *fps, time_t cutoff);

size_t dirserv_estimate_data_size(smartlist_t *fps, int is_serverdescs,

                                  int compressed);

int routerstatus_format_entry(char *buf, size_t buf_len,