GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

Commit 884cad3e authored by Neel Chauhan's avatar Neel Chauhan Committed by Nick Mathewson

Make HSFETCH take the decoded length into account, not the base32 one

parent 3e9fa5a0
Pipeline #1269 canceled with stage
o Minor bugfixes (v2 onion services):
- For HSFETCH commands on v2 onion services addresses, check the length of
bytes decoded, not the base32 length. This takes the behavior introduced
in commit a517daa56f5848d25ba79617a1a7b82ed2b0a7c0 into consideration.
Fixes bug 34400; bugfix on 0.4.1.1-alpha. Patch by Neel Chauhan.
......@@ -1430,7 +1430,7 @@ handle_control_hsfetch(control_connection_t *conn,
rend_valid_descriptor_id(arg1 + v2_str_len) &&
base32_decode(digest, sizeof(digest), arg1 + v2_str_len,
REND_DESC_ID_V2_LEN_BASE32) ==
REND_DESC_ID_V2_LEN_BASE32) {
sizeof(digest)) {
/* We have a well formed version 2 descriptor ID. Keep the decoded value
* of the id. */
desc_id = digest;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment