Commit 890ae4fb authored by Nick Mathewson's avatar Nick Mathewson 🐛
Browse files

Fix detection of point to insert signatures on a pending consensus.

We were looking for the first instance of "directory-signature "
when instead the correct behavior is to look for the first instance
of "directory-signature " at the start of a line.

Unfortunately, this can be exploited as to crash authorities while
they're voting.

Fixes #40316; bugfix on  This is TROVE-2021-002,
also tracked as CVE-2021-28090.
parent 296a557b
o Major bugfixes (security, denial of service):
- Fix a bug in appending detached signatures to a pending consensus
document that could be used to crash a directory authority.
Fixes bug 40316; bugfix on Tracked as
TROVE-2021-002 and CVE-2021-28090.
......@@ -3520,7 +3520,7 @@ dirvote_add_signatures_to_pending_consensus(
strlen(pc->body) + strlen(new_signatures) + 1;
pc->body = tor_realloc(pc->body, new_consensus_len);
dst_end = pc->body + new_consensus_len;
dst = strstr(pc->body, "directory-signature ");
dst = (char *) find_str_at_start_of_line(pc->body, "directory-signature ");
strlcpy(dst, new_signatures, dst_end-dst);
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment