Commit 9f61d923 authored by David Goulet's avatar David Goulet 🤘
Browse files

metrics: Handle the connection finished flushing event

Turns out, we forgot to add the METRICS connection type fo the finished
flushing handler.

Fixes #40295

Signed-off-by: David Goulet's avatarDavid Goulet <dgoulet@torproject.org>
parent 336c45f1
o Minor bugfixes (metrics port):
- Fix a BUG() on the MetricsPort for an internal missing handler. Fixes bug
40295; bugfix on 0.4.5.1-alpha.
......@@ -5187,6 +5187,8 @@ connection_finished_flushing(connection_t *conn)
return connection_dir_finished_flushing(TO_DIR_CONN(conn));
case CONN_TYPE_CONTROL:
return connection_control_finished_flushing(TO_CONTROL_CONN(conn));
case CONN_TYPE_METRICS:
return metrics_connection_finished_flushing(conn);
default:
log_err(LD_BUG,"got unexpected conn type %d.", conn->type);
tor_fragile_assert();
......
......@@ -258,6 +258,15 @@ metrics_connection_reached_eof(connection_t *conn)
return 0;
}
/** Called when conn has no more bytes left on its outbuf. Return 0 indicating
* success. */
int
metrics_connection_finished_flushing(connection_t *conn)
{
tor_assert(conn);
return 0;
}
/** Initialize the subsystem. */
void
metrics_init(void)
......
......@@ -28,6 +28,7 @@ buf_t *metrics_get_output(const metrics_format_t fmt);
/* Connection. */
int metrics_connection_process_inbuf(struct connection_t *conn);
int metrics_connection_reached_eof(struct connection_t *conn);
int metrics_connection_finished_flushing(struct connection_t *conn);
/* Configuration. */
int metrics_parse_ports(or_options_t *options, smartlist_t *ports,
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment