Commit b417594d authored by Nick Mathewson's avatar Nick Mathewson 🦞
Browse files

Replace several C identifiers for ticket 18106. 

We used to have a single boolean, "FascistFirewall".  Ages ago, in
tickets #17840 and #9067, we added an improved "ReachableAddresses"
mechanism.  It's time to rename related identifiers in the code for
consistency.  This closes #18106.

This is an automated commit, generated by this command:

./scripts/maint/rename_c_identifier.py \
        fascist_firewall_allows_address reachable_addr_allows \
        fascist_firewall_use_ipv6 reachable_addr_use_ipv6 \
        fascist_firewall_prefer_ipv6_impl reachable_addr_prefer_ipv6_impl \
        fascist_firewall_prefer_ipv6_orport reachable_addr_prefer_ipv6_orport \
        fascist_firewall_prefer_ipv6_dirport reachable_addr_prefer_ipv6_dirport \
        fascist_firewall_allows_address_addr reachable_addr_allows_addr \
        fascist_firewall_allows_address_ap reachable_addr_allows_ap \
        fascist_firewall_allows_base reachable_addr_allows_base \
        fascist_firewall_allows_ri_impl reachable_addr_allows_ri_impl \
        fascist_firewall_allows_rs_impl reachable_addr_allows_rs_impl \
        fascist_firewall_allows_rs reachable_addr_allows_rs \
        fascist_firewall_allows_md_impl reachable_addr_allows_md_impl \
        fascist_firewall_allows_node reachable_addr_allows_node \
        fascist_firewall_allows_dir_server reachable_addr_allows_dir_server \
        fascist_firewall_choose_address_impl reachable_addr_choose_impl \
        fascist_firewall_choose_address reachable_addr_choose \
        fascist_firewall_choose_address_base reachable_addr_choose_base \
        fascist_firewall_choose_address_rs reachable_addr_choose_from_rs \
        fascist_firewall_choose_address_ls reachable_addr_choose_from_ls \
        fascist_firewall_choose_address_node reachable_addr_choose_from_node \
        fascist_firewall_choose_address_dir_server reachable_addr_choose_from_dir_server
parent afd88ee8

src/app/config/or_options_st.h

+2 −2
Original line number Diff line number Diff line
@@ -668,7 +668,7 @@ struct or_options_t { 
  int ClientUseIPv4;

  /** If true, clients may connect over IPv6. If false, they will avoid

   * connecting over IPv4. We enforce this for OR and Dir connections.

   * Use fascist_firewall_use_ipv6() instead of accessing this value

   * Use reachable_addr_use_ipv6() instead of accessing this value

   * directly. */

  int ClientUseIPv6;

  /** If true, prefer an IPv6 OR port over an IPv4 one for entry node
@@ -678,7 +678,7 @@ struct or_options_t { 
  int ClientPreferIPv6ORPort;

  /** If true, prefer an IPv6 directory port over an IPv4 one for direct

   * directory connections. If auto, bridge clients prefer IPv6, and other

   * clients prefer IPv4. Use fascist_firewall_prefer_ipv6_dirport() instead of

   * clients prefer IPv4. Use reachable_addr_prefer_ipv6_dirport() instead of

   * accessing this value directly.  */

  int ClientPreferIPv6DirPort;

src/core/mainloop/connection.c

+6 −6
Original line number Diff line number Diff line
@@ -2246,11 +2246,11 @@ connection_connect_log_client_use_ip_version(const connection_t *conn) 
    return;

  }



  const int must_ipv4 = !fascist_firewall_use_ipv6(options);

  const int must_ipv4 = !reachable_addr_use_ipv6(options);

  const int must_ipv6 = (options->ClientUseIPv4 == 0);

  const int pref_ipv6 = (conn->type == CONN_TYPE_OR

                         ? fascist_firewall_prefer_ipv6_orport(options)

                         : fascist_firewall_prefer_ipv6_dirport(options));

                         ? reachable_addr_prefer_ipv6_orport(options)

                         : reachable_addr_prefer_ipv6_dirport(options));

  tor_addr_t real_addr;

  tor_addr_copy(&real_addr, &conn->addr);
@@ -2275,7 +2275,7 @@ connection_connect_log_client_use_ip_version(const connection_t *conn) 
    return;

  }



  if (fascist_firewall_use_ipv6(options)) {

  if (reachable_addr_use_ipv6(options)) {

    log_info(LD_NET, "Our outgoing connection is using IPv%d.",

             tor_addr_family(&real_addr) == AF_INET6 ? 6 : 4);

  }
@@ -2285,13 +2285,13 @@ connection_connect_log_client_use_ip_version(const connection_t *conn) 
      || (pref_ipv6 && tor_addr_family(&real_addr) == AF_INET)) {

    log_info(LD_NET, "Outgoing connection to %s doesn't satisfy "

             "ClientPreferIPv6%sPort %d, with ClientUseIPv4 %d, and "

             "fascist_firewall_use_ipv6 %d (ClientUseIPv6 %d and UseBridges "

             "reachable_addr_use_ipv6 %d (ClientUseIPv6 %d and UseBridges "

             "%d).",

             fmt_addr(&real_addr),

             conn->type == CONN_TYPE_OR ? "OR" : "Dir",

             conn->type == CONN_TYPE_OR ? options->ClientPreferIPv6ORPort

                                        : options->ClientPreferIPv6DirPort,

             options->ClientUseIPv4, fascist_firewall_use_ipv6(options),

             options->ClientUseIPv4, reachable_addr_use_ipv6(options),

             options->ClientUseIPv6, options->UseBridges);

  }

}

src/core/or/extendinfo.c

+1 −1
Original line number Diff line number Diff line
@@ -102,7 +102,7 @@ extend_info_from_node(const node_t *node, int for_direct_connect) 


  /* Choose a preferred address first, but fall back to an allowed address. */

  if (for_direct_connect)

    fascist_firewall_choose_address_node(node, FIREWALL_OR_CONNECTION, 0, &ap);

    reachable_addr_choose_from_node(node, FIREWALL_OR_CONNECTION, 0, &ap);

  else {

    node_get_prim_orport(node, &ap);

  }

src/core/or/policies.c

+70 −70

File changed.

Preview size limit exceeded, changes collapsed.

src/core/or/policies.h

+13 −13

File changed.

Preview size limit exceeded, changes collapsed.