Commit b4963da9 authored by Nick Mathewson's avatar Nick Mathewson 🤹
Browse files

Treat a bad tor_spawn_background() as a BUG(). 

The contract is that, if may_spawn_background_process() is 0, you're
not even allowed to try to spawn a process.
parent 5fa8d05b

src/common/util.c

+4 −1
Original line number Diff line number Diff line
@@ -4180,8 +4180,11 @@ tor_spawn_background(const char *const filename, const char **argv, 
                     process_environment_t *env,

                     process_handle_t **process_handle_out)

{

  if (may_spawn_background_process == 0)

  if (BUG(may_spawn_background_process == 0)) {

    /* We should never reach this point if we're forbidden to spawn

     * processes. Instead we should have caught the attempt earlier. */

    return PROCESS_STATUS_ERROR;

  }



#ifdef _WIN32

  HANDLE stdout_pipe_read = NULL;