Commit c1a6fb42 authored by Sebastian Hahn's avatar Sebastian Hahn
Browse files

Fix a spec conformance issue when parsing a ns vote

A vote may only contain exactly one signature. Make sure we reject
votes that violate this.

Problem found by Rotor, who also helped writing the patch. Thanks!
parent 3de5ac9b
......@@ -5,6 +5,8 @@ Changes in version - 2009-09-??
Found by Matt Edman. Bugfix on
- Fix parsing for memory or time units given without a space between
the number and the unit. Bugfix on; fixes bug 1076.
- A networkstatus vote must contain exactly one signature. Spec
conformance issue. Bugfix on
Changes in version - 2009-08-26
......@@ -2616,6 +2616,10 @@ networkstatus_parse_vote_from_string(const char *s, const char **eos_out,
if (! n_signatures) {
log_warn(LD_DIR, "No signatures on networkstatus vote.");
goto err;
} else if (ns->type == NS_TYPE_VOTE && n_signatures != 1) {
log_warn(LD_DIR, "Received more than one signature on a "
"network-status vote.");
goto err;
if (eos_out)
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment