Commit f12aad7f authored by Roger Dingledine's avatar Roger Dingledine
Browse files

don't attempt a resolve when the cached answer will do

For relays that don't know their own address, avoid attempting
a local hostname resolve for each descriptor we download. Also cut
down on the number of "Success: chose address 'x.x.x.x'" log lines.

Fixes bugs 20423 and 20610; bugfix on 0.2.8.1-alpha.
parent 3bb40b21
Loading
Loading
Loading
Loading

changes/bug20423

0 → 100644
+6 −0
Original line number Diff line number Diff line
  o Major bugfixes:
    - For relays that don't know their own address, avoid attempting
      a local hostname resolve for each descriptor we download. Also cut
      down on the number of "Success: chose address 'x.x.x.x'" log lines.
      Fixes bugs 20423 and 20610; bugfix on 0.2.8.1-alpha.
+1 −1
Original line number Diff line number Diff line
@@ -1034,7 +1034,7 @@ directory_fetches_from_authorities(const or_options_t *options)
  if (options->BridgeRelay == 1)
    return 0;
  if (server_mode(options) &&
      router_pick_published_address(options, &addr, 0) < 0)
      router_pick_published_address(options, &addr, 1) < 0)
    return 1; /* we don't know our IP address; ask an authority. */
  refuseunknown = ! router_my_exit_policy_is_reject_star() &&
    should_refuse_unknown_exits(options);