1. 03 Oct, 2019 12 commits
  2. 02 Oct, 2019 10 commits
  3. 01 Oct, 2019 6 commits
    • Nick Mathewson's avatar
      Fix a crash bug in max_u16_in_sl() · 2b825a1a
      Nick Mathewson authored
      The documentation for this function says that the smartlist can
      contain NULLs, but the code only handled NULLs if they were at the
      start of the list.
      
      We didn't notice this for a long time, because when Tor is run
      normally, the sequence of msg_id_t is densely packed, and so this
      list (mapping msg_id_t to channel_id_t) contains no NULL elements.
      We could only run into this bug:
        * when Tor was running in embedded mode, and starting more than once.
        * when Tor ran first with more pubsub messages enabled, and then
          later with fewer.
        * When the second run (the one with fewer enabled pubsub messages)
          had at least some messages enabled, and those messages were not
          the ones with numerically highest msg_id_t values.
      
      Fixes bug 31898; bugfix on 47de9c7b
      in 0.4.1.1-alpha.
      2b825a1a
    • Nick Mathewson's avatar
      Add a test for max_u16_in_sl(). · 34bbdaf5
      Nick Mathewson authored
      This test does not currently pass, because of bug 31898.
      34bbdaf5
    • Nick Mathewson's avatar
      Rename max_in_sl to max_in_u16_sl, and expose it as STATIC. · f17591b8
      Nick Mathewson authored
      Since we want to make this function slightly more visible for testing
      purposes, it needs a better name.
      f17591b8
    • Nick Mathewson's avatar
      Add comments to try to prevent recurrence of #31495. · 39640728
      Nick Mathewson authored
      There is a bad design choice in two of our configuration types,
      where the empty string encodes a value that is not the same as the
      default value.  This design choice, plus an implementation mistake,
      meant that config_dup() did not preserve the value of routerset_t,
      and thereby caused bug #31495.
      
      This comment-only patch documents the two types with the problem,
      and suggests that implementors try to avoid it in the future.
      
      Closes ticket 31907.
      39640728
    • George Kadianakis's avatar
    • George Kadianakis's avatar
  4. 30 Sep, 2019 11 commits
  5. 28 Sep, 2019 1 commit