Micah Elizabeth Scott authored Jan 18, 2023 and David Goulet committed Jan 25, 2023

Add new liblzma enums (LZMA_SEEK_NEEDED and LZMA_RET_INTERNAL*)
conditional to the API version they arrived in. The first stable
version of liblzma this affects is 5.4.0

Fixes #40741



Signed-off-by: Micah Elizabeth Scott <beth@torproject.org>

The logic was inverted. Introduced in commit
9155e084.

This was reported through our bug bounty program on H1. It fixes the
TROVE-2022-002.

Fixes #40730



Signed-off-by: David Goulet <dgoulet@torproject.org>

We need the fallbackdir file to be the same so our release CI can
generate a new list and apply it uniformly on all series.

(Same as geoip)

Signed-off-by: David Goulet <dgoulet@torproject.org>

We need all geoip files to be the same so our release CI can generate a
new list and apply it uniformly on all series.

Signed-off-by: David Goulet <dgoulet@torproject.org>

Rotate the relay identity key and v3 identity key for moria1. They
have been online for more than a decade, there was a known potential
compromise, and anyway refreshing keys periodically is good practice.

Advertise new ports too, to avoid confusion.

Closes ticket 40722.

Signed-off-by: David Goulet <dgoulet@torproject.org>

Rasmus Dahlberg authored Oct 12, 2022 and David Goulet committed Nov 28, 2022

This change mitigates DNS-based website oracles by making the time that
a domain name is cached uncertain (+- 4 minutes of what's measurable).

Resolves TROVE-2021-009.

Fixes #40674

Rasmus Dahlberg authored Oct 12, 2022 and David Goulet committed Nov 28, 2022

This change ensures that other parts of the code base always operate on
the same clipped TTL values, notably without being aware of clipping.

Sam James authored Nov 08, 2022 and David Goulet committed Nov 09, 2022

Clang 16 warns on -Wstrict-prototypes in preparation for C23 which can
among other things, lead to some configure tests silently failing/returning the wrong result.

Fixes this error:
```
-ignoreme: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
+ignoreme: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
 main ()
```

For more information, see LWN.net [0] or LLVM's Discourse [1], gentoo-dev@ [2],
or the (new) c-std-porting mailing list [3].

[0] https://lwn.net/Articles/913505/
[1] https://discourse.llvm.org/t/configure-script-breakage-with-the-new-werror-implicit-function-declaration/65213
[2] https://archives.gentoo.org/gentoo-dev/message/dd9f2d3082b8b6f8dfbccb0639e6e240
[3] hosted at lists.linux.dev.

Bug: https://bugs.gentoo.org/879747


Signed-off-by: Sam James <sam@gentoo.org>
---

Closes #40688



Signed-off-by: David Goulet <dgoulet@torproject.org>

Closes #40687



Signed-off-by: David Goulet <dgoulet@torproject.org>

Bug 1: We were purporting to calculate milliseconds per tick, when we
*should* have been computing ticks per millisecond.

Bug 2: Instead of computing either one of those, we were _actually_
computing femtoseconds per tick.

These two bugs covered for one another on x86 hardware, where 1 tick
== 1 nanosecond.  But on M1 OSX, 1 tick is about 41 nanoseconds,
causing surprising results.

Fixes bug 40684; bugfix on 0.3.3.1-alpha.

Fixes #40658



Signed-off-by: David Goulet <dgoulet@torproject.org>

Signed-off-by: David Goulet <dgoulet@torproject.org>

Signed-off-by: David Goulet <dgoulet@torproject.org>

Fixes #40649



Signed-off-by: David Goulet <dgoulet@torproject.org>

Fixes #40604



Signed-off-by: David Goulet <dgoulet@torproject.org>

Previously, `channelpadding_get_netflow_inactive_timeout_ms` would
crash with an assertion failure if `low_timeout` was greater than
`high_timeout`. That wasn't possible in practice because of checks
in `channelpadding_update_padding_for_channel`, but it's better not
to have a function whose correctness is this tricky to prove.

Fixes #40645.  Bugfix on 0.3.1.1-alpha.

Fix from previous commit where a DESTROY cell is sent instead of a
TRUNCATED.

Related to #40623



Signed-off-by: David Goulet <dgoulet@torproject.org>

Note that with this commit, TRUNCATED cells won't be used anymore that
is client and relays won't emit them.

Fixes #40623



Signed-off-by: David Goulet <dgoulet@torproject.org>

See: #40601.