acinclude.m4

@@ -2,7 +2,7 @@ dnl Helper macros for Tor configure.ac
 dnl Copyright (c) 2001-2004, Roger Dingledine
 dnl Copyright (c) 2004-2006, Roger Dingledine, Nick Mathewson
 dnl Copyright (c) 2007-2008, Roger Dingledine, Nick Mathewson
-dnl Copyright (c) 2007-2018, The Tor Project, Inc.
+dnl Copyright (c) 2007-2019, The Tor Project, Inc.
 dnl See LICENSE for licensing information
 
 AC_DEFUN([TOR_EXTEND_CODEPATH],
@@ -166,7 +166,7 @@ AC_CACHE_CHECK([for $1 directory], tor_cv_library_$1_dir, [
 
   for tor_trydir in "$try$1dir" "(system)" "$prefix" /usr/local /usr/pkg $8; do
     LDFLAGS="$tor_saved_LDFLAGS"
-    LIBS="$tor_saved_LIBS $3"
+    LIBS="$3 $tor_saved_LIBS"
     CPPFLAGS="$tor_saved_CPPFLAGS"
 
     if test -z "$tor_trydir" ; then
@@ -219,7 +219,7 @@ AC_CACHE_CHECK([for $1 directory], tor_cv_library_$1_dir, [
   CPPFLAGS="$tor_saved_CPPFLAGS"
 ]) dnl end cache check
 
-LIBS="$LIBS $3"
+LIBS="$3 $LIBS"
 if test "$tor_cv_library_$1_dir" != "(system)"; then
    TOR_EXTEND_CODEPATH($tor_cv_library_$1_dir)
 fi

autogen.sh

 #!/bin/sh
 
-if [ -x "`which autoreconf 2>/dev/null`" ] ; then
+if command -v autoreconf; then
   opt="-i -f -W all,error"
 
-  for i in $@; do
+  for i in "$@"; do
     case "$i" in
       -v)
         opt="${opt} -v"
@@ -11,6 +11,7 @@ if [ -x "`which autoreconf 2>/dev/null`" ] ; then
     esac
   done
 
+  # shellcheck disable=SC2086
   exec autoreconf $opt
 fi
 

changes/bug22156

-  o Minor features (development):
-    - Tor's makefile now supports running the "clippy" Rust style tool
-      on our Rust code. Closes ticket 22156.

changes/bug25477

-  o Minor bugfixes (logging):
-    - Refrain from mentioning bug 21018, as it is already fixed.
-      Fixes bug 25477; bugfix on 0.2.9.8.

changes/bug25552

-  o Major feature (onion services):
-    - Improve revision counter generation in next-gen onion services. Onion
-      services can now scale by hosting multiple instances on different hosts
-      without synchronization between them, which was previously impossible
-      because descriptors would get rejected by HSDirs. Addresses ticket 25552.

changes/bug25886

-  o Minor bugfixes (relay):
-    - In frac_nodes_with_descriptors(), add for_direct_connect, and replace
-      node_has_any_descriptor() with node_has_preferred_descriptor(). Also,
-      if we are using bridges and there is at least one bridge with a full
-      descriptor, set f_guard in compute_frac_paths_available() to 1.0.
-      Fixes bug 25886; bugfix on 0.3.5.1-alpha. Patch by Neel Chauhan.
-

changes/bug26152

-  o Minor bugfixes (testing):
-    - When logging a version mismatch in our openssl_version tests,
-      report the actual offending version strings. Fixes bug 26152; bugfix on
-      0.2.9.1-alpha.

changes/bug26223

-  o Minor features (directory authority):
-    - There is no longer an artificial upper limit on the length of bandwidth
-      lines. Closes ticket 26223.

changes/bug26282

-  o Minor bugfixes (C correctness):
-    - Avoid casting smartlist index to int implicitly, as it may trigger
-      a warning (-Wshorten-64-to-32). Fixes bug 26282; bugfix on
-      0.2.3.13-alpha, 0.2.7.1-alpha and 0.2.1.1-alpha.

changes/bug26437

-  o Testing:
-    - Fix forking tests on Windows when there is a space somewhere in the path.
-      Fixes bug 26437; bugfix on 0.2.2.4-alpha.

changes/bug26485

-  o Minor bugfixes (directory authority):
-    - When voting for recommended versions, make sure that all of the
-      versions are well-formed and parsable. Fixes bug 26485; bugfix on
-      0.1.1.6-alpha.

changes/bug26488

-  o Major bugfixes (directory authority):
-    - Actually check that address we get from DirAuthority configuration
-      line is valid IPv4. Explicitly disallow DirAuthority adress to be
-      DNS hostname. Fixes bug 26488; bugfix on 0.1.2.10-rc.

changes/bug26502

-  o Code simplification and refactoring:
-    - 'updateFallbackDirs.py' now ignores the blacklist file as it's not longer needed
-      Closes ticket 26502.

changes/bug26522

-  o Minor bugfixes (security):
-    - Refrain from potentially insecure usage of strncat() in
-      configure_backtrace_handler(). Use snprintf() instead.
-      Fixes bug 26522; bugfix on
-      a969ce464dc23db39725a891d60537f3d3e51b50 (not in any tor
-      release).

changes/bug26525

-  o Minor bugfixes (code quality):
-     - Rename sandbox_getaddrinfo() and other functions to no longer
-       misleadingly suggest that they are sandbox-only. Fixes bug
-       26525; bugfix on 0.2.7.1-alpha.

changes/bug26627

-  o Minor bugfixes (v3 onion services):
-    - Stop sending ed25519 link specifiers in v3 onion service introduce
-      cells, when the rendezvous point doesn't support ed25519 link
-      authentication. Fixes bug 26627; bugfix on 0.3.2.4-alpha.
-    - Stop putting ed25519 link specifiers in v3 onion service descriptors,
-      when the intro point doesn't support ed25519 link authentication.
-      Fixes bug 26627; bugfix on 0.3.2.4-alpha.

changes/bug26785

-  o Minor bugfixes (compilation, portability):
-    - Don't try to use a pragma to temporarily disable
-      -Wunused-const-variable if the compiler doesn't support it.
-      Fixes bug 26785; bugfix on 0.3.2.11.

changes/bug26787

-  o Minor bugfixes (testing):
-    - Disable core dumps in test_bt.sh, to avoid failures in "make
-      distcheck". Fixes bug 26787; bugfix on 0.2.5.2-alpha.

changes/bug26789

-  o Minor bugfixes (compilation):
-     - Update build system so that tor builds again with
-       --disable-unittests after recent refactoring efforts.
-       Fixes bug 26789; bugfix on 0.3.4.3-alpha.

changes/bug26830

-  o Minor bugfixes (continuous integration):
-    - Skip an unreliable key generation test on Windows, until the underlying
-      issue in bug 26076 is resolved. Fixes bug 26830; bugfix on 0.2.7.3-rc.