Tor issueshttps://gitlab.torproject.org/tpo/core/tor/-/issues2021-06-23T17:22:41Zhttps://gitlab.torproject.org/tpo/core/tor/-/issues/33503LeakSanitizer detected memory leak with Tor 0.4.4.0-alpha-dev (git-6472d9cfdf...2021-06-23T17:22:41ZGeorg KoppenLeakSanitizer detected memory leak with Tor 0.4.4.0-alpha-dev (git-6472d9cfdf1198cf)I hit a memory leak with the latest `tor` code from `master` when using it in Tor Browser.
```
Direct leak of 112 byte(s) in 2 object(s) allocated from:
#0 0x7fdee552d628 in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.5+0x107628)
...I hit a memory leak with the latest `tor` code from `master` when using it in Tor Browser.
```
Direct leak of 112 byte(s) in 2 object(s) allocated from:
#0 0x7fdee552d628 in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.5+0x107628)
#1 0x55e7f567b5fa in tor_malloc_ ../src/lib/malloc/malloc.c:45
#2 0x55e7f567b690 in tor_malloc_zero_ ../src/lib/malloc/malloc.c:71
#3 0x55e7f5478339 in cache_client_desc_new ../src/feature/hs/hs_cache.c:429
#4 0x55e7f5478339 in hs_cache_store_as_client ../src/feature/hs/hs_cache.c:830
#5 0x55e7f5487e50 in client_dir_fetch_200 ../src/feature/hs/hs_client.c:1372
#6 0x55e7f5487e50 in hs_client_dir_fetch_done ../src/feature/hs/hs_client.c:2264
#7 0x55e7f54445fa in handle_response_fetch_hsdesc_v3 ../src/feature/dirclient/dirclient.c:2776
#8 0x55e7f54445fa in connection_dir_client_reached_eof ../src/feature/dirclient/dirclient.c:2202
#9 0x55e7f54445fa in connection_dir_reached_eof ../src/feature/dirclient/dirclient.c:2989
#10 0x55e7f52e5505 in connection_reached_eof ../src/core/mainloop/connection.c:5029
#11 0x55e7f52e5505 in connection_handle_read_impl ../src/core/mainloop/connection.c:3776
#12 0x55e7f52e5505 in connection_handle_read ../src/core/mainloop/connection.c:3788
#13 0x55e7f52f18e0 in conn_read_callback ../src/core/mainloop/mainloop.c:892
#14 0x7fdee528eb0e (/usr/lib/x86_64-linux-gnu/libevent-2.1.so.7+0x23b0e)
```
I've attached all the direct/indirect leaks that LeakSanitizer gave me, in case there is more lurking.Tor: 0.4.4.x-finalDavid Gouletdgoulet@torproject.orgDavid Gouletdgoulet@torproject.orghttps://gitlab.torproject.org/tpo/core/tor/-/issues/33491tor_bug_occurred_: Bug: src/core/or/dos.c:697: dos_new_client_conn: Non-fatal...2022-10-11T23:39:34ZTractor_bug_occurred_: Bug: src/core/or/dos.c:697: dos_new_client_conn: Non-fatal assertion !(entry == NULL) failed. (Future instances of this warning will be silenced.) (on Tor 0.4.2.6 )Hi there,
Receiving the below report, searched for 'src/core/or/dos.c:697' no hits, so opening ticket, please let me know if further info is needed to troubleshoot.
FreeBSD <<hostname>> 12.1-RELEASE-p2 FreeBSD 12.1-RELEASE-p2 GENERIC ...Hi there,
Receiving the below report, searched for 'src/core/or/dos.c:697' no hits, so opening ticket, please let me know if further info is needed to troubleshoot.
FreeBSD <<hostname>> 12.1-RELEASE-p2 FreeBSD 12.1-RELEASE-p2 GENERIC amd64
```
Mar 1 13:53:33 <<hostname>> Tor[86742]: tor_bug_occurred_: Bug: src/core/or/dos.c:697: dos_new_client_conn: Non-fatal assertion !(entry == NULL) failed. (Future instances of this warning will be silenced.) (on Tor 0.4.2.6 )
Mar 1 13:53:33 <<hostname>> Tor[86742]: Bug: Tor 0.4.2.6: Non-fatal assertion !(entry == NULL) failed in dos_new_client_conn at src/core/or/dos.c:697. Stack trace: (on Tor 0.4.2.6 )
Mar 1 13:53:33 <<hostname>> Tor[86742]: Bug: 0x12f4acc <log_backtrace_impl+0x5c> at /usr/local/bin/tor (on Tor 0.4.2.6 )
Mar 1 13:53:33 <<hostname>> Tor[86742]: Bug: 0x12f0b76 <tor_bug_occurred_+0x1d6> at /usr/local/bin/tor (on Tor 0.4.2.6 )
Mar 1 13:53:33 <<hostname>> Tor[86742]: Bug: 0x118d9a5 <channel_do_open_actions+0xf5> at /usr/local/bin/tor (on Tor 0.4.2.6 )
Mar 1 13:53:33 <<hostname>> Tor[86742]: Bug: 0x118d88e <channel_change_state_open+0x2e> at /usr/local/bin/tor (on Tor 0.4.2.6 )
Mar 1 13:53:33 <<hostname>> Tor[86742]: Bug: 0x1191a57 <channel_tls_handle_state_change_on_orconn+0x67> at /usr/local/bin/tor (on Tor 0.4.2.6 )
Mar 1 13:53:33 <<hostname>> Tor[86742]: Bug: 0x1144946 <connection_or_set_state_open+0x26> at /usr/local/bin/tor (on Tor 0.4.2.6 )
Mar 1 13:53:33 <<hostname>> Tor[86742]: Bug: 0x11923ee <channel_tls_handle_cell+0x88e> at /usr/local/bin/tor (on Tor 0.4.2.6 )
Mar 1 13:53:33 <<hostname>> Tor[86742]: Bug: 0x1140d52 <connection_or_process_inbuf+0x152> at /usr/local/bin/tor (on Tor 0.4.2.6 )
Mar 1 13:53:33 <<hostname>> Tor[86742]: Bug: 0x114ddad <connection_handle_read+0x8fd> at /usr/local/bin/tor (on Tor 0.4.2.6 )
Mar 1 13:53:33 <<hostname>> Tor[86742]: Bug: 0x119e3ee <connection_add_impl+0x23e> at /usr/local/bin/tor (on Tor 0.4.2.6 )
Mar 1 13:53:33 <<hostname>> Tor[86742]: Bug: 0x8013d72b3 <event_base_assert_ok_nolock_+0xc23> at /usr/local/lib/libevent-2.1.so.7 (on Tor 0.4.2.6 )
Mar 1 13:53:33 <<hostname>> Tor[86742]: Bug: 0x8013d318f <event_base_loop+0x53f> at /usr/local/lib/libevent-2.1.so.7 (on Tor 0.4.2.6 )
Mar 1 13:53:33 <<hostname>> Tor[86742]: Bug: 0x11a0881 <do_main_loop+0xf1> at /usr/local/bin/tor (on Tor 0.4.2.6 )
Mar 1 13:53:33 <<hostname>> Tor[86742]: Bug: 0x113de68 <tor_run_main+0x128> at /usr/local/bin/tor (on Tor 0.4.2.6 )
Mar 1 13:53:33 <<hostname>> Tor[86742]: Bug: 0x113c656 <tor_main+0x66> at /usr/local/bin/tor (on Tor 0.4.2.6 )
Mar 1 13:53:33 <<hostname>> Tor[86742]: Bug: 0x113c309 <main+0x19> at /usr/local/bin/tor (on Tor 0.4.2.6 )
Mar 1 13:54:37 <<hostname>> Tor[86742]: tor_bug_occurred_: Bug: src/core/or/dos.c:697: dos_new_client_conn: Non-fatal assertion !(entry == NULL) failed. (Future instances of this warning will be silenced.) (on Tor 0.4.2.6 )
Mar 1 13:54:37 <<hostname>> Tor[86742]: Bug: Tor 0.4.2.6: Non-fatal assertion !(entry == NULL) failed in dos_new_client_conn at src/core/or/dos.c:697. Stack trace: (on Tor 0.4.2.6 )
Mar 1 13:54:37 <<hostname>> Tor[86742]: Bug: 0x12f4acc <log_backtrace_impl+0x5c> at /usr/local/bin/tor (on Tor 0.4.2.6 )
Mar 1 13:54:37 <<hostname>> Tor[86742]: Bug: 0x12f0b76 <tor_bug_occurred_+0x1d6> at /usr/local/bin/tor (on Tor 0.4.2.6 )
Mar 1 13:54:37 <<hostname>> Tor[86742]: Bug: 0x118d9a5 <channel_do_open_actions+0xf5> at /usr/local/bin/tor (on Tor 0.4.2.6 )
Mar 1 13:54:37 <<hostname>> Tor[86742]: Bug: 0x118d88e <channel_change_state_open+0x2e> at /usr/local/bin/tor (on Tor 0.4.2.6 )
Mar 1 13:54:37 <<hostname>> Tor[86742]: Bug: 0x1191a57 <channel_tls_handle_state_change_on_orconn+0x67> at /usr/local/bin/tor (on Tor 0.4.2.6 )
Mar 1 13:54:37 <<hostname>> Tor[86742]: Bug: 0x1144946 <connection_or_set_state_open+0x26> at /usr/local/bin/tor (on Tor 0.4.2.6 )
Mar 1 13:54:37 <<hostname>> Tor[86742]: Bug: 0x11923ee <channel_tls_handle_cell+0x88e> at /usr/local/bin/tor (on Tor 0.4.2.6 )
Mar 1 13:54:37 <<hostname>> Tor[86742]: Bug: 0x1140d52 <connection_or_process_inbuf+0x152> at /usr/local/bin/tor (on Tor 0.4.2.6 )
Mar 1 13:54:37 <<hostname>> Tor[86742]: Bug: 0x114ddad <connection_handle_read+0x8fd> at /usr/local/bin/tor (on Tor 0.4.2.6 )
Mar 1 13:54:37 <<hostname>> Tor[86742]: Bug: 0x119e3ee <connection_add_impl+0x23e> at /usr/local/bin/tor (on Tor 0.4.2.6 )
Mar 1 13:54:37 <<hostname>> Tor[86742]: Bug: 0x8013d72b3 <event_base_assert_ok_nolock_+0xc23> at /usr/local/lib/libevent-2.1.so.7 (on Tor 0.4.2.6 )
Mar 1 13:54:37 <<hostname>> Tor[86742]: Bug: 0x8013d318f <event_base_loop+0x53f> at /usr/local/lib/libevent-2.1.so.7 (on Tor 0.4.2.6 )
Mar 1 13:54:37 <<hostname>> Tor[86742]: Bug: 0x11a0881 <do_main_loop+0xf1> at /usr/local/bin/tor (on Tor 0.4.2.6 )
Mar 1 13:54:37 <<hostname>> Tor[86742]: Bug: 0x113de68 <tor_run_main+0x128> at /usr/local/bin/tor (on Tor 0.4.2.6 )
Mar 1 13:54:37 <<hostname>> Tor[86742]: Bug: 0x113c656 <tor_main+0x66> at /usr/local/bin/tor (on Tor 0.4.2.6 )
Mar 1 13:54:37 <<hostname>> Tor[86742]: Bug: 0x113c309 <main+0x19> at /usr/local/bin/tor (on Tor 0.4.2.6 )
```
**Trac**:
**Username**: sjcjonkerTor: 0.3.5.x-finalDavid Gouletdgoulet@torproject.orgDavid Gouletdgoulet@torproject.orghttps://gitlab.torproject.org/tpo/core/tor/-/issues/33469INTERNAL ERROR: Raw assertion failed at src/lib/malloc/map_anon.c:239: lock_r...2022-06-17T18:06:22ZTracINTERNAL ERROR: Raw assertion failed at src/lib/malloc/map_anon.c:239: lock_result == 0I tried updating to latest stable version and I have this error after a couple of minutes:
```
Feb 27 14:38:04.987 [notice] Tor 0.4.2.6 (git-971a6beff5a53434) running on Windows Server 2003 with Libevent 2.1.8-stable, OpenSSL 1.1.1d, Zli...I tried updating to latest stable version and I have this error after a couple of minutes:
```
Feb 27 14:38:04.987 [notice] Tor 0.4.2.6 (git-971a6beff5a53434) running on Windows Server 2003 with Libevent 2.1.8-stable, OpenSSL 1.1.1d, Zlib 1.2.11, Liblzma N/A, and Libzstd N/A.
Feb 27 14:38:05.003 [notice] Tor can't help you if you use it wrong! Learn how to be safe at https://www.torproject.org/download/download#warning
Feb 27 14:38:05.018 [notice] Read configuration file "U:\2\Server\TOR\tor.ini".
Feb 27 14:38:05.018 [notice] Based on detected system memory, MaxMemInQueues is set to 2048 MB. You can override this by setting MaxMemInQueues by hand.
Feb 27 14:38:05.034 [warn] You specified a public address '0.0.0.0:8080' for SocksPort. Other people on the Internet might find your computer and use it as an open proxy. Please don't allow this unless you have a good reason.
Feb 27 14:38:05.034 [notice] Opening Socks listener on 0.0.0.0:8080
Feb 27 14:38:05.034 [notice] Opened Socks listener on 0.0.0.0:8080
Feb 27 14:38:05.034 [notice] Opening Control listener on 127.0.0.1:9051
Feb 27 14:38:05.049 [notice] Opened Control listener on 127.0.0.1:9051
Feb 27 14:38:05.049 [notice] Opening OR listener on 0.0.0.0:9001
Feb 27 14:38:05.049 [notice] Opened OR listener on 0.0.0.0:9001
Feb 27 14:38:05.049 [notice] Opening Directory listener on 0.0.0.0:9030
Feb 27 14:38:05.049 [notice] Opened Directory listener on 0.0.0.0:9030
============================================================ T= 1582807176
INTERNAL ERROR: Raw assertion failed in Tor 0.4.2.6 (git-971a6beff5a53434) at src/lib/malloc/map_anon.c:239: lock_result == 0
```
**Trac**:
**Username**: m95dhttps://gitlab.torproject.org/tpo/core/tor/-/issues/33463Correct spacing in dns_launch_correctness_checks()2020-06-27T13:48:07ZNeel Chauhanneel@neelc.orgCorrect spacing in dns_launch_correctness_checks()Tor: 0.4.4.x-finalNeel Chauhanneel@neelc.orgNeel Chauhanneel@neelc.orghttps://gitlab.torproject.org/tpo/core/tor/-/issues/33458Assertion desc failed in hs_client_close_intro_circuits_from_desc at src/feat...2021-06-23T17:22:41ZGeorge KadianakisAssertion desc failed in hs_client_close_intro_circuits_from_desc at src/feature/hs/hs_client.c: 2413Just got this assert failure in my TBB. I had a v3 onion open, and long ago I visited a client-auth onion that I didn't manage to decrypt so it lingered in my cache with `->desc` set to `NULL`.
```
Feb 26 14:17:31.000 [err] tor_asserti...Just got this assert failure in my TBB. I had a v3 onion open, and long ago I visited a client-auth onion that I didn't manage to decrypt so it lingered in my cache with `->desc` set to `NULL`.
```
Feb 26 14:17:31.000 [err] tor_assertion_failed_(): Bug: src/feature/hs/hs_client.c:2413: hs_client_close_intro_circuits_from_desc: Assertion desc failed; aborting. (on T
or 0.4.3.2-alpha dcbf6611d9980953)
Feb 26 14:17:31.000 [err] Bug: Tor 0.4.3.2-alpha (git-dcbf6611d9980953): Assertion desc failed in hs_client_close_intro_circuits_from_desc at src/feature/hs/hs_client.c:
2413: . Stack trace: (on Tor 0.4.3.2-alpha dcbf6611d9980953)
Feb 26 14:17:31.000 [err] Bug: /home/f/tor-browser_en-US/Browser/TorBrowser/Tor/tor(log_backtrace_impl+0x56) [0x5623c8fe6e96] (on Tor 0.4.3.2-alpha dcbf6611d9980953)
Feb 26 14:17:31.000 [err] Bug: /home/f/tor-browser_en-US/Browser/TorBrowser/Tor/tor(tor_assertion_failed_+0x147) [0x5623c8fe1f97] (on Tor 0.4.3.2-alpha dcbf6611d9980
953)
Feb 26 14:17:31.000 [err] Bug: /home/f/tor-browser_en-US/Browser/TorBrowser/Tor/tor(hs_client_close_intro_circuits_from_desc+0xb6) [0x5623c8ee7c76] (on Tor 0.4.3.2-a
lpha dcbf6611d9980953)
Feb 26 14:17:31.000 [err] Bug: /home/f/tor-browser_en-US/Browser/TorBrowser/Tor/tor(hs_cache_clean_as_client+0xf2) [0x5623c8edfbd2] (on Tor 0.4.3.2-alpha dcbf6611d99
80953)
Feb 26 14:17:31.000 [err] Bug: /home/f/tor-browser_en-US/Browser/TorBrowser/Tor/tor(+0x6ebbc) [0x5623c8e3fbbc] (on Tor 0.4.3.2-alpha dcbf6611d9980953)
Feb 26 14:17:31.000 [err] Bug: /home/f/tor-browser_en-US/Browser/TorBrowser/Tor/tor(+0x73487) [0x5623c8e44487] (on Tor 0.4.3.2-alpha dcbf6611d9980953)
Feb 26 14:17:31.000 [err] Bug: ./TorBrowser/Tor/libevent-2.1.so.6(+0x22565) [0x7f3c28b8a565] (on Tor 0.4.3.2-alpha dcbf6611d9980953)
Feb 26 14:17:31.000 [err] Bug: ./TorBrowser/Tor/libevent-2.1.so.6(event_base_loop+0x517) [0x7f3c28b8af27] (on Tor 0.4.3.2-alpha dcbf6611d9980953)
Feb 26 14:17:31.000 [err] Bug: /home/f/tor-browser_en-US/Browser/TorBrowser/Tor/tor(do_main_loop+0xdb) [0x5623c8e4372b] (on Tor 0.4.3.2-alpha dcbf6611d9980953)
Feb 26 14:17:31.000 [err] Bug: /home/f/tor-browser_en-US/Browser/TorBrowser/Tor/tor(tor_run_main+0x10b5) [0x5623c8e309f5] (on Tor 0.4.3.2-alpha dcbf6611d9980953)
Feb 26 14:17:31.000 [err] Bug: /home/f/tor-browser_en-US/Browser/TorBrowser/Tor/tor(tor_main+0x3a) [0x5623c8e2e19a] (on Tor 0.4.3.2-alpha dcbf6611d9980953)
Feb 26 14:17:31.000 [err] Bug: /home/f/tor-browser_en-US/Browser/TorBrowser/Tor/tor(main+0x19) [0x5623c8e2dd39] (on Tor 0.4.3.2-alpha dcbf6611d9980953)
Feb 26 14:17:31.000 [err] Bug: /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xeb) [0x7f3c28207bbb] (on Tor 0.4.3.2-alpha dcbf6611d9980953)
Feb 26 14:17:31.000 [err] Bug: /home/f/tor-browser_en-US/Browser/TorBrowser/Tor/tor(+0x5cd89) [0x5623c8e2dd89] (on Tor 0.4.3.2-alpha dcbf6611d9980953)
```Tor: 0.4.4.x-finalDavid Gouletdgoulet@torproject.orgDavid Gouletdgoulet@torproject.orghttps://gitlab.torproject.org/tpo/core/tor/-/issues/33437Unsuccessful compilation of tor on FreeBSD system with libssl.so.112020-09-23T13:43:20ZTracUnsuccessful compilation of tor on FreeBSD system with libssl.so.11+Sebastian | so, this looks like a configure error in detecting available openssl correctly. Please file a bug
----
I'm running into a compilation error related to openssl while compiling tor-0.4.2.6 on FreeBSD 11.3 (amd64). Log files a...+Sebastian | so, this looks like a configure error in detecting available openssl correctly. Please file a bug
----
I'm running into a compilation error related to openssl while compiling tor-0.4.2.6 on FreeBSD 11.3 (amd64). Log files are attached.
Notes:
- compilation of **0.4.2.6** with **libssl.so.9** was successful
- compilation of **0.4.2.6** with **libssl.so.11** was unsuccessful
----
**Trac**:
**Username**: stillicideTor: 0.4.5.x-freezeNick MathewsonNick Mathewsonhttps://gitlab.torproject.org/tpo/core/tor/-/issues/33436Remove all non-dirauth usage of dirauth timing options.2021-09-16T14:22:17ZNick MathewsonRemove all non-dirauth usage of dirauth timing options.There's code in shared_random_client.c that uses dirauth-only options, directly or indirectly. It shouldn't, since clients should only be looking at the consensus to learn what the vote schedule is.There's code in shared_random_client.c that uses dirauth-only options, directly or indirectly. It shouldn't, since clients should only be looking at the consensus to learn what the vote schedule is.Tor: 0.4.4.x-finalNick MathewsonNick Mathewsonhttps://gitlab.torproject.org/tpo/core/tor/-/issues/33427Link to the auto-generated documentation in GettingStarted.md2020-06-27T13:48:08ZteorLink to the auto-generated documentation in GettingStarted.mdOur GettingStarted.md developer document still links to the old torguts git repository:
https://gitweb.torproject.org/tor.git/tree/doc/HACKING/GettingStarted.md#n53
But it should link to our new auto-generated documentation.
I don't kn...Our GettingStarted.md developer document still links to the old torguts git repository:
https://gitweb.torproject.org/tor.git/tree/doc/HACKING/GettingStarted.md#n53
But it should link to our new auto-generated documentation.
I don't know the details of the new docs website. But it would be nice to have it done for Outreachy.Tor: 0.4.3.x-finalhttps://gitlab.torproject.org/tpo/core/tor/-/issues/33417remove nickname from MyFamily man page section2020-11-04T14:18:22Znusenuremove nickname from MyFamily man page sectionThis is originally from https://trac.torproject.org/projects/tor/ticket/22223#comment:6
but it is still in the man page as of 0.4.2.6
Please remove this phrase from the tor man page
```
When listing a node, it's better to list it ...This is originally from https://trac.torproject.org/projects/tor/ticket/22223#comment:6
but it is still in the man page as of 0.4.2.6
Please remove this phrase from the tor man page
```
When listing a node, it's better to list it by fingerprint than by
nickname: fingerprints are more reliable.
```Tor: 0.4.4.x-finalhttps://gitlab.torproject.org/tpo/core/tor/-/issues/33409Pre-commit hook does not stash unstaged changes before running code style che...2020-07-29T14:34:18Zrl1987Pre-commit hook does not stash unstaged changes before running code style checkersHow to reproduce:
1) Make some changes to C files and violate whitespace rules.
2) `git add` affected files and try to `git commit`. Pre-commit hook will not allow it and will print the whitespace issues it found.
3) Fix whitespace prob...How to reproduce:
1) Make some changes to C files and violate whitespace rules.
2) `git add` affected files and try to `git commit`. Pre-commit hook will not allow it and will print the whitespace issues it found.
3) Fix whitespace problems, but forget to `git add` the files.
4) Running `git commit` again does not reject the changes, despite whitespace fixes not being staged. New commit now includes whitespace violations and none of the fixes that were done in step 3.
This is not limited to whitespace issues, but could affect other code style checks as well.Tor: 0.4.5.x-freezehttps://gitlab.torproject.org/tpo/core/tor/-/issues/33407Make chutney bridge authorities publish bridges in their networkstatus-bridges2020-07-20T16:07:45ZteorMake chutney bridge authorities publish bridges in their networkstatus-bridgesThis issue depends on the tor bridge descriptor upload fix in legacy/trac#33582, or robust reachability self-tests in legacy/trac#33222.
Chutney bridge authorities don't have any bridges in their networkstatus-bridges. That's a problem,...This issue depends on the tor bridge descriptor upload fix in legacy/trac#33582, or robust reachability self-tests in legacy/trac#33222.
Chutney bridge authorities don't have any bridges in their networkstatus-bridges. That's a problem, because we want to check networkstatus-bridges for the reachability checks in legacy/trac#33232.
Once bridges upload their descriptors, we can make chutney check the bridge authority's networkstatus-bridges for bridge nicknames (this ticket).
We can only do the networkstatus-bridges check on tor versions with the legacy/trac#33222 or legacy/trac#33582 fixes. So we'll need to check for:
* the next tor 0.4.4-alpha version, or
* an environmental variable that enables these tests.
We don't have to do these fixes, because it should be enough to test relay reachability. But we would risk breaking bridge reachability tests, and not knowing about it until after a release.Tor: 0.4.4.x-finalhttps://gitlab.torproject.org/tpo/core/tor/-/issues/33389Disable routerkeys.c and part of connection_or.c when building without relay ...2020-06-27T13:48:10ZNick MathewsonDisable routerkeys.c and part of connection_or.c when building without relay mode.Tor: 0.4.4.x-finalNick MathewsonNick Mathewsonhttps://gitlab.torproject.org/tpo/core/tor/-/issues/33374Fix unicode warnings in practracker using python 22020-06-27T13:48:10ZteorFix unicode warnings in practracker using python 2When I run practracker using python 2, I get the following unicode warning:
```
$ scripts/maint/practracker/practracker.py --regen-overbroad
Traceback (most recent call last):
File "scripts/maint/practracker/practracker.py", line 324, ...When I run practracker using python 2, I get the following unicode warning:
```
$ scripts/maint/practracker/practracker.py --regen-overbroad
Traceback (most recent call last):
File "scripts/maint/practracker/practracker.py", line 324, in <module>
main(sys.argv)
File "scripts/maint/practracker/practracker.py", line 268, in main
for item in filt.filter(consider_all_metrics(files_list)):
File "/Users/hyper/dev/tor/scripts/maint/practracker/problem.py", line 147, in filter
for item in iter(sequence):
File "scripts/maint/practracker/practracker.py", line 110, in consider_all_metrics
for item in consider_metrics_for_file(fname, f):
File "scripts/maint/practracker/practracker.py", line 134, in consider_metrics_for_file
for item in consider_function_size(fname, f):
File "scripts/maint/practracker/practracker.py", line 91, in consider_function_size
for name, lines in metrics.get_function_lines(f):
File "/Users/hyper/dev/tor/scripts/maint/practracker/metrics.py", line 58, in get_function_lines
if line.startswith("}"):
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 22: ordinal not in range(128)
Exit 1
```
We can fix this issue by using the codecs module to open files in unicode mode.Tor: 0.4.3.x-finalteorteorhttps://gitlab.torproject.org/tpo/core/tor/-/issues/33370Don't build selftest.c when relay mode is disabled2020-06-27T13:48:11ZNick MathewsonDon't build selftest.c when relay mode is disabledTor: 0.4.4.x-finalNick MathewsonNick Mathewsonhttps://gitlab.torproject.org/tpo/core/tor/-/issues/33368Don't compile ext_orport.c when relay mode is disabled.2020-06-27T13:48:11ZNick MathewsonDon't compile ext_orport.c when relay mode is disabled.Tor: 0.4.4.x-finalNick MathewsonNick Mathewsonhttps://gitlab.torproject.org/tpo/core/tor/-/issues/33366Disable dns.c when relay mode is disabled2020-06-27T13:48:12ZNick MathewsonDisable dns.c when relay mode is disabledTor: 0.4.4.x-finalNick MathewsonNick Mathewsonhttps://gitlab.torproject.org/tpo/core/tor/-/issues/33361relay: Warn about the lack of ContactInfo and the consequence2020-11-04T14:18:22ZDavid Gouletdgoulet@torproject.orgrelay: Warn about the lack of ContactInfo and the consequenceThe network health team (including bad relays) as been rejecting group of relays more and more that do not have their `ContactInfo` or/and `MyFamily` set (for a group of relays from the same operator).
These are for safety and health pu...The network health team (including bad relays) as been rejecting group of relays more and more that do not have their `ContactInfo` or/and `MyFamily` set (for a group of relays from the same operator).
These are for safety and health purposes of the network. See the relay guidelines for that.
That being said, we should improve the log notice that an operator get when failing to set `ContactInfo` to a warning and adding a sentence that says they might get rejected from the network due to a lack of valid responsive `ContactInfo`.
I would argue that this needs a backport for our maintained versions. Please, let me know if not agreeing with thatTor: 0.4.2.x-finalhttps://gitlab.torproject.org/tpo/core/tor/-/issues/33354Warning: Padding negotiated cell from wrong hop on circuit2020-06-27T13:48:12ZteorWarning: Padding negotiated cell from wrong hop on circuitRunning chutney's single-onion-v23 network, I see the following warnings:
```
Warning: Padding negotiated cell from wrong hop on circuit
Warning: Received circuit padding stop command for unknown machine
```
These chutney networks are r...Running chutney's single-onion-v23 network, I see the following warnings:
```
Warning: Padding negotiated cell from wrong hop on circuit
Warning: Received circuit padding stop command for unknown machine
```
These chutney networks are running 0.4.4.0-alpha-dev (f231827946).
These warnings appear to be timing-dependent, they don't happen all the time.Tor: 0.4.4.x-finalhttps://gitlab.torproject.org/tpo/core/tor/-/issues/33352Warning: RELAY_COMMAND_INTRODUCE_ACK on padding circuit2022-11-19T20:47:42ZteorWarning: RELAY_COMMAND_INTRODUCE_ACK on padding circuitWhen I run the new mixed+hs-v23-ipv6 chutney network from legacy/trac#33333, I see the following warning:
```
Ignored cell (40) that arrived in padding circuit 32.
```
I am running Tor 3.5.8 and 0.4.4.0-alpha (a6509cb867).
This issue a...When I run the new mixed+hs-v23-ipv6 chutney network from legacy/trac#33333, I see the following warning:
```
Ignored cell (40) that arrived in padding circuit 32.
```
I am running Tor 3.5.8 and 0.4.4.0-alpha (a6509cb867).
This issue appears to be timing-dependent: I saw it on one run, but I did not see it on the next one.Tor: 0.4.4.x-finalGeorge KadianakisGeorge Kadianakishttps://gitlab.torproject.org/tpo/core/tor/-/issues/33346Seccomp soft fail (no write) in 0.4.2.62021-01-28T17:58:13ZTracSeccomp soft fail (no write) in 0.4.2.6I've upgraded to 0.4.2.6 (as a good software user, but also because I noticed the seccomp changes).
Tor successfully starts with seccomp, but 'soft fails' because it can't write to its data directory (here: /var/lib/tor/data). Tor has p...I've upgraded to 0.4.2.6 (as a good software user, but also because I noticed the seccomp changes).
Tor successfully starts with seccomp, but 'soft fails' because it can't write to its data directory (here: /var/lib/tor/data). Tor has permissions to write to this directory - fine with Sandbox 0.
Log:
```
# cat /var/log/tor/log
Feb 16 00:46:56.000 [notice] Tor 0.4.2.6 opening new log file.
Feb 16 00:46:56.000 [notice] Parsing GEOIP IPv4 file /usr/share/tor/geoip.
Feb 16 00:46:57.000 [notice] Parsing GEOIP IPv6 file /usr/share/tor/geoip6.
Feb 16 00:46:57.000 [notice] Bootstrapped 0% (starting): Starting
Feb 16 00:46:57.000 [warn] Could not open "/var/lib/tor/data/cached-certs": Operation not permitted
Feb 16 00:46:57.000 [warn] Could not open "/var/lib/tor/data/cached-consensus" for mmap(): Operation not permitted
Feb 16 00:46:57.000 [warn] Could not open "/var/lib/tor/data/unverified-consensus" for mmap(): Operation not permitted
Feb 16 00:46:57.000 [warn] Could not open "/var/lib/tor/data/cached-microdesc-consensus" for mmap(): Operation not permitted
Feb 16 00:46:57.000 [warn] Could not open "/var/lib/tor/data/unverified-microdesc-consensus" for mmap(): Operation not permitted
Feb 16 00:46:57.000 [warn] Could not open "/var/lib/tor/data/cached-microdescs" for mmap(): Operation not permitted
Feb 16 00:46:57.000 [warn] Could not open "/var/lib/tor/data/cached-microdescs.new": Operation not permitted
Feb 16 00:46:57.000 [warn] Could not open "/var/lib/tor/data/cached-descriptors" for mmap(): Operation not permitted
Feb 16 00:46:57.000 [warn] Could not open "/var/lib/tor/data/cached-extrainfo" for mmap(): Operation not permitted
Feb 16 00:46:57.000 [notice] Starting with guard context "default"
Feb 16 00:46:58.000 [warn] Couldn't open "/var/lib/tor/data/state.tmp" (/var/lib/tor/data/state) for writing: Operation not permitted
Feb 16 00:46:58.000 [warn] Unable to write state to file "/var/lib/tor/data/state"; will try again later
Feb 16 00:46:58.000 [notice] Bootstrapped 5% (conn): Connecting to a relay
Feb 16 00:46:58.000 [notice] Bootstrapped 10% (conn_done): Connected to a relay
Feb 16 00:46:58.000 [notice] Bootstrapped 14% (handshake): Handshaking with a relay
Feb 16 00:46:58.000 [notice] Bootstrapped 15% (handshake_done): Handshake with a relay done
Feb 16 00:46:58.000 [notice] Bootstrapped 20% (onehop_create): Establishing an encrypted directory connection
Feb 16 00:46:58.000 [notice] Bootstrapped 25% (requesting_status): Asking for networkstatus consensus
Feb 16 00:46:58.000 [notice] Bootstrapped 30% (loading_status): Loading networkstatus consensus
Feb 16 00:46:59.000 [warn] Couldn't open "/var/lib/tor/data/unverified-microdesc-consensus.tmp" (/var/lib/tor/data/unverified-microdesc-consensus) for writing: Operation not permitted
Feb 16 00:46:59.000 [notice] I learned some more directory information, but not enough to build a circuit: We have no usable consensus.
Feb 16 00:46:59.000 [notice] Bootstrapped 40% (loading_keys): Loading authority key certs
Feb 16 00:46:59.000 [warn] Couldn't open "/var/lib/tor/data/cached-certs.tmp" (/var/lib/tor/data/cached-certs) for writing: Operation not permitted
Feb 16 00:46:59.000 [warn] Error writing certificates to disk.
Feb 16 00:46:59.000 [warn] Could not open "/var/lib/tor/data/unverified-microdesc-consensus" for mmap(): Operation not permitted
Feb 16 00:46:59.000 [notice] I learned some more directory information, but not enough to build a circuit: We have no usable consensus.
```
#### Appendix
##### Environment
```
Tor: 0.4.2.6
OS: Gentoo arm64
Hardware: Raspberry Pi 4
Kernel: 4.19.102-v8+ (RPi base)
```
##### Other info
When running 0.4.2.5, I experienced a crash with seccomp (possibly related to legacy/trac#27315)?
```
# tor
Feb 16 00:37:42.963 [notice] Tor 0.4.2.5 running on Linux with Libevent 2.1.8-stable, OpenSSL 1.1.1d, Zlib 1.2.11, Liblzma N/A, and Libzstd N/A.
Feb 16 00:37:42.963 [notice] Tor can't help you if you use it wrong! Learn how to be safe at https://www.torproject.org/download/download#warning
Feb 16 00:37:42.963 [notice] Read configuration file "/etc/tor/torrc".
Feb 16 00:37:42.966 [notice] Opening Socks listener on 127.0.0.1:9050
Feb 16 00:37:42.966 [notice] Opened Socks listener on 127.0.0.1:9050
============================================================ T= 1581813463
(Sandbox) Caught a bad syscall attempt (syscall unlinkat)
tor(+0x1cd714)[0x5571820714]
linux-vdso.so.1(__kernel_rt_sigreturn+0x0)[0x7f8bde0658]
/lib64/libc.so.6(unlink+0x30)[0x7f8b8058d8]
tor(run_tor_main_loop+0x74)[0x55716ae874]
tor(tor_run_main+0x11c)[0x55716aead4]
tor(tor_main+0x50)[0x55716ad458]
tor(main+0x24)[0x55716acf74]
/lib64/libc.so.6(__libc_start_main+0xe4)[0x7f8b758cac]
tor(+0x59fd0)[0x55716acfd0]
```
**Trac**:
**Username**: subjectfrostingTor: 0.3.5.x-finalGeorge KadianakisGeorge Kadianakis