Tor issueshttps://gitlab.torproject.org/tpo/core/tor/-/issues2020-06-27T13:50:32Zhttps://gitlab.torproject.org/tpo/core/tor/-/issues/29962Turn off Travis Rust caching, and see if it speeds up the builds2020-06-27T13:50:32ZteorTurn off Travis Rust caching, and see if it speeds up the buildsOur Rust builds seem to be really slow.
Maybe we should turn off caching, clear the caches, and see if that helps.Our Rust builds seem to be really slow.
Maybe we should turn off caching, clear the caches, and see if that helps.Tor: 0.3.4.x-finalteorteorhttps://gitlab.torproject.org/tpo/core/tor/-/issues/29806Ignore bandwidth file lines with "vote=0"2020-06-27T13:50:38ZjugaIgnore bandwidth file lines with "vote=0"As commented in https://trac.torproject.org/projects/tor/ticket/28563#comment:14As commented in https://trac.torproject.org/projects/tor/ticket/28563#comment:14Tor: 0.3.4.x-finalteorteorhttps://gitlab.torproject.org/tpo/core/tor/-/issues/29665hs: circuit_expire_old_circuits_serverside() should check for RP circuits2021-06-23T17:26:03ZDavid Gouletdgoulet@torproject.orghs: circuit_expire_old_circuits_serverside() should check for RP circuitsThanks to a single onion service operator on IRC in the #tor channel (`slingamn`), armadev and I were able to identify this issue.
Any clients connecting to a single onion service and then being idle for 60 seconds would get disconnecte...Thanks to a single onion service operator on IRC in the #tor channel (`slingamn`), armadev and I were able to identify this issue.
Any clients connecting to a single onion service and then being idle for 60 seconds would get disconnected as in the rendezvous circuit closed.
It turns out that the rendezvous point closes the service circuit through this function `circuit_expire_old_circuits_serversid()` if is idle for more than 60 seconds (only for single onion service). The faulty condition is:
```
if (or_circ->p_chan && channel_is_client(or_circ->p_chan) &&
!circ->n_chan &&
!or_circ->n_streams && !or_circ->resolving_streams &&
channel_when_last_xmit(or_circ->p_chan) <= cutoff) {
```
The RP is the end of the service circuit (`or_circ`), all data is spliced to the client circuit which makes it that `n_streams` and `n_chan` are NULL and thus validating the condition.
Also possible to hit this if `channel_is_client()` is a false positive for the exit point.
The fix here is to check if the circuit being looked at is a rendezvous point and ignore it if so. The `or_circ->rend_splice` should be non-NULL if so.
This needs to be backported and affects v2 and v3 hidden service.Tor: 0.3.4.x-finalhttps://gitlab.torproject.org/tpo/core/tor/-/issues/29017PaddingStatistics should be disabled when ExtraInfoStatistics is 02020-06-27T13:51:14ZteorPaddingStatistics should be disabled when ExtraInfoStatistics is 0The man page entry for PaddingStatistics says that it is disabled when ExtraInfoStatistics is 0. But that isn't the case: the statistics are published regardless of ExtraInfoStatistics.
As far as I can tell, PaddingStatistics are collec...The man page entry for PaddingStatistics says that it is disabled when ExtraInfoStatistics is 0. But that isn't the case: the statistics are published regardless of ExtraInfoStatistics.
As far as I can tell, PaddingStatistics are collected on bridges, but the man page says "Relays only."Tor: 0.3.4.x-finalteorteorhttps://gitlab.torproject.org/tpo/core/tor/-/issues/28912Stream hangs while downloading consensus via RELAY_BEGIN_DIR2020-06-27T13:51:21ZTracStream hangs while downloading consensus via RELAY_BEGIN_DIRAfter performing the following sequence of steps to download a consensus through a stream, Tor hangs after sending 58 (17 with deflate) cells:
1. Open an TLS connection to a local OR.
2. Negotiate a v5 link on the connection.
3. Create ...After performing the following sequence of steps to download a consensus through a stream, Tor hangs after sending 58 (17 with deflate) cells:
1. Open an TLS connection to a local OR.
2. Negotiate a v5 link on the connection.
3. Create a circuit via CREATE_FAST.
4. Create a stream via RELAY_BEGIN_DIR.
5. Send a request to download a consensus.
I managed to reproduce the issue with the code attached. Here are an excerpt of the file:
```
'''Using identity, we get 58 RELAY_DATA cells before hanging, 17 with deflate.
Affected:
Tor version 0.3.4.0-alpha-dev (git-3463b4e0652bacca).
Not affected:
Tor version 0.3.3.5-rc-dev (git-3ee4c9b1fae9d535).
'''
compression = b'identity' # or b'deflate'
'''Issue reproduced with the code below, originally bisected on [1].
From tag:tor-0.3.4.1-alpha Affected?
deb8970a29ef7427c3d42182d3bacc31ab602c03 yes
2d7b5c6fe5dc46b7e7cd040e6723e25d12015985 yes
3fa66f97996c179388fa91176b9a82fb9b5b31d8 no
306563ac68250872791350bda1ba7a7acff5eb63 no
3ee4c9b1fae9d53556b3e3be852f12e9abe51e14 no
c32108ee0fea851ced14f71d842390992f762393 yes
22845df2a7503ed73ed325c3a98916f289918caa no
c7d3de216c60c090fddb4926a739da038bb5d5fe yes
9ef4c05df8323850b5894782f435da15810d6189 no
5e0fbd7006993a4e402f2eee49f6f86074923197 no
c5899d5cf3a761f4049c1d6f05232731edcfeb57 no
3463b4e0652bacca51fecd2c256e3e9d61ce920e yes
[1] Unpublished (yet) python client, no link here, sorry :(
Usage:
virtualenv venv
source venv/bin/activate
pip install -r stem cryptography
tor PublishServerDescriptor 0 AssumeReachable 1 ExitRelay 0 ProtocolWarnings 1 SafeLogging 0 LogTimeGranularity 1 PidFile '$(mktemp)' SOCKSPort 0 ContactInfo none@example.com DataDirectory '$(mktemp -d)' ORPort 9050 DirPort 9051 Log 'err stderr' &
python reproduce.py
'''
```
I provided the redacted logs for two different versions, one affected and one not.
**Trac**:
**Username**: plcp`Tor: 0.3.4.x-finalDavid Gouletdgoulet@torproject.orgDavid Gouletdgoulet@torproject.orghttps://gitlab.torproject.org/tpo/core/tor/-/issues/28717Tor stuck in 25% Loading networkstatus consensus2020-06-27T13:51:28ZTracTor stuck in 25% Loading networkstatus consensusI installed the Tor Bridge. When launched, it gets stuck:
```
Dec 04 10:42:33.943 [notice] Tor 0.3.4.9 running on Linux with Libevent 2.1.8-stable, OpenSSL LibreSSL 2.8.2, Zlib 1.2.8, Liblzma N/A, and Libzstd N/A.
Dec 04 10:42:33.944 [n...I installed the Tor Bridge. When launched, it gets stuck:
```
Dec 04 10:42:33.943 [notice] Tor 0.3.4.9 running on Linux with Libevent 2.1.8-stable, OpenSSL LibreSSL 2.8.2, Zlib 1.2.8, Liblzma N/A, and Libzstd N/A.
Dec 04 10:42:33.944 [notice] Tor can't help you if you use it wrong! Learn how to be safe at https://www.torproject.org/download/download#warning
Dec 04 10:42:33.944 [notice] Read configuration file "/etc/tor/torrc".
Dec 04 10:42:33.947 [notice] Scheduler type KIST has been enabled.
Dec 04 10:42:33.947 [notice] Opening Socks listener on 127.0.0.1:9050
Dec 04 10:42:33.000 [notice] Parsing GEOIP IPv4 file /usr/local/share/tor/geoip.
Dec 04 10:42:34.000 [notice] Parsing GEOIP IPv6 file /usr/local/share/tor/geoip6.
Dec 04 10:42:34.000 [notice] We were built to run on a 64-bit CPU, with OpenSSL 1.0.1 or later, but with a version of OpenSSL that apparently lacks accelerated support for the NIST P-224 and P-256 groups. Building openssl with such support (using the enable-ec_nistp_64_gcc_128 option when configuring it) would make ECDH much faster.
Dec 04 10:42:34.000 [notice] Bootstrapped 0%: Starting
Dec 04 10:42:34.000 [notice] Starting with guard context "bridges"
Dec 04 10:42:34.000 [notice] new bridge descriptor 'huy' (cached): $3E0CFCEE7183970DCC70ABC2D10518BC288BF0DE~huy at 79.103.124.21
Dec 04 10:42:34.000 [notice] Delaying directory fetches: Pluggable transport proxies still configuring
Dec 04 10:42:35.000 [notice] Bootstrapped 5%: Connecting to directory server
Dec 04 10:42:35.000 [notice] Bootstrapped 10%: Finishing handshake with directory server
Dec 04 10:42:35.000 [notice] Bootstrapped 15%: Establishing an encrypted directory connection
Dec 04 10:42:35.000 [notice] Bootstrapped 20%: Asking for networkstatus consensus
Dec 04 10:42:35.000 [notice] Bootstrapped 25%: Loading networkstatus consensus
Dec 04 10:47:39.000 [notice] Delaying directory fetches: No running bridges
```
My ISP does not block Tor. This problem does not depend on the country, because I tested the Tor client with my bridge in Russia, Germany and the Netherlands. The same problem occurs without using obfs4proxy. I think that in this case it has nothing to do with the time zone.
**Trac**:
**Username**: loskiqTor: 0.3.4.x-finalhttps://gitlab.torproject.org/tpo/core/tor/-/issues/28574Appveyor: OpenSSL unit test fails with header and library version mismatch2020-06-27T13:51:35ZteorAppveyor: OpenSSL unit test fails with header and library version mismatchI'm guessing that 1.1.1a and 1.1.1 are compatible, though?
```
crypto/openssl_version: [forking]
FAIL ../src/test/test_crypto.c:238: OpenSSL library version 1.1.1 did not begin with header version 1.1.1a.
[openssl_version FAILED]
``...I'm guessing that 1.1.1a and 1.1.1 are compatible, though?
```
crypto/openssl_version: [forking]
FAIL ../src/test/test_crypto.c:238: OpenSSL library version 1.1.1 did not begin with header version 1.1.1a.
[openssl_version FAILED]
```
https://ci.appveyor.com/project/torproject/tor/build/1.0.1625/job/gibgc64fp4hxsf2h?fullLog=true#L3064Tor: 0.3.4.x-finalhttps://gitlab.torproject.org/tpo/core/tor/-/issues/28459Appveyor: always make the logs into build artifacts2020-06-27T13:51:38ZteorAppveyor: always make the logs into build artifactsThey're only about 50kB, and sometimes we want to have logs for a successful build.They're only about 50kB, and sometimes we want to have logs for a successful build.Tor: 0.3.4.x-finalteorteorhttps://gitlab.torproject.org/tpo/core/tor/-/issues/28348Setting DisableNetwork won't disable NEED_NET events2020-06-27T13:51:43ZNick MathewsonSetting DisableNetwork won't disable NEED_NET eventsIn `rescan_periodic_events()`, we skip the enable/disable code for `NEED_NET` events when `net_is_disabled()`. That is sufficient to prevent them from being enabled, but it doesn't cause them to become disabled.In `rescan_periodic_events()`, we skip the enable/disable code for `NEED_NET` events when `net_is_disabled()`. That is sufficient to prevent them from being enabled, but it doesn't cause them to become disabled.Tor: 0.3.4.x-finalhttps://gitlab.torproject.org/tpo/core/tor/-/issues/28298Tor 0.3.3.1-alpha resumes allowing RunAsDaemon=1 with relative DataDirectory2020-06-27T13:51:45ZRoger DingledineTor 0.3.3.1-alpha resumes allowing RunAsDaemon=1 with relative DataDirectoryIn 0.3.2.1-alpha we fixed legacy/trac#22731 (in commit 6fea44c6): we started refusing to start if RunAsDaemon is set and also any of a variety of config options are set to a relative value.
And then in 0.3.3.1-alpha we did commit 192be0...In 0.3.2.1-alpha we fixed legacy/trac#22731 (in commit 6fea44c6): we started refusing to start if RunAsDaemon is set and also any of a variety of config options are set to a relative value.
And then in 0.3.3.1-alpha we did commit 192be006, which split the original options->DataDirectory into a new DataDirectory_option variable.
But warn_about_relative_paths() continues to look at
```
n += warn_if_option_path_is_relative("DataDirectory",options->DataDirectory);
```
and that function is called near the top of options_validate() -- before we call validate_data_directories() which is what populates options->DataDirectory.Tor: 0.3.4.x-finalhttps://gitlab.torproject.org/tpo/core/tor/-/issues/28096Windows 8.1 and 10 relays claim to be Windows 82020-06-27T13:51:52ZteorWindows 8.1 and 10 relays claim to be Windows 8In Windows 8.1, Microsoft changed the behaviour of the GetVersionEx function so that it returns 6.2 (Windows 8) for applications without a compatibility manifest. (For applications with a compatibility manifest, it returns the version in...In Windows 8.1, Microsoft changed the behaviour of the GetVersionEx function so that it returns 6.2 (Windows 8) for applications without a compatibility manifest. (For applications with a compatibility manifest, it returns the version in that manifest.)
https://docs.microsoft.com/en-au/windows/desktop/api/sysinfoapi/nf-sysinfoapi-getversionexa
We should change the version returned by Tor's uname function to "Windows 8 or later".Tor: 0.3.4.x-finalteorteorhttps://gitlab.torproject.org/tpo/core/tor/-/issues/27810hs_service/helper_functions test seems unreliable on slow systems2020-06-27T13:52:05ZNick Mathewsonhs_service/helper_functions test seems unreliable on slow systemsHi! I've seen this test failure a few times on Travis:
```
hs_service/helper_functions: [forking]
FAIL src/test/test_hs_service.c:837: assert(ip->time_to_expire OP_GE now + INTRO_POINT_LIFETIME_MIN_SECONDS): 1537602275 vs 1537602297...Hi! I've seen this test failure a few times on Travis:
```
hs_service/helper_functions: [forking]
FAIL src/test/test_hs_service.c:837: assert(ip->time_to_expire OP_GE now + INTRO_POINT_LIFETIME_MIN_SECONDS): 1537602275 vs 1537602297
[helper_functions FAILED]
```
It seems to happen intermittently, so I think it might be one of those things where a slow-running machine fails the test because of the unexpected passage of time.
Is it possible to mock time here?Tor: 0.3.4.x-finalDavid Gouletdgoulet@torproject.orgDavid Gouletdgoulet@torproject.orghttps://gitlab.torproject.org/tpo/core/tor/-/issues/27797node: Make node_supports_v3_rendezvous_point() also check for the onion_pk2020-06-27T13:52:06ZDavid Gouletdgoulet@torproject.orgnode: Make node_supports_v3_rendezvous_point() also check for the onion_pkTurns out that we think this is related to legacy/trac#27774.
A client selects a v3 RP by only looking at the protover but it is possible that at that time we simply don't have the descriptor yet thus missing the `onion_pk` which led to...Turns out that we think this is related to legacy/trac#27774.
A client selects a v3 RP by only looking at the protover but it is possible that at that time we simply don't have the descriptor yet thus missing the `onion_pk` which led to a failure when sending the INTRODUCE1 cell.
Like `node_supports_ed25519_link_authentication()` does, we should simply check for the `onion_pk` as an extra step to the protover.
Flagging this for backport.Tor: 0.3.4.x-finalhttps://gitlab.torproject.org/tpo/core/tor/-/issues/27774hs-v3: Assertion onion_pk failed in introduce1_set_encrypted_onion_key2020-06-27T13:52:07ZDavid Gouletdgoulet@torproject.orghs-v3: Assertion onion_pk failed in introduce1_set_encrypted_onion_keyFrom #tor on IRC, someone using Tor Browser hit this. I would bet anything that legacy/trac#27471 is also related in some way.
```
9/18/18, 17:42:12.963 [ERR] tor_assertion_failed_(): Bug: src/or/hs_cell.c:256: introduce1_set_encrypted_...From #tor on IRC, someone using Tor Browser hit this. I would bet anything that legacy/trac#27471 is also related in some way.
```
9/18/18, 17:42:12.963 [ERR] tor_assertion_failed_(): Bug: src/or/hs_cell.c:256: introduce1_set_encrypted_onion_key: Assertion onion_pk failed; aborting. (on Tor 0.3.3.9 45028085ea188baf)
9/18/18, 17:42:12.964 [ERR] Bug: Assertion onion_pk failed in introduce1_set_encrypted_onion_key at src/or/hs_cell.c:256. Stack trace: (on Tor 0.3.3.9 45028085ea188baf)
9/18/18, 17:42:12.965 [ERR] Bug: /home/winston/tor-browser_en-US/Browser/TorBrowser/Tor/tor(log_backtrace+0x44) [0x5601001fa314] (on Tor 0.3.3.9 45028085ea188baf)
9/18/18, 17:42:12.965 [ERR] Bug: /home/winston/tor-browser_en-US/Browser/TorBrowser/Tor/tor(tor_assertion_failed_+0x8d) [0x56010021587d] (on Tor 0.3.3.9 45028085ea188baf)
9/18/18, 17:42:12.965 [ERR] Bug: /home/winston/tor-browser_en-US/Browser/TorBrowser/Tor/tor(hs_cell_build_introduce1+0x457) [0x5601001f5ee7] (on Tor 0.3.3.9 45028085ea188baf)
9/18/18, 17:42:12.965 [ERR] Bug: /home/winston/tor-browser_en-US/Browser/TorBrowser/Tor/tor(hs_circ_send_introduce1+0x296) [0x5601001d4596] (on Tor 0.3.3.9 45028085ea188baf)
9/18/18, 17:42:12.965 [ERR] Bug: /home/winston/tor-browser_en-US/Browser/TorBrowser/Tor/tor(hs_client_send_introduce1+0x159) [0x5601001d7299] (on Tor 0.3.3.9 45028085ea188baf)
9/18/18, 17:42:12.965 [ERR] Bug: /home/winston/tor-browser_en-US/Browser/TorBrowser/Tor/tor(connection_ap_handshake_attach_circuit+0x860) [0x56010015f210] (on Tor 0.3.3.9 45028085ea188baf)
9/18/18, 17:42:12.966 [ERR] Bug: /home/winston/tor-browser_en-US/Browser/TorBrowser/Tor/tor(connection_ap_attach_pending+0x1a8) [0x560100180308] (on Tor 0.3.3.9 45028085ea188baf)
9/18/18, 17:42:12.966 [ERR] Bug: /home/winston/tor-browser_en-US/Browser/TorBrowser/Tor/tor(circuit_send_next_onion_skin+0x372) [0x560100149762] (on Tor 0.3.3.9 45028085ea188baf)
9/18/18, 17:42:12.967 [ERR] Bug: /home/winston/tor-browser_en-US/Browser/TorBrowser/Tor/tor(+0x7be34) [0x5601000ece34] (on Tor 0.3.3.9 45028085ea188baf)
9/18/18, 17:42:12.967 [ERR] Bug: /home/winston/tor-browser_en-US/Browser/TorBrowser/Tor/tor(circuit_receive_relay_cell+0x329) [0x5601000eee59] (on Tor 0.3.3.9 45028085ea188baf)
9/18/18, 17:42:12.967 [ERR] Bug: /home/winston/tor-browser_en-US/Browser/TorBrowser/Tor/tor(command_process_cell+0x180) [0x56010015ff40] (on Tor 0.3.3.9 45028085ea188baf)
9/18/18, 17:42:12.967 [ERR] Bug: /home/winston/tor-browser_en-US/Browser/TorBrowser/Tor/tor(channel_tls_handle_cell+0x32b) [0x5601001401cb] (on Tor 0.3.3.9 45028085ea188baf)
9/18/18, 17:42:12.968 [ERR] Bug: /home/winston/tor-browser_en-US/Browser/TorBrowser/Tor/tor(+0x115507) [0x560100186507] (on Tor 0.3.3.9 45028085ea188baf)
9/18/18, 17:42:12.968 [ERR] Bug: /home/winston/tor-browser_en-US/Browser/TorBrowser/Tor/tor(+0x10c01e) [0x56010017d01e] (on Tor 0.3.3.9 45028085ea188baf)
9/18/18, 17:42:12.968 [ERR] Bug: /home/winston/tor-browser_en-US/Browser/TorBrowser/Tor/tor(+0x52d31) [0x5601000c3d31] (on Tor 0.3.3.9 45028085ea188baf)
9/18/18, 17:42:12.968 [ERR] Bug: ./TorBrowser/Tor/libevent-2.1.so.6(+0x2214a) [0x7f70d3fa714a] (on Tor 0.3.3.9 45028085ea188baf)
9/18/18, 17:42:12.968 [ERR] Bug: ./TorBrowser/Tor/libevent-2.1.so.6(event_base_loop+0x55f) [0x7f70d3fa7c6f] (on Tor 0.3.3.9 45028085ea188baf)
9/18/18, 17:42:12.968 [ERR] Bug: /home/winston/tor-browser_en-US/Browser/TorBrowser/Tor/tor(do_main_loop+0x26c) [0x5601000c4d4c] (on Tor 0.3.3.9 45028085ea188baf)
9/18/18, 17:42:12.968 [ERR] Bug: /home/winston/tor-browser_en-US/Browser/TorBrowser/Tor/tor(tor_run_main+0x275) [0x5601000c6365] (on Tor 0.3.3.9 45028085ea188baf)
9/18/18, 17:42:12.968 [ERR] Bug: /home/winston/tor-browser_en-US/Browser/TorBrowser/Tor/tor(tor_main+0x3a) [0x5601000bf91a] (on Tor 0.3.3.9 45028085ea188baf)
9/18/18, 17:42:12.968 [ERR] Bug: /home/winston/tor-browser_en-US/Browser/TorBrowser/Tor/tor(main+0x19) [0x5601000bf669] (on Tor 0.3.3.9 45028085ea188baf)
9/18/18, 17:42:12.968 [ERR] Bug: /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf1) [0x7f70d31532e1] (on Tor 0.3.3.9 45028085ea188baf)
9/18/18, 17:42:12.968 [ERR] Bug: /home/winston/tor-browser_en-US/Browser/TorBrowser/Tor/tor(+0x4e6b9) [0x5601000bf6b9] (on Tor 0.3.3.9 45028085ea188baf)
```Tor: 0.3.4.x-finalhttps://gitlab.torproject.org/tpo/core/tor/-/issues/27750conn_close_if_marked: Non-fatal assertion !(connection_is_writing(conn))2020-06-27T13:52:08ZDavid Gouletdgoulet@torproject.orgconn_close_if_marked: Non-fatal assertion !(connection_is_writing(conn))From tor-talk:
https://lists.torproject.org/pipermail/tor-talk/2018-September/044448.html
```
Sep 15 16:06:26.000 [warn] tor_bug_occurred_(): Bug: src/or/main.c:1044: conn_close_if_marked: Non-fatal assertion !(connection_is_writing(co...From tor-talk:
https://lists.torproject.org/pipermail/tor-talk/2018-September/044448.html
```
Sep 15 16:06:26.000 [warn] tor_bug_occurred_(): Bug: src/or/main.c:1044: conn_close_if_marked: Non-fatal assertion !(connection_is_writing(conn)) failed. (on Tor 0.3.4.8 da95b91355248ad8)
Sep 15 16:06:26.000 [warn] Bug: Non-fatal assertion !(connection_is_writing(conn)) failed in conn_close_if_marked at src/or/main.c:1044. Stack trace: (on Tor 0.3.4.8 da95b91355248ad8)
Sep 15 16:06:26.000 [warn] Bug: /usr/bin/tor(log_backtrace+0x47) [0x55727ae152e7] (on Tor 0.3.4.8 da95b91355248ad8)
Sep 15 16:06:26.000 [warn] Bug: /usr/bin/tor(tor_bug_occurred_+0xbd) [0x55727ae307ad] (on Tor 0.3.4.8 da95b91355248ad8)
Sep 15 16:06:26.000 [warn] Bug: /usr/bin/tor(+0x51b18) [0x55727acdbb18] (on Tor 0.3.4.8 da95b91355248ad8)
Sep 15 16:06:26.000 [warn] Bug: /lib64/libevent-2.1.so.6(+0x235b1) [0x7fb01de555b1] (on Tor 0.3.4.8 da95b91355248ad8)
Sep 15 16:06:26.000 [warn] Bug: /lib64/libevent-2.1.so.6(event_base_loop+0x537) [0x7fb01de55d47] (on Tor 0.3.4.8 da95b91355248ad8)
Sep 15 16:06:26.000 [warn] Bug: /usr/bin/tor(do_main_loop+0x209) [0x55727acde149] (on Tor 0.3.4.8 da95b91355248ad8)
Sep 15 16:06:26.000 [warn] Bug: /usr/bin/tor(tor_run_main+0x1015) [0x55727ace0835] (on Tor 0.3.4.8 da95b91355248ad8)
Sep 15 16:06:26.000 [warn] Bug: /usr/bin/tor(tor_main+0x3e) [0x55727acd868e] (on Tor 0.3.4.8 da95b91355248ad8)
Sep 15 16:06:26.000 [warn] Bug: /usr/bin/tor(main+0x1d) [0x55727acd841d] (on Tor 0.3.4.8 da95b91355248ad8)
Sep 15 16:06:26.000 [warn] Bug: /lib64/libc.so.6(__libc_start_main+0xeb) [0x7fb01c3d611b] (on Tor 0.3.4.8 da95b91355248ad8)
Sep 15 16:06:26.000 [warn] Bug: /usr/bin/tor(_start+0x2a) [0x55727acd847a] (on Tor 0.3.4.8 da95b91355248ad8)
```Tor: 0.3.4.x-finalDavid Gouletdgoulet@torproject.orgDavid Gouletdgoulet@torproject.orghttps://gitlab.torproject.org/tpo/core/tor/-/issues/27686OOM code should count space used in a circuit's half-closed list2020-06-27T13:52:11ZNick MathewsonOOM code should count space used in a circuit's half-closed listThe new code in legacy/trac#25573 should be integrated with the circuit OOM code.The new code in legacy/trac#25573 should be integrated with the circuit OOM code.Tor: 0.3.4.x-finalNick MathewsonNick Mathewsonhttps://gitlab.torproject.org/tpo/core/tor/-/issues/274880.3.4.6-rc ChangeLog omits bug268762020-06-27T13:52:17ZTaylor Yu0.3.4.6-rc ChangeLog omits bug26876At arma's suggestion, we should check the 0.3.4 ChangeLog for omissions.
It looks like bf33ddd291 deleted changes/bug26876 but 59e813f5f9 didn't actually incorporate its contents into the ChangeLog. We should fix this. We should proba...At arma's suggestion, we should check the 0.3.4 ChangeLog for omissions.
It looks like bf33ddd291 deleted changes/bug26876 but 59e813f5f9 didn't actually incorporate its contents into the ChangeLog. We should fix this. We should probably check for other omissions of this sort, too.Tor: 0.3.4.x-finalhttps://gitlab.torproject.org/tpo/core/tor/-/issues/27465Windows: cast between incompatible function types in address.c2020-06-27T13:52:18ZteorWindows: cast between incompatible function types in address.c```
bash.exe : ../src/common/address.c: In function 'get_interface_addresses_win32':
At line:2 char:5
+ & $commandPath $args 2>&1
+ ~~~~~~~~~~~~~~~~~~~~~~~~~
+ CategoryInfo : NotSpecified: (../src/common/a...dresses_...```
bash.exe : ../src/common/address.c: In function 'get_interface_addresses_win32':
At line:2 char:5
+ & $commandPath $args 2>&1
+ ~~~~~~~~~~~~~~~~~~~~~~~~~
+ CategoryInfo : NotSpecified: (../src/common/a...dresses_win32'::String) [], RemoteException
+ FullyQualifiedErrorId : NativeCommandError
../src/common/address.c:1499:14: error: cast between incompatible function types from 'FARPROC' {aka 'long long int (*)()'} to 'ULONG (*)(ULONG, ULONG, void *, IP_ADAPTER_ADDRESSES_XP *, ULONG *)' {aka 'long unsigned int
(*)(long unsigned int, long unsigned int, void *, struct _IP_ADAPTER_ADDRESSES_XP *, long unsigned int *)'} [-Werror=cast-function-type]
if (!(fn = (GetAdaptersAddresses_fn_t)
^
```
https://ci.appveyor.com/project/teor2345/tor/build/1.0.152/job/g7dxnnck0r3p66n9#L1093Tor: 0.3.4.x-finalteorteorhttps://gitlab.torproject.org/tpo/core/tor/-/issues/27463hs: rend_client_send_introduction v0 string truncation warning2020-06-27T13:52:18Zteorhs: rend_client_send_introduction v0 string truncation warning```
x86_64-w64-mingw32-gcc -DHAVE_CONFIG_H -I. -I.. -I../src/ext -Isrc/ext -I../src/ext/trunnel -I../src/trunnel -I../src/common -Isrc/common -I../src/ext/trunnel -I../src/trunnel -I../src/or -Isrc/or -DSHARE_DATADIR="\"/mingw64/share\"...```
x86_64-w64-mingw32-gcc -DHAVE_CONFIG_H -I. -I.. -I../src/ext -Isrc/ext -I../src/ext/trunnel -I../src/trunnel -I../src/common -Isrc/common -I../src/ext/trunnel -I../src/trunnel -I../src/or -Isrc/or -DSHARE_DATADIR="\"/mingw64/share\"" -DLOCALSTATEDIR="\"/mingw64/var\"" -DBINDIR="\"/mingw64/bin\"" -I../src -I../src/common -I/c/OpenSSL-Win64/include -IC:/msys64/mingw64/include -g -O2 -fasynchronous-unwind-tables -Wall -fno-strict-aliasing -Waddress -Warray-bounds -Wdate-time -Wdouble-promotion -Wduplicate-decl-specifier -Wduplicated-cond -Wextra -Wfloat-conversion -Wignored-attributes -Wimplicit-fallthrough -Winit-self -Wlogical-op -Wmissing-field-initializers -Wmissing-format-attribute -Wmissing-noreturn -Wnormalized=nfkc -Wnull-dereference -Woverlength-strings -Woverride-init -Wshadow -Wshift-count-negative -Wshift-count-overflow -Wshift-negative-value -Wshift-overflow=2 -Wsizeof-array-argument -Wstrict-overflow=1 -Wsuggest-attribute=format -Wsuggest-attribute=noreturn -Wswitch-bool -Wsync-nand -Wtrampolines -Wunused-but-set-parameter -Wunused-but-set-variable -Wunused-const-variable=2 -Wunused-local-typedefs -Wvariadic-macros -W -Wfloat-equal -Wundef -Wpointer-arith -Wstrict-prototypes -Wmissing-prototypes -Wwrite-strings -Wredundant-decls -Wchar-subscripts -Wcomment -Wformat=2 -Wwrite-strings -Wnested-externs -Wbad-function-cast -Wswitch-enum -Waggregate-return -Wpacked -Wunused -Wunused-parameter -Wold-style-definition -Wmissing-declarations -Werror -MT src/or/rendclient.o -MD -MP -MF $depbase.Tpo -c -o src/or/rendclient.o ../src/or/rendclient.c ...
bash.exe : ../src/or/rendclient.c: In function 'rend_client_send_introduction':
At line:2 char:5
+ & $commandPath $args 2>&1
+ ~~~~~~~~~~~~~~~~~~~~~~~~~
+ CategoryInfo : NotSpecified: (../src/or/rendc..._introduction'::String) [], RemoteException
+ FullyQualifiedErrorId : NativeCommandError
../src/or/rendclient.c:243:5: error: 'strncpy' output may be truncated copying 20 bytes from a string of length 41 [-Werror=stringop-truncation]
strncpy(tmp, rendcirc->build_state->chosen_exit->nickname,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
(MAX_NICKNAME_LEN+1)); /* nul pads */
~~~~~~~~~~~~~~~~~~~~~
```
https://ci.appveyor.com/project/teor2345/tor/build/1.0.149/job/yttwj9fom8k0jh5c#L1253Tor: 0.3.4.x-finalteorteorhttps://gitlab.torproject.org/tpo/core/tor/-/issues/27461Windows: cast between incompatible function types in main2020-06-27T13:52:18ZteorWindows: cast between incompatible function types in main```
x86_64-w64-mingw32-gcc -DHAVE_CONFIG_H -I. -I.. -I../src/ext -Isrc/ext -I../src/ext/trunnel -I../src/trunnel -I../src/common -Isrc/common -I../src/ext/trunnel -I../src/trunnel -I../src/or -Isrc/or -DSHARE_DATADIR="\"/mingw64/share\"...```
x86_64-w64-mingw32-gcc -DHAVE_CONFIG_H -I. -I.. -I../src/ext -Isrc/ext -I../src/ext/trunnel -I../src/trunnel -I../src/common -Isrc/common -I../src/ext/trunnel -I../src/trunnel -I../src/or -Isrc/or -DSHARE_DATADIR="\"/mingw64/share\"" -DLOCALSTATEDIR="\"/mingw64/var\"" -DBINDIR="\"/mingw64/bin\"" -I../src -I../src/common -I/c/OpenSSL-Win64/include -IC:/msys64/mingw64/include -g -O2 -fasynchronous-unwind-tables -Wall -fno-strict-aliasing -Waddress -Warray-bounds -Wdate-time -Wdouble-promotion -Wduplicate-decl-specifier -Wduplicated-cond -Wextra -Wfloat-conversion -Wignored-attributes -Wimplicit-fallthrough -Winit-self -Wlogical-op -Wmissing-field-initializers -Wmissing-format-attribute -Wmissing-noreturn -Wnormalized=nfkc -Wnull-dereference -Woverlength-strings -Woverride-init -Wshadow -Wshift-count-negative -Wshift-count-overflow -Wshift-negative-value -Wshift-overflow=2 -Wsizeof-array-argument -Wstrict-overflow=1 -Wsuggest-attribute=format -Wsuggest-attribute=noreturn -Wswitch-bool -Wsync-nand -Wtrampolines -Wunused-but-set-parameter -Wunused-but-set-variable -Wunused-const-variable=2 -Wunused-local-typedefs -Wvariadic-macros -W -Wfloat-equal -Wundef -Wpointer-arith -Wstrict-prototypes -Wmissing-prototypes -Wwrite-strings -Wredundant-decls -Wchar-subscripts -Wcomment -Wformat=2 -Wwrite-strings -Wnested-externs -Wbad-function-cast -Wswitch-enum -Waggregate-return -Wpacked -Wunused -Wunused-parameter -Wold-style-definition -Wmissing-declarations -Werror -MT src/or/main.o -MD -MP -MF $depbase.Tpo -c -o src/or/main.o ../src/or/main.c &&\
...
bash.exe : ../src/or/main.c: In function 'tor_run_main':
At line:2 char:5
+ & $commandPath $args 2>&1
+ ~~~~~~~~~~~~~~~~~~~~~~~~~
+ CategoryInfo : NotSpecified: (../src/or/main....'tor_run_main'::String) [], RemoteException
+ FullyQualifiedErrorId : NativeCommandError
../src/or/main.c:4215:28: error: cast between incompatible function types from 'FARPROC' {aka 'long long int (*)()'} to 'BOOL (*)(DWORD)' {aka 'int (*)(long unsigned int)'} [-Werror=cast-function-type]
PSETDEP setdeppolicy = (PSETDEP)GetProcAddress(hMod,
^
```
https://ci.appveyor.com/project/teor2345/tor/build/1.0.138/job/691be5b3uror0sok#L1146Tor: 0.3.4.x-finalteorteor