Tor issueshttps://gitlab.torproject.org/tpo/core/tor/-/issues2020-06-27T13:52:26Zhttps://gitlab.torproject.org/tpo/core/tor/-/issues/27318incorrect comments in torlog.c2020-06-27T13:52:26ZTracincorrect comments in torlog.c[79f73ab330c0e643ba1ec2eb0633f0f80525a083](https://gitweb.torproject.org/tor.git/commit/?id=79f73ab330c0e643ba1ec2eb0633f0f80525a083) find/replace'd mentions of tor_assert with raw_assert in some comments that made them stop making sense...[79f73ab330c0e643ba1ec2eb0633f0f80525a083](https://gitweb.torproject.org/tor.git/commit/?id=79f73ab330c0e643ba1ec2eb0633f0f80525a083) find/replace'd mentions of tor_assert with raw_assert in some comments that made them stop making sense.
**Trac**:
**Username**: cyberpunksTor: 0.3.5.x-finalhttps://gitlab.torproject.org/tpo/core/tor/-/issues/27335Tor bug when hs directory is missing2020-06-27T13:52:24ZtraumschuleTor bug when hs directory is missingTrying to create an onion service with missing directory `/var/lib/tor/hidden_services` shows:
```
Error creating directory /var/lib/tor/hidden_services/hs1: No such file or directory
tor_bug_occurred_(): Bug: ../src/or/hs_service.c:1009...Trying to create an onion service with missing directory `/var/lib/tor/hidden_services` shows:
```
Error creating directory /var/lib/tor/hidden_services/hs1: No such file or directory
tor_bug_occurred_(): Bug: ../src/or/hs_service.c:1009: load_service_keys: Non-fatal assertion !(hs_check_service_private_dir(get_options()->User, config->directory_path, config->dir_group_readable, 1) < 0) failed. (on Tor 0.3.4.6-rc )
Bug: Non-fatal assertion !(hs_check_service_private_dir(get_options()->User, config->directory_path, config->dir_group_readable, 1) < 0) failed in load_service_keys at ../src/or/hs_service.c:1009. Stack trace: (on Tor 0.3.4.6-rc )
Bug: /usr/bin/tor(log_backtrace+0x42) [0x55b0ef49ce92] (on Tor 0.3.4.6-rc )
Bug: /usr/bin/tor(tor_bug_occurred_+0xb9) [0x55b0ef4b7d59] (on Tor 0.3.4.6-rc )
Bug: /usr/bin/tor(hs_service_load_all_keys+0x4f5) [0x55b0ef48aa75] (on Tor 0.3.4.6-rc )
Bug: /usr/bin/tor(set_options+0xf11) [0x55b0ef41aa71] (on Tor 0.3.4.6-rc )
Bug: /usr/bin/tor(options_init_from_string+0x37e) [0x55b0ef41c77e] (on Tor 0.3.4.6-rc )
Bug: /usr/bin/tor(options_init_from_torrc+0x433) [0x55b0ef41cdd3] (on Tor 0.3.4.6-rc )
Bug: /usr/bin/tor(tor_init+0x2f0) [0x55b0ef36c370] (on Tor 0.3.4.6-rc )
Bug: /usr/bin/tor(tor_run_main+0x65) [0x55b0ef36ce25] (on Tor 0.3.4.6-rc )
Bug: /usr/bin/tor(tor_main+0x3a) [0x55b0ef365e4a] (on Tor 0.3.4.6-rc )
Bug: /usr/bin/tor(main+0x19) [0x55b0ef365bb9] (on Tor 0.3.4.6-rc )
Bug: /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf0) [0x7f57e9f12830] (on Tor 0.3.4.6-rc )
Bug: /usr/bin/tor(_start+0x29) [0x55b0ef365c09] (on Tor 0.3.4.6-rc )
```
Instead the directory should be automatically created.
apt repository:
```
deb https://deb.torproject.org/torproject.org xenial main
deb-src https://deb.torproject.org/torproject.org xenial main
deb https://deb.torproject.org/torproject.org tor-experimental-0.3.4.x-xenial main
deb-src https://deb.torproject.org/torproject.org tor-experimental-0.3.4.x-xenial main
```Tor: 0.3.5.x-finalhttps://gitlab.torproject.org/tpo/core/tor/-/issues/27366Ask Travis CI to reduce the number of erroring builds2020-06-27T13:52:23ZteorAsk Travis CI to reduce the number of erroring buildsA few of our builds errored out over the last few days. We've been seeing intermittent errors like this for a few weeks now.
I emailed support@travis-ci.com :
```
Hi,
I'm a Tor Project developer who monitors our Travis CI.
We're seein...A few of our builds errored out over the last few days. We've been seeing intermittent errors like this for a few weeks now.
I emailed support@travis-ci.com :
```
Hi,
I'm a Tor Project developer who monitors our Travis CI.
We're seeing about 1% of builds error with one of the following errors:
1. Initial VM startup hangs:
https://travis-ci.org/torproject/tor/jobs/421734517
https://travis-ci.org/torproject/tor/jobs/420986864
The VM startup appears to hang even if sudo is not required.
We have an open patch to reduce the number of jobs per build.
2. Connecting to rust-lang.org fails:
https://travis-ci.org/torproject/tor/jobs/421823841
The network seems to fail mainly on sudo required builds.
We have an open patch to reduce our dependency on rust-lang.org.
Is there anything you can do on your end?
```Tor: 0.3.5.x-finalteorteorhttps://gitlab.torproject.org/tpo/core/tor/-/issues/27373add UTF-8 validation code2020-06-27T13:52:23ZTracadd UTF-8 validation code
**Trac**:
**Username**: cyberpunks
**Trac**:
**Username**: cyberpunksTor: 0.3.5.x-finalhttps://gitlab.torproject.org/tpo/core/tor/-/issues/27383Resolve memory leaks in NSS unit tests2020-06-27T13:52:22ZNick MathewsonResolve memory leaks in NSS unit testsThese leaks seem to be caused by the way that the unit tests fork and reinitialize NSS: they don't appear to affect Tor itself. That said, we'll need to get rid of them, to make sure that we're able to find real memory leaks.
One possi...These leaks seem to be caused by the way that the unit tests fork and reinitialize NSS: they don't appear to affect Tor itself. That said, we'll need to get rid of them, to make sure that we're able to find real memory leaks.
One possibility here is to refactor our test harness so that NSS initialization happens only in subprocesses, and so that forking *always* happens. I'm not sure I like that, but most other things I have tried seem to fail.
Tor itself doesn't have these leaks.Tor: 0.3.5.x-finalhttps://gitlab.torproject.org/tpo/core/tor/-/issues/27387Fix issues found during NSS branch reviews2020-06-27T13:52:22ZNick MathewsonFix issues found during NSS branch reviewsThis is a ticket for fixing stuff found during NSS/TLS reviews etc.This is a ticket for fixing stuff found during NSS/TLS reviews etc.Tor: 0.3.5.x-finalNick MathewsonNick Mathewsonhttps://gitlab.torproject.org/tpo/core/tor/-/issues/27389Appveyor Windows 64-bit builds fail because the compiler is broken2020-06-27T13:52:21ZteorAppveyor Windows 64-bit builds fail because the compiler is brokenSince about 6 hours ago, all Appveyor 64-bit Windows builds fail the first C file they build with:
```
bash.exe : In file included from ../src/core/or/or.h:16,
At line:2 char:5
+ & $commandPath $args 2>&1
+ ~~~~~~~~~~~~~~~~~~~~~...Since about 6 hours ago, all Appveyor 64-bit Windows builds fail the first C file they build with:
```
bash.exe : In file included from ../src/core/or/or.h:16,
At line:2 char:5
+ & $commandPath $args 2>&1
+ ~~~~~~~~~~~~~~~~~~~~~~~~~
+ CategoryInfo : NotSpecified: (In file include...ore/or/or.h:16,:String) [], RemoteException
+ FullyQualifiedErrorId : NativeCommandError
from ../src/app/main/ntmain.c:22:
../src/lib/cc/torint.h:52:2: error: #error "Seems that your platform doesn't use 2's complement arithmetic. Argh."
#error "Seems that your platform doesn't use 2's complement arithmetic. Argh."
^~~~~
In file included from ../src/core/or/or.h:26,
from ../src/app/main/ntmain.c:22:
../src/lib/cc/compat_compiler.h:28:2: error: #error "It seems your platform does not represent NULL as zero. We can't cope."
#error "It seems your platform does not represent NULL as zero. We can't cope."
^~~~~
../src/lib/cc/compat_compiler.h:32:2: error: #error "It seems your platform does not represent 0.0 as zeros. We can't cope."
#error "It seems your platform does not represent 0.0 as zeros. We can't cope."
^~~~~
In file included from ../src/core/or/or.h:16,
from ../src/feature/dirauth/dircollate.h:16,
from ../src/feature/dirauth/dircollate.c:25:
../src/lib/cc/torint.h:52:2: error: #error "Seems that your platform doesn't use 2's complement arithmetic. Argh."
#error "Seems that your platform doesn't use 2's complement arithmetic. Argh."
^~~~~
In file included from ../src/core/or/or.h:26,
from ../src/feature/dirauth/dircollate.h:16,
from ../src/feature/dirauth/dircollate.c:25:
../src/lib/cc/compat_compiler.h:28:2: error: #error "It seems your platform does not represent NULL as zero. We can't cope."
#error "It seems your platform does not represent NULL as zero. We can't cope."
^~~~~
../src/lib/cc/compat_compiler.h:32:2: error: #error "It seems your platform does not represent 0.0 as zeros. We can't cope."
#error "It seems your platform does not represent 0.0 as zeros. We can't cope."
^~~~~
```
https://ci.appveyor.com/project/teor2345/tor/build/1.0.113/job/ujbvwntcu1pdk2m6#L762
CC'ing mikeperry, because he's on CI rotation this week.
Which is weird, because configure seems to succeed.Tor: 0.3.5.x-finalteorteorhttps://gitlab.torproject.org/tpo/core/tor/-/issues/27418Don't pass --flags as the first argument to echo in travis.yaml2020-06-27T13:52:20ZteorDon't pass --flags as the first argument to echo in travis.yamlFrom https://trac.torproject.org/projects/tor/ticket/27088?replyto=4#comment:4From https://trac.torproject.org/projects/tor/ticket/27088?replyto=4#comment:4Tor: 0.3.5.x-finalteorteorhttps://gitlab.torproject.org/tpo/core/tor/-/issues/27428require ContactInfo line to be UTF-82020-06-27T13:52:20ZTracrequire ContactInfo line to be UTF-8
**Trac**:
**Username**: cyberpunks
**Trac**:
**Username**: cyberpunksTor: 0.3.5.x-finalhttps://gitlab.torproject.org/tpo/core/tor/-/issues/27449Appveyor: always log the compiler version2020-06-27T13:52:19ZteorAppveyor: always log the compiler versionDiagnostic for legacy/trac#27389.Diagnostic for legacy/trac#27389.Tor: 0.3.5.x-finalteorteorhttps://gitlab.torproject.org/tpo/core/tor/-/issues/27451Refactor socket closing in tor_tls_free() so it is not broken with NSS2020-06-27T13:52:19ZNick MathewsonRefactor socket closing in tor_tls_free() so it is not broken with NSStor_tls_free() closes the socket in openssl, but not in nss. This is asking for trouble.tor_tls_free() closes the socket in openssl, but not in nss. This is asking for trouble.Tor: 0.3.5.x-finalNick MathewsonNick Mathewsonhttps://gitlab.torproject.org/tpo/core/tor/-/issues/27453Travis: don't exit when showing the logs fails2020-06-27T13:52:19ZteorTravis: don't exit when showing the logs failsTor: 0.3.5.x-finalteorteorhttps://gitlab.torproject.org/tpo/core/tor/-/issues/27464Appveyor: stop reinstalling packages that haven't been updated2020-06-27T13:52:18ZteorAppveyor: stop reinstalling packages that haven't been updatedIf we give pacman the --needed argument, it will stop reinstalling identical packages.If we give pacman the --needed argument, it will stop reinstalling identical packages.Tor: 0.3.5.x-finalteorteorhttps://gitlab.torproject.org/tpo/core/tor/-/issues/27467Remove unused GetAdaptersAddresses_fn_t2020-06-27T13:52:18ZteorRemove unused GetAdaptersAddresses_fn_tWe removed the code that uses this type in 0.3.5, but we forgot to remove the type itself.We removed the code that uses this type in 0.3.5, but we forgot to remove the type itself.Tor: 0.3.5.x-finalteorteorhttps://gitlab.torproject.org/tpo/core/tor/-/issues/27481Bug: src/core/mainloop/connection.c:5109: assert_connection_ok: Assertion or_...2020-06-27T13:52:17ZDavid Gouletdgoulet@torproject.orgBug: src/core/mainloop/connection.c:5109: assert_connection_ok: Assertion or_conn->tls failedLatest git master 06c14f920900f99935e0cf6072aeb50231464eba asserts reliably everytime it tries to boostrap. Triggered on one of my relay (no weird or special configuration). See info.log attached:
```
Sep 05 20:02:59.636 [err] tor_asser...Latest git master 06c14f920900f99935e0cf6072aeb50231464eba asserts reliably everytime it tries to boostrap. Triggered on one of my relay (no weird or special configuration). See info.log attached:
```
Sep 05 20:02:59.636 [err] tor_assertion_failed_(): Bug: src/core/mainloop/connection.c:5109: assert_connection_ok: Assertion or_conn->tls failed; aborting. (on Tor 0.3.5.0-alpha-dev 06c14f920900f999)
Sep 05 20:02:59.636 [err] Bug: Assertion or_conn->tls failed in assert_connection_ok at src/core/mainloop/connection.c:5109. Stack trace: (on Tor 0.3.5.0-alpha-dev 06c14f920900f999)
Sep 05 20:02:59.636 [err] Bug: ./git/tor/src/app/tor(log_backtrace_impl+0x47) [0x5650452200b7] (on Tor 0.3.5.0-alpha-dev 06c14f920900f999)
Sep 05 20:02:59.636 [err] Bug: ./git/tor/src/app/tor(tor_assertion_failed_+0x94) [0x56504521b824] (on Tor 0.3.5.0-alpha-dev 06c14f920900f999)
Sep 05 20:02:59.636 [err] Bug: ./git/tor/src/app/tor(assert_connection_ok+0x575) [0x5650451aaed5] (on Tor 0.3.5.0-alpha-dev 06c14f920900f999)
Sep 05 20:02:59.636 [err] Bug: ./git/tor/src/app/tor(connection_mark_for_close_internal_+0x27) [0x5650451ab4e7] (on Tor 0.3.5.0-alpha-dev 06c14f920900f999)
Sep 05 20:02:59.636 [err] Bug: ./git/tor/src/app/tor(connection_handle_read+0x517) [0x5650451afa07] (on Tor 0.3.5.0-alpha-dev 06c14f920900f999)
Sep 05 20:02:59.636 [err] Bug: ./git/tor/src/app/tor(+0x5745e) [0x56504508b45e] (on Tor 0.3.5.0-alpha-dev 06c14f920900f999)
Sep 05 20:02:59.637 [err] Bug: /usr/lib/x86_64-linux-gnu/libevent-2.0.so.5(event_base_loop+0x819) [0x7fc50440e4c9] (on Tor 0.3.5.0-alpha-dev 06c14f920900f999)
Sep 05 20:02:59.637 [err] Bug: ./git/tor/src/app/tor(do_main_loop+0x1fa) [0x56504508d6fa] (on Tor 0.3.5.0-alpha-dev 06c14f920900f999)
Sep 05 20:02:59.637 [err] Bug: ./git/tor/src/app/tor(tor_run_main+0x11d5) [0x56504508fdc5] (on Tor 0.3.5.0-alpha-dev 06c14f920900f999)
Sep 05 20:02:59.637 [err] Bug: ./git/tor/src/app/tor(tor_main+0x3a) [0x56504508804a] (on Tor 0.3.5.0-alpha-dev 06c14f920900f999)
Sep 05 20:02:59.637 [err] Bug: ./git/tor/src/app/tor(main+0x19) [0x565045087bc9] (on Tor 0.3.5.0-alpha-dev 06c14f920900f999)
Sep 05 20:02:59.637 [err] Bug: /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf0) [0x7fc503326830] (on Tor 0.3.5.0-alpha-dev 06c14f920900f999)
Sep 05 20:02:59.637 [err] Bug: ./git/tor/src/app/tor(_start+0x29) [0x565045087c19] (on Tor 0.3.5.0-alpha-dev 06c14f920900f999)
```Tor: 0.3.5.x-finalhttps://gitlab.torproject.org/tpo/core/tor/-/issues/27500Tor crashes upon ORPort disconnection2020-06-27T13:52:16ZDamian JohnsonTor crashes upon ORPort disconnectionHi Nick, as discussed this morning tor had a regression between commits fd994f5-b8a2bdb. Tor crashes when Stem attempts to connect with its ORPort then disconnect. Here's its stacktrace...
```
Sep 05 20:36:47.000 [err] tor_assertion_fai...Hi Nick, as discussed this morning tor had a regression between commits fd994f5-b8a2bdb. Tor crashes when Stem attempts to connect with its ORPort then disconnect. Here's its stacktrace...
```
Sep 05 20:36:47.000 [err] tor_assertion_failed_(): Bug: src/core/mainloop/connection.c:5109: assert_connection_ok: Assertion or_conn->tls failed; aborting. (on Tor 0.3.5.0-alpha-dev b8a2bdbdc8c46776)
Sep 05 20:36:47.000 [err] Bug: Assertion or_conn->tls failed in assert_connection_ok at src/core/mainloop/connection.c:5109. Stack trace: (on Tor 0.3.5.0-alpha-dev b8a2bdbdc8c46776)
Sep 05 20:36:47.000 [err] Bug: tor(log_backtrace_impl+0x47) [0x55fcc4c95447] (on Tor 0.3.5.0-alpha-dev b8a2bdbdc8c46776)
Sep 05 20:36:47.000 [err] Bug: tor(tor_assertion_failed_+0x94) [0x55fcc4c90bb4] (on Tor 0.3.5.0-alpha-dev b8a2bdbdc8c46776)
Sep 05 20:36:47.000 [err] Bug: tor(assert_connection_ok+0x575) [0x55fcc4c240a5] (on Tor 0.3.5.0-alpha-dev b8a2bdbdc8c46776)
Sep 05 20:36:47.000 [err] Bug: tor(connection_mark_for_close_internal_+0x27) [0x55fcc4c246b7] (on Tor 0.3.5.0-alpha-dev b8a2bdbdc8c46776)
Sep 05 20:36:47.000 [err] Bug: tor(connection_handle_read+0x517) [0x55fcc4c28bb7] (on Tor 0.3.5.0-alpha-dev b8a2bdbdc8c46776)
Sep 05 20:36:47.000 [err] Bug: tor(+0x5470e) [0x55fcc4b0470e] (on Tor 0.3.5.0-alpha-dev b8a2bdbdc8c46776)
Sep 05 20:36:47.000 [err] Bug: /usr/lib/x86_64-linux-gnu/libevent-2.0.so.5(event_base_loop+0x819) [0x7fb789e174c9] (on Tor 0.3.5.0-alpha-dev b8a2bdbdc8c46776)
Sep 05 20:36:47.000 [err] Bug: tor(do_main_loop+0x1fa) [0x55fcc4b069aa] (on Tor 0.3.5.0-alpha-dev b8a2bdbdc8c46776)
Sep 05 20:36:47.000 [err] Bug: tor(tor_run_main+0x11d5) [0x55fcc4b09065] (on Tor 0.3.5.0-alpha-dev b8a2bdbdc8c46776)
Sep 05 20:36:47.000 [err] Bug: tor(tor_main+0x3a) [0x55fcc4b012fa] (on Tor 0.3.5.0-alpha-dev b8a2bdbdc8c46776)
Sep 05 20:36:47.000 [err] Bug: tor(main+0x19) [0x55fcc4b00e79] (on Tor 0.3.5.0-alpha-dev b8a2bdbdc8c46776)
Sep 05 20:36:47.000 [err] Bug: /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf0) [0x7fb789196830] (on Tor 0.3.5.0-alpha-dev b8a2bdbdc8c46776)
Sep 05 20:36:47.000 [err] Bug: tor(_start+0x29) [0x55fcc4b00ec9] (on Tor 0.3.5.0-alpha-dev b8a2bdbdc8c46776)
Aborted (core dumped)
```
Unfortunately since this is with the ORPort rather than the ControlPort I can't provide a simple telnet demo. If you need repro steps just let me know and I can come up with a demo.Tor: 0.3.5.x-finalNick MathewsonNick Mathewsonhttps://gitlab.torproject.org/tpo/core/tor/-/issues/27521Comment: typo in get_interface_addresses_win32() function comment2020-06-27T13:52:16ZteorComment: typo in get_interface_addresses_win32() function commentTor: 0.3.5.x-finalteorteorhttps://gitlab.torproject.org/tpo/core/tor/-/issues/27532Bug: tor_tls_context_new: Assertion dh failed2020-06-27T13:52:16ZteorBug: tor_tls_context_new: Assertion dh failedI get an assertion failure on macOS 10.13:
```
$ gcc --version
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 9.1.0 (clang-902.0.39.2)
Target: x86...I get an assertion failure on macOS 10.13:
```
$ gcc --version
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 9.1.0 (clang-902.0.39.2)
Target: x86_64-apple-darwin17.7.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
$ brew list --versions | grep openssl
openssl 1.0.2o_2
```
(Yes, gcc is an alias for clang on macOS by default.)
Our macOS CI passes with:
```
$ gcc --version
...
Target: x86_64-apple-darwin17.4.0
...
$ if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then brew install openssl; fi
Warning: openssl 1.0.2p is already installed and up-to-date
To reinstall 1.0.2p, run `brew reinstall openssl`
```
https://travis-ci.org/teor2345/tor/jobs/425576549#L1132
Have we broken compatibility with 1.0.2o?
I've done a `make clean`, so it's probably not my machine.
Here is the tor log:
```
$ /Users/base/tor-master/build-c/src/app/tor --ignore-missing-torrc -f /Users/base/chutney/net/nodes/000a/torrc --list-fingerprint --orport 1 --datadirectory /Users/base/chutney/net/nodes/000a
Sep 06 07:32:14.174 [notice] Tor 0.3.5.0-alpha-dev (git-22e24031452d5785) running on Darwin with Libevent 2.1.8-stable, OpenSSL 1.0.2o, Zlib 1.2.11, Liblzma 5.2.4, and Libzstd 1.3.5.
...
Sep 06 07:32:14.176 [notice] Configuration file "/Users/base/chutney/net/nodes/000a/torrc" not present, using reasonable defaults.
...
Sep 06 07:27:13.545 [err] tor_assertion_failed_: Bug: ../src/lib/tls/tortls_openssl.c:632: tor_tls_context_new: Assertion dh failed; aborting. (on Tor 0.3.5.0-alpha-dev 22e24031452d5785)
Sep 06 07:27:13.547 [err] Bug: Assertion dh failed in tor_tls_context_new at ../src/lib/tls/tortls_openssl.c:632. Stack trace: (on Tor 0.3.5.0-alpha-dev 22e24031452d5785)
Sep 06 07:27:13.547 [err] Bug: 0 tor 0x000000010be5572c log_backtrace_impl + 76 (on Tor 0.3.5.0-alpha-dev 22e24031452d5785)
Sep 06 07:27:13.547 [err] Bug: 1 tor 0x000000010be45bd8 tor_assertion_failed_ + 392 (on Tor 0.3.5.0-alpha-dev 22e24031452d5785)
Sep 06 07:27:13.547 [err] Bug: 2 tor 0x000000010bd7454e tor_tls_context_new + 4190 (on Tor 0.3.5.0-alpha-dev 22e24031452d5785)
Sep 06 07:27:13.547 [err] Bug: 3 tor 0x000000010bd7050c tor_tls_context_init + 156 (on Tor 0.3.5.0-alpha-dev 22e24031452d5785)
Sep 06 07:27:13.547 [err] Bug: 4 tor 0x000000010bc8742f init_keys + 2191 (on Tor 0.3.5.0-alpha-dev 22e24031452d5785)
Sep 06 07:27:13.547 [err] Bug: 5 tor 0x000000010b8e6da6 tor_run_main + 1734 (on Tor 0.3.5.0-alpha-dev 22e24031452d5785)
Sep 06 07:27:13.547 [err] Bug: 6 tor 0x000000010ba48721 tor_main + 161 (on Tor 0.3.5.0-alpha-dev 22e24031452d5785)
Sep 06 07:27:13.547 [err] Bug: 7 tor 0x000000010b842bdb main + 27 (on Tor 0.3.5.0-alpha-dev 22e24031452d5785)
Sep 06 07:27:13.547 [err] Bug: 8 libdyld.dylib 0x00007fff54fbe015 start + 1 (on Tor 0.3.5.0-alpha-dev 22e24031452d5785)
Sep 06 07:27:13.547 [err] Bug: 9 ??? 0x0000000000000009 0x0 + 9 (on Tor 0.3.5.0-alpha-dev 22e24031452d5785)
Abort trap: 6
Exit 134
```Tor: 0.3.5.x-finalhttps://gitlab.torproject.org/tpo/core/tor/-/issues/27545hs-v3: Shuffle the client authorization ordering in the descriptor2020-06-27T13:52:16ZDavid Gouletdgoulet@torproject.orghs-v3: Shuffle the client authorization ordering in the descriptorIt would be desirable to shuffle the list of clients in a descriptor (if any) so no one can learn anything from the ordering.
haxxpop has already done code for this:
https://github.com/haxxpop/tor/commit/3ac776bd988
This can go post 03...It would be desirable to shuffle the list of clients in a descriptor (if any) so no one can learn anything from the ordering.
haxxpop has already done code for this:
https://github.com/haxxpop/tor/commit/3ac776bd988
This can go post 035 freeze.Tor: 0.3.5.x-finalhttps://gitlab.torproject.org/tpo/core/tor/-/issues/27547hs-v3: Client authorization feature needs a changes file and man page2020-06-27T13:52:16ZDavid Gouletdgoulet@torproject.orghs-v3: Client authorization feature needs a changes file and man pageTo remind ourselves that we can't release 035 without the changes file and man page entry for the v3 client authorization.To remind ourselves that we can't release 035 without the changes file and man page entry for the v3 client authorization.Tor: 0.3.5.x-final