Tor issueshttps://gitlab.torproject.org/tpo/core/tor/-/issues2020-06-27T13:51:52Zhttps://gitlab.torproject.org/tpo/core/tor/-/issues/281150.3.5.3 FTBFS on mips and s3902020-06-27T13:51:52Zweasel (Peter Palfrader)0.3.5.3 FTBFS on mips and s390Tor 0.3.5.3-alpha-1 has failed to build on s390x and mips for Debian experimental. Other mips* platforms have not yet been tried.
For now,
https://buildd.debian.org/status/fetch.php?pkg=tor&arch=s390x&ver=0.3.5.3-alpha-1&stamp=15398446...Tor 0.3.5.3-alpha-1 has failed to build on s390x and mips for Debian experimental. Other mips* platforms have not yet been tried.
For now,
https://buildd.debian.org/status/fetch.php?pkg=tor&arch=s390x&ver=0.3.5.3-alpha-1&stamp=1539844680&raw=0
and
https://buildd.debian.org/status/fetch.php?pkg=tor&arch=mips&ver=0.3.5.3-alpha-1&stamp=1539846878&raw=0
have the full build logs.
```
crypto/ope/vectors:
FAIL ../src/test/test_crypto_ope.c:141: assert(crypto_ope_encrypt(ope, val) OP_EQ res): 3968478454 vs 3971694514
[vectors FAILED]
```
is common to both (same numbers too).
Additionally, on mips this happened:
```
storagedir/empty: [forking] OK
storagedir/basic: [forking] Oct 18 07:14:22.551 [err] tor_assertion_failed_(): Bug: ../src/test/testing_rsakeys.c:540: init_pregenerated_keys: Assertion r == 0 failed; aborting. (on Tor 0.3.5.3-alpha )
Oct 18 07:14:22.553 [err] Bug: Assertion r == 0 failed in init_pregenerated_keys at ../src/test/testing_rsakeys.c:540. Stack trace: (on Tor 0.3.5.3-alpha )
Oct 18 07:14:22.553 [err] Bug: ./src/test/test(log_backtrace_impl+0x84) [0x55cb65f8] (on Tor 0.3.5.3-alpha )
Oct 18 07:14:22.554 [err] Bug: ./src/test/test(tor_assertion_failed_+0xc4) [0x55cb1188] (on Tor 0.3.5.3-alpha )
Oct 18 07:14:22.554 [err] Bug: ./src/test/test(init_pregenerated_keys+0x198) [0x55a9b130] (on Tor 0.3.5.3-alpha )
Oct 18 07:14:22.554 [err] Bug: ./src/test/test(testcase_run_one+0x2d8) [0x55a9b530] (on Tor 0.3.5.3-alpha )
Oct 18 07:14:22.554 [err] Bug: ./src/test/test(tinytest_main+0x188) [0x55a9be64] (on Tor 0.3.5.3-alpha )
Oct 18 07:14:22.555 [err] Bug: ./src/test/test(main+0x3ec) [0x556ec43c] (on Tor 0.3.5.3-alpha )
Oct 18 07:14:22.555 [err] Bug: /lib/mips-linux-gnu/libc.so.6(__libc_start_main+0x108) [0x76f48cf8] (on Tor 0.3.5.3-alpha )
Oct 18 07:14:22.555 [err] Bug: ./src/test/test(+0x5f5b4) [0x556ec5b4] (on Tor 0.3.5.3-alpha )
```Tor: 0.3.5.x-finalNick MathewsonNick Mathewsonhttps://gitlab.torproject.org/tpo/core/tor/-/issues/28123Missing description of ED25519-V3 private key format in rend-spec-v3.txt2020-06-27T13:51:52ZriastradhMissing description of ED25519-V3 private key format in rend-spec-v3.txtrend-spec-v3.txt does not specify the format of ED25519-V3 keys in enough detail to make an interoperable implementation. And in particular, the format is _different_ from typical Ed25519 implementations like ed25519/ref in SUPERCOP.
I...rend-spec-v3.txt does not specify the format of ED25519-V3 keys in enough detail to make an interoperable implementation. And in particular, the format is _different_ from typical Ed25519 implementations like ed25519/ref in SUPERCOP.
In contrast, the document does specify the format of RSA1024 (v2) keys in enough detail to make an interoperable implementation.Tor: 0.3.5.x-finalhttps://gitlab.torproject.org/tpo/core/tor/-/issues/28135Bad CERTS cells in mixed chutney network2020-06-27T13:51:51ZteorBad CERTS cells in mixed chutney networkYet another mixed network error - these race conditions really are exercising a whole lot of unusual code paths:
```
FAIL: mixed+hs-v2
Detail: chutney/tools/warnings.sh /Users/base/chutney/net/nodes.1537279328
Warning: Received a bad CER...Yet another mixed network error - these race conditions really are exercising a whole lot of unusual code paths:
```
FAIL: mixed+hs-v2
Detail: chutney/tools/warnings.sh /Users/base/chutney/net/nodes.1537279328
Warning: Received a bad CERTS cell from 127.0.0.1:5002: Problem setting or checking peer id Number: 1
Warning: Received a bad CERTS cell from 127.0.0.1:5003: Problem setting or checking peer id Number: 1
Warning: Tried connecting to router at 127.0.0.1:5002, but RSA identity key was not as expected: wanted F0F7644942E7570548AA9BB1763F643123CE40C5 + no ed25519 key but got 72658EEB1AB9F6326635849C1D33052FC0C0F551 + 95IoksCTUXVIyqHU+lPMR3ppCzj+AdT5Bpg6BTSKDzI. Number: 1
Warning: Tried connecting to router at 127.0.0.1:5003, but RSA identity key was not as expected: wanted 185EF19538055B8B6F591224A66F0516C204BE98 + no ed25519 key but got 945CD7D474D11CA2A6DBEF63715477BA17657E68 + RT2D7+9+F4bADlz7427uBoUrV3iKtSz31l7/xT/xTls. Number: 1
Warning: http status 400 ("Nonauthoritative directory does not accept posted server descriptors") response from dirserver '127.0.0.1:7002'. Please correct. Number: 3
Warning: http status 400 ("Nonauthoritative directory does not accept posted server descriptors") response from dirserver '127.0.0.1:7003'. Please correct. Number: 3
```Tor: 0.3.5.x-finalhttps://gitlab.torproject.org/tpo/core/tor/-/issues/28183tor-0.3.5.3_alpha unexpected stop bug: (Sandbox) Caught a bad syscall attempt...2020-06-27T13:51:50ZTractor-0.3.5.3_alpha unexpected stop bug: (Sandbox) Caught a bad syscall attempt (syscall shutdown)tor -f ./torrc
Oct 24 08:10:51.726 [notice] Tor 0.3.5.3-alpha running on Linux with Libevent 2.1.8-stable, OpenSSL 1.0.2p, Zlib 1.2.11, Liblzma 5.2.4, and Libzstd N/A.
Oct 24 08:10:51.726 [notice] This version is not a stable Tor releas...tor -f ./torrc
Oct 24 08:10:51.726 [notice] Tor 0.3.5.3-alpha running on Linux with Libevent 2.1.8-stable, OpenSSL 1.0.2p, Zlib 1.2.11, Liblzma 5.2.4, and Libzstd N/A.
Oct 24 08:10:51.726 [notice] This version is not a stable Tor release. Expect more bugs than usual.
Oct 24 08:10:51.726 [notice] Read configuration file "/home/n05/./torrc".
Oct 24 08:10:51.730 [notice] Opening Socks listener on 127.0.0.1:7012
Oct 24 08:10:51.730 [notice] Opened Socks listener on 127.0.0.1:7012
Oct 24 08:10:51.000 [notice] Parsing GEOIP IPv4 file /usr/share/tor/geoip.
Oct 24 08:10:51.000 [notice] Parsing GEOIP IPv6 file /usr/share/tor/geoip6.
Oct 24 08:10:51.000 [notice] Bootstrapped 0%: Starting
Oct 24 08:10:52.000 [notice] Starting with guard context "default"
Oct 24 08:10:52.000 [notice] Bootstrapped 10%: Finishing handshake with directory server
Oct 24 08:10:52.000 [notice] Bootstrapped 80%: Connecting to the Tor network
Oct 24 08:10:52.000 [notice] Bootstrapped 90%: Establishing a Tor circuit
Oct 24 08:10:53.000 [notice] Bootstrapped 100%: Done
============================================================ T= 1540371205
(Sandbox) Caught a bad syscall attempt (syscall shutdown)
tor(+0x7cb9e)[0x559d07c0cb9e]
/lib64/libc.so.6(shutdown+0x7)[0x7f7b36b6ab97]
/lib64/libc.so.6(shutdown+0x7)[0x7f7b36b6ab97]
/usr/lib64/libcrypto.so.1.0.0(+0xf885d)[0x7f7b3738785d]
/usr/lib64/libcrypto.so.1.0.0(BIO_free+0x8a)[0x7f7b3733237a]
/usr/lib64/libcrypto.so.1.0.0(BIO_free_all+0x24)[0x7f7b373920e4]
/usr/lib64/libssl.so.1.0.0(SSL_free+0x97)[0x7f7b37c7ac87]
tor(tor_tls_free_+0x3c)[0x559d07c3f93c]
tor(+0x1c631a)[0x559d07d5631a]
tor(+0x1c1e34)[0x559d07d51e34]
tor(+0x1c228e)[0x559d07d5228e]
/usr/lib64/libevent-2.1.so.6(+0x20b45)[0x7f7b374fbb45]
/usr/lib64/libevent-2.1.so.6(event_base_loop+0x507)[0x7f7b374fc8a7]
tor(do_main_loop+0x74)[0x559d07d4a994]
tor(tor_run_main+0x11a6)[0x559d07d5a9b6]
tor(tor_main+0x26)[0x559d07d5bdc6]
tor(main+0x9)[0x559d07be1be9]
/lib64/libc.so.6(__libc_start_main+0xe7)[0x7f7b36a86ae7]
tor(_start+0x2a)[0x559d07be1c2a]
torrc:
Log notice
#SEC
SandBox 1
SafeLogging 1
NoExec 1
ClientOnly 1
SafeSocks 1
TestSocks 1
#NET
#8min keep-alive
KeepAlivePeriod 600
SOCKSPort 7012
#PERF
TruncateLogFile 1
HardwareAccel 1
#AccelName rdrand
AvoidDiskWrites 1
emerge --info
Portage 2.3.51 (python 3.6.6-final-0, default/linux/amd64/17.0, gcc-8.2.0, glibc-2.27-r6, 4.19.0-gentoo_intel x86_64)
=================================================================
System uname: Linux-4.19.0-gentoo_intel-x86_64-Intel-R-_Core-TM-_i7-2860QM_CPU_@_2.50GHz-with-gentoo-2.6
KiB Mem: 16211896 total, 328624 free
KiB Swap: 15625212 total, 15625212 free
Timestamp of repository gentoo: Wed, 24 Oct 2018 00:45:01 +0000
sh bash 4.4_p23
ld GNU ld (Gentoo 2.31.1 p3) 2.31.1
distcc 3.2rc1 x86_64-pc-linux-gnu [disabled]
ccache version 3.5 [disabled]
app-shells/bash: 4.4_p23::gentoo
dev-java/java-config: 2.2.0-r4::gentoo
dev-lang/perl: 5.26.2::gentoo
dev-lang/python: 2.7.15::gentoo, 3.6.6::gentoo
dev-util/ccache: 3.5::gentoo
dev-util/cmake: 3.12.3::gentoo
dev-util/pkgconfig: 0.29.2::gentoo
sys-apps/baselayout: 2.6-r1::gentoo
sys-apps/openrc: 0.39::gentoo
sys-apps/sandbox: 2.13::gentoo
sys-devel/autoconf: 2.13::gentoo, 2.69-r4::gentoo
sys-devel/automake: 1.16.1-r1::gentoo
sys-devel/binutils: 2.31.1-r1::gentoo
sys-devel/gcc: 8.2.0-r3::gentoo
sys-devel/gcc-config: 2.0::gentoo
sys-devel/libtool: 2.4.6-r5::gentoo
sys-devel/make: 4.2.1-r4::gentoo
sys-kernel/linux-headers: 4.19::gentoo (virtual/os-headers)
sys-libs/glibc: 2.27-r6::gentoo
Repositories:
gentoo
location: /usr/portage
sync-type: webrsync
sync-uri: rsync://rsync.gentoo.org/gentoo-portage
priority: -1000
ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="* -@EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe -flto=8 -fuse-ld=gold -fomit-frame-pointer -ftree-vectorize -march=sandybridge -mtune=sandybridge -mmmx -msse -msse2 -msse3 -mssse3 -mcx16 -msahf -maes -mpclmul -mpopcnt -mavx -msse4.2 -msse4.1 -mfxsr -mxsave -mxsaveopt --param l1-cache-size=32 --param l1-cache-line-size=64 --param l2-cache-size=8192"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/lib64/libreoffice/program/sofficerc /usr/share/gnupg/qualified.txt /var/lib/i2pd/certificates"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-O2 -pipe -flto=8 -fuse-ld=gold -fomit-frame-pointer -ftree-vectorize -march=sandybridge -mtune=sandybridge -mmmx -msse -msse2 -msse3 -mssse3 -mcx16 -msahf -maes -mpclmul -mpopcnt -mavx -msse4.2 -msse4.1 -mfxsr -mxsave -mxsaveopt --param l1-cache-size=32 --param l1-cache-line-size=64 --param l2-cache-size=8192"
DISTDIR="/usr/portage/distfiles"
ENV_UNSET="DBUS_SESSION_BUS_ADDRESS DISPLAY PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs candy cgroup config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync multilib-strict news nodoc noinfo noman parallel-fetch parallel-install preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync webrsync-gpg xattr"
FFLAGS="-O2 -pipe"
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LINGUAS="en ru ua"
MAKEOPTS="-j8"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="#chromium #graphite #link X a aac acl acpi adjust alsa amd64 avx based bash-completion berkdb branding break, bzip2 cairo can check cli consolekit crypt custom-cflags custom-optimization cxx dbus dri dri3 ffmpeg fortran gallium gdbm gif glamor gnome-keyring graphite gstreamer gtk gtk3 iconv icu intermediate jemalloc jit jpeg jpeg2k jumbo-build jumbo_file_merge_limit libnotify libsamplerate libtirpc llvm lm_sensors lock loop lto lzma lzo make matroska mime mmx mmxext mng mp3 mp4 multilib ncurses networkmanager nls nptl ntp on opengl openmp optimization optimizations pam pclmul pcre png policykit polyhedral popcnt rdesktop readline representation seccomp session shenandoah sndfile socks5 sound speedup, sqlite sse sse2 sse3 sse4_1 sse4_2 ssl ssse3 startup-notification svg system-bzip2 system-ffmpeg system-harfbuzz system-icu system-jpeg system-libevent system-libvpx system-libwebp system-lua system-sqlite system-zlib tcpd theora threads thunar tiff time truetype udev udisks unicode upower usb uvm v4l vaapi vdpau vorbis vpx vulkan webp wifi wmf x264 xa xattr xcb xpm xscreensaver xvid xvmc zlib" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon plan sheets stage words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx mmx mmxext pclmul popcnt sse sse2 sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="evdev synaptics" KERNEL="linux" L10N="en ru ua" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-6 php7-1" POSTGRES_TARGETS="postgres9_5 postgres10" PYTHON_SINGLE_TARGET="python3_6" PYTHON_TARGETS="python2_7 python3_6" QEMU_SOFTMMU_TARGETS="arm" QEMU_USER_TARGETS="arm" RUBY_TARGETS="ruby25" USERLAND="GNU" VIDEO_CARDS="intel i965" XFCE_PLUGINS="brightness clock power trash" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset: CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
equery u tor
[ Legend : U - final flag setting for installation]
[ : I - package is installed with flag ]
[ Colors : set, unset ]
* Found these USE flags for net-vpn/tor-0.3.5.3_alpha:
U I
- - caps : Use Linux capabilities library to control privilege
- - libressl : Use dev-libs/libressl instead of dev-libs/openssl when applicable (see also the ssl useflag)
+ + lzma : Support for LZMA (de)compression algorithm
- - scrypt : Use app-crypt/libscrypt for the scrypt algorithm
+ + seccomp : Enable seccomp (secure computing mode) to perform system call filtering at runtime to increase security of programs
- - systemd : Enable use of systemd-specific libraries and features like socket activation or session tracking
- - test : Enable dependencies and/or preparations necessary to run tests (usually controlled by FEATURES=test but can be toggled independently)
- - tor-hardening : Compile tor with hardening on vanilla compilers/linkers
- - zstd : Use app-arch/zstd for compression
gentoo bug : bugs.gentoo.org/669510
**Trac**:
**Username**: n05Tor: 0.3.5.x-finalhttps://gitlab.torproject.org/tpo/core/tor/-/issues/28192Work out why 0.3.5 and later fail chutney (but 0.3.4 and earlier do not)2020-06-27T13:51:49ZteorWork out why 0.3.5 and later fail chutney (but 0.3.4 and earlier do not)In legacy/trac#27912, I created a chutney travis config.
0.2.9, 0.3.3, and 0.3.4 fail less than 1% of the time.
0.3.5 and 0.3.6 fail about 90% of the time.In legacy/trac#27912, I created a chutney travis config.
0.2.9, 0.3.3, and 0.3.4 fail less than 1% of the time.
0.3.5 and 0.3.6 fail about 90% of the time.Tor: 0.3.5.x-finalhttps://gitlab.torproject.org/tpo/core/tor/-/issues/28202Bad end-of-string check in get_next_token (CID various)2020-06-27T13:51:49ZNick MathewsonBad end-of-string check in get_next_token (CID various)There's a coverity warning about an overflow in test_parsecommmon. I think it is happening because of this code:
```
*s + 16 >= eol
```
That's the wrong way to test for end-of-string, since C says that *s+16 is undefined behavior if t...There's a coverity warning about an overflow in test_parsecommmon. I think it is happening because of this code:
```
*s + 16 >= eol
```
That's the wrong way to test for end-of-string, since C says that *s+16 is undefined behavior if the resulting pointer would be more than 1 off the end of the allocated byte array.Tor: 0.3.5.x-finalNick MathewsonNick Mathewsonhttps://gitlab.torproject.org/tpo/core/tor/-/issues/28245Tor nodes with OpenSSL 1.1.1 can't communicate with each other2020-06-27T13:51:47ZGeorge KadianakisTor nodes with OpenSSL 1.1.1 can't communicate with each otherWe seem to have trouble in networks where both clients and relays are running openssl-1.1.1 . In particular, a chutney network on `openssl-1.1.1 (11 sept 2018)` will have its clients fail to bootstrap because they cant communicate any by...We seem to have trouble in networks where both clients and relays are running openssl-1.1.1 . In particular, a chutney network on `openssl-1.1.1 (11 sept 2018)` will have its clients fail to bootstrap because they cant communicate any bytes after the SSL handshake is done.
The problem might be that 1.1.1 is the version that introduces TLS-1.3, so these nodes are trying to do TLS-1.3 with each other.
Thanks to teor, dgoulet, nickm for the debug help.Tor: 0.3.5.x-finalNick MathewsonNick Mathewsonhttps://gitlab.torproject.org/tpo/core/tor/-/issues/28286Missing header in freespace.c when building for Android2020-06-27T13:51:45ZTracMissing header in freespace.c when building for AndroidBuilding tor 0.3.5.3-alpha for Android fails with the following error:
```
src/lib/fs/freespace.c: In function 'tor_get_avail_disk_space':
src/lib/fs/freespace.c:59:3: error: 'errno' undeclared (first use in this function)
errno = ENO...Building tor 0.3.5.3-alpha for Android fails with the following error:
```
src/lib/fs/freespace.c: In function 'tor_get_avail_disk_space':
src/lib/fs/freespace.c:59:3: error: 'errno' undeclared (first use in this function)
errno = ENOSYS;
^
src/lib/fs/freespace.c:59:3: note: each undeclared identifier is reported only once for each function it appears in
src/lib/fs/freespace.c:59:11: error: 'ENOSYS' undeclared (first use in this function)
errno = ENOSYS;
^
Makefile:9088: recipe for target 'src/lib/fs/freespace.o' failed
```
On Android <errno.h> should be included in the header.
**Trac**:
**Username**: goapunkTor: 0.3.5.x-finalNick MathewsonNick Mathewsonhttps://gitlab.torproject.org/tpo/core/tor/-/issues/28303Include sys/time.h in timers.c and time_fmt.c to fix OpenBSD build2020-06-27T13:51:45ZTracInclude sys/time.h in timers.c and time_fmt.c to fix OpenBSD buildThe files `src/lib/encoding/time_fmt.c` and `src/lib/evloop/timers.c` both need to include `sys/time.h` for `struct timeval`. Otherwise compilation fails on OpenBSD with the following errors:
```
CC src/lib/encoding/time_fmt.o
...The files `src/lib/encoding/time_fmt.c` and `src/lib/evloop/timers.c` both need to include `sys/time.h` for `struct timeval`. Otherwise compilation fails on OpenBSD with the following errors:
```
CC src/lib/encoding/time_fmt.o
src/lib/encoding/time_fmt.c: In function 'format_iso_time_nospace_usec':
src/lib/encoding/time_fmt.c:318: error: dereferencing pointer to incomplete type
src/lib/encoding/time_fmt.c:319: error: dereferencing pointer to incomplete type
gmake[1]: *** [Makefile:9088: src/lib/encoding/time_fmt.o] Error 1
```
and
```
CC src/lib/evloop/timers.o
src/lib/evloop/timers.c: In function 'tv_to_timeout':
src/lib/evloop/timers.c:115: error: dereferencing pointer to incomplete type
src/lib/evloop/timers.c:116: error: dereferencing pointer to incomplete type
src/lib/evloop/timers.c: In function 'timeout_to_tv':
src/lib/evloop/timers.c:128: error: dereferencing pointer to incomplete type
src/lib/evloop/timers.c:129: error: dereferencing pointer to incomplete type
src/lib/evloop/timers.c: In function 'libevent_timer_reschedule':
src/lib/evloop/timers.c:156: error: storage size of 'd' isn't known
src/lib/evloop/timers.c:156: warning: unused variable 'd'
gmake[1]: *** [Makefile:9088: src/lib/evloop/timers.o] Error 1
```
This change does not appear to be necessary on FreeBSD or NetBSD.
**Trac**:
**Username**: kjakTor: 0.3.5.x-finalhttps://gitlab.torproject.org/tpo/core/tor/-/issues/28318Appveyor: build on Windows Server 2012 R2 and Windows Server 20162020-06-27T13:51:44ZteorAppveyor: build on Windows Server 2012 R2 and Windows Server 2016Appveyor provides build images with Windows Server 2012 R2 (the default) and Windows Server 2016. These images are called:
* Visual Studio 2015
* Visual Studio 2017
https://www.appveyor.com/docs/windows-images-software/#operating-system...Appveyor provides build images with Windows Server 2012 R2 (the default) and Windows Server 2016. These images are called:
* Visual Studio 2015
* Visual Studio 2017
https://www.appveyor.com/docs/windows-images-software/#operating-system
Our builds work on these images:
https://ci.appveyor.com/project/teor2345/tor/builds/20046114
So we should probably build on both of them.Tor: 0.3.5.x-finalteorteorhttps://gitlab.torproject.org/tpo/core/tor/-/issues/28399Build is broken on Appveyor CI2020-06-27T13:51:41Zrl1987Build is broken on Appveyor CIhttps://ci.appveyor.com/project/torproject/tor/builds/20213306
```
bash.exe : ../src/lib/tls/tortls_openssl.c: In function 'tor_tls_context_new':
At line:2 char:5
+ & $commandPath $args 2>&1
+ ~~~~~~~~~~~~~~~~~~~~~~~~~
+ Cat...https://ci.appveyor.com/project/torproject/tor/builds/20213306
```
bash.exe : ../src/lib/tls/tortls_openssl.c: In function 'tor_tls_context_new':
At line:2 char:5
+ & $commandPath $args 2>&1
+ ~~~~~~~~~~~~~~~~~~~~~~~~~
+ CategoryInfo : NotSpecified: (../src/lib/tls/...s_context_new'::String) [], RemoteException
+ FullyQualifiedErrorId : NativeCommandError
../src/lib/tls/tortls_openssl.c:545:35: error: implicit declaration of function 'TLS_method'; did you mean 'DTLS_method'? [-Werror=implicit-function-declaration]
if (!(result->ctx = SSL_CTX_new(TLS_method())))
^~~~~~~~~~
DTLS_method
../src/lib/tls/tortls_openssl.c:545:35: error: nested extern declaration of 'TLS_method' [-Werror=nested-externs]
../src/lib/tls/tortls_openssl.c:545:35: error: passing argument 1 of 'SSL_CTX_new' makes pointer from integer without a cast [-Werror=int-conversion]
In file included from ../src/lib/tls/tortls_openssl.c:48:0:
C:/OpenSSL-Win32/include/openssl/ssl.h:2131:10: note: expected 'const SSL_METHOD * {aka const struct ssl_method_st *}' but argument is of type 'int'
SSL_CTX *SSL_CTX_new(const SSL_METHOD *meth);
^~~~~~~~~~~
../src/lib/tls/tortls_openssl.c:554:3: error: implicit declaration of function 'SSL_CTX_set_security_level'; did you mean 'SSL_CTX_set_verify_depth'? [-Werror=implicit-function-declaration]
SSL_CTX_set_security_level(result->ctx, 1);
^~~~~~~~~~~~~~~~~~~~~~~~~~
SSL_CTX_set_verify_depth
../src/lib/tls/tortls_openssl.c:554:3: error: nested extern declaration of 'SSL_CTX_set_security_level' [-Werror=nested-externs]
../src/lib/tls/tortls_openssl.c: In function 'prune_v2_cipher_list':
../src/lib/tls/tortls_openssl.c:810:25: error: initialization makes pointer from integer without a cast [-Werror=int-conversion]
const SSL_METHOD *m = TLS_method();
^~~~~~~~~~
../src/lib/tls/tortls_openssl.c: In function 'tor_tls_client_is_using_v2_ciphers':
../src/lib/tls/tortls_openssl.c:919:13: error: implicit declaration of function 'SSL_get_client_ciphers'; did you mean 'SSL_get_current_cipher'? [-Werror=implicit-function-declaration]
ciphers = SSL_get_client_ciphers(ssl);
^~~~~~~~~~~~~~~~~~~~~~
SSL_get_current_cipher
../src/lib/tls/tortls_openssl.c:919:13: error: nested extern declaration of 'SSL_get_client_ciphers' [-Werror=nested-externs]
../src/lib/tls/tortls_openssl.c:919:11: error: assignment makes pointer from integer without a cast [-Werror=int-conversion]
ciphers = SSL_get_client_ciphers(ssl);
^
../src/lib/tls/tortls_openssl.c: In function 'tor_tls_get_tlssecrets':
../src/lib/tls/tortls_openssl.c:1623:36: error: implicit declaration of function 'SSL_get_server_random'; did you mean 'SSL_get_servername'? [-Werror=implicit-function-declaration]
const size_t server_random_len = SSL_get_server_random(ssl, NULL, 0);
^~~~~~~~~~~~~~~~~~~~~
SSL_get_servername
../src/lib/tls/tortls_openssl.c:1623:36: error: nested extern declaration of 'SSL_get_server_random' [-Werror=nested-externs]
../src/lib/tls/tortls_openssl.c:1624:36: error: implicit declaration of function 'SSL_get_client_random'; did you mean 'SSL_get_client_CA_list'? [-Werror=implicit-function-declaration]
const size_t client_random_len = SSL_get_client_random(ssl, NULL, 0);
^~~~~~~~~~~~~~~~~~~~~
SSL_get_client_CA_list
../src/lib/tls/tortls_openssl.c:1624:36: error: nested extern declaration of 'SSL_get_client_random' [-Werror=nested-externs]
../src/lib/tls/tortls_openssl.c:1625:33: error: implicit declaration of function 'SSL_SESSION_get_master_key'; did you mean 'SSL_SESSION_get_time'? [-Werror=implicit-function-declaration]
const size_t master_key_len = SSL_SESSION_get_master_key(session, NULL, 0);
^~~~~~~~~~~~~~~~~~~~~~~~~~
SSL_SESSION_get_time
../src/lib/tls/tortls_openssl.c:1625:33: error: nested extern declaration of 'SSL_SESSION_get_master_key' [-Werror=nested-externs]
```Tor: 0.3.5.x-finalhttps://gitlab.torproject.org/tpo/core/tor/-/issues/28410systemd restart loop when tor@default.service::Type=notify2020-06-27T13:51:41ZTracsystemd restart loop when tor@default.service::Type=notifyI'm experiencing a 300sec restart loop when Tor is run as a service. This is Debian stretch using systemd.
This is a system in which tor-0.3.4.8 was installed and running OK. Then I overrode the tor executable with a 0.3.5.4-alpha build...I'm experiencing a 300sec restart loop when Tor is run as a service. This is Debian stretch using systemd.
This is a system in which tor-0.3.4.8 was installed and running OK. Then I overrode the tor executable with a 0.3.5.4-alpha build (with configure `--prefix=`), and it started showing this problem.
I tried some workarounds found on the Net, such as changing the /var/run symlink from /run to ../run (which shouldn't need to be done), tweaking values of ReadWriteDirectories in `tor@default.service`, and changing TimeoutStartSec to 0. None of that worked.
What does work is setting Type=simple instead of notify, but then I came across ticket legacy/trac#11016 and really, notify should work. So if it doesn't, I wonder if this version of tor 0.3.5 alpha could have a fault? How can I look into that more closely to verify?
This is the log in syslog prior to restart:
```
systemd[1]: tor@default.service: Start operation timed out. Terminating.
systemd[1]: Failed to start Anonymizing overlay network for TCP.
systemd[1]: tor@default.service: Unit entered failed state.
systemd[1]: tor@default.service: Failed with result 'timeout'.
systemd[1]: tor@default.service: Service hold-off time over, scheduling restart.
systemd[1]: Stopped Anonymizing overlay network for TCP.
systemd[1]: Starting Anonymizing overlay network for TCP...
```
And here is my current `tor@default.service`:
```
[Unit]
Description=Anonymizing overlay network for TCP
After=network.target nss-lookup.target
PartOf=tor.service
ReloadPropagatedFrom=tor.service
[Service]
#Type=notify
Type=simple
NotifyAccess=all
PIDFile=/var/run/tor/tor.pid
PermissionsStartOnly=yes
ExecStartPre=/usr/bin/install -Z -m 02755 -o debian-tor -g debian-tor -d /var/run/tor
ExecStartPre=/usr/bin/tor --defaults-torrc /usr/share/tor/tor-service-defaults-torrc -f /etc/tor/torrc --RunAsDaemon 0 --verify-config
ExecStart=/usr/bin/tor --defaults-torrc /usr/share/tor/tor-service-defaults-torrc -f /etc/tor/torrc --RunAsDaemon 0
ExecReload=/bin/kill -HUP ${MAINPID}
KillSignal=SIGINT
TimeoutStartSec=300
TimeoutStopSec=60
Restart=on-failure
LimitNOFILE=65536
# Hardening
AppArmorProfile=-system_tor
NoNewPrivileges=yes
PrivateTmp=yes
PrivateDevices=yes
ProtectHome=yes
ProtectSystem=full
ReadOnlyDirectories=/
ReadWriteDirectories=-/proc
ReadWriteDirectories=-/var/lib/tor
ReadWriteDirectories=-/var/log/tor
ReadWriteDirectories=-/var/run
CapabilityBoundingSet=CAP_SETUID CAP_SETGID CAP_NET_BIND_SERVICE CAP_DAC_READ_SEARCH
```
Advice?
**Trac**:
**Username**: jchevaliTor: 0.3.5.x-finalhttps://gitlab.torproject.org/tpo/core/tor/-/issues/28435adjust Doxyfile for source tree moves2020-06-27T13:51:39ZTaylor Yuadjust Doxyfile for source tree movesThe major source tree rearrangement means that Doxygen doesn't find any source files. We should set `RECURSIVE = YES` to fix this. (We could also explicitly enumerate all of the directories, but recursing is more future-proof.)The major source tree rearrangement means that Doxygen doesn't find any source files. We should set `RECURSIVE = YES` to fix this. (We could also explicitly enumerate all of the directories, but recursing is more future-proof.)Tor: 0.3.5.x-finalTaylor YuTaylor Yuhttps://gitlab.torproject.org/tpo/core/tor/-/issues/28440Various doc and comment fixes2020-06-27T13:51:39ZteorVarious doc and comment fixesI have a branch with various doc and comment fixes, I just need a ticket number.I have a branch with various doc and comment fixes, I just need a ticket number.Tor: 0.3.5.x-finalteorteorhttps://gitlab.torproject.org/tpo/core/tor/-/issues/28441Stop talking about Named in log messages2020-06-27T13:51:39ZteorStop talking about Named in log messagesThe Named flag is long dead, as is the code that implements it in tor clients.
I have a patch to fix a log message that still talks about Named.The Named flag is long dead, as is the code that implements it in tor clients.
I have a patch to fix a log message that still talks about Named.Tor: 0.3.5.x-finalteorteorhttps://gitlab.torproject.org/tpo/core/tor/-/issues/28485Link failure for tor-print-ed-signing-cert.exe on Windows2020-06-27T13:51:37ZAlexander Færøyahf@torproject.orgLink failure for tor-print-ed-signing-cert.exe on WindowsCurrently Tor fails to build on Windows because of:
```
CCLD src/tools/tor-print-ed-signing-cert.exe
/usr/bin/i686-w64-mingw32-ld: /home/user/src/github.com/ahf/tor-win32/prefix/lib/libcrypto.a(rand_win.o):rand_win.c:(.text+0x100d...Currently Tor fails to build on Windows because of:
```
CCLD src/tools/tor-print-ed-signing-cert.exe
/usr/bin/i686-w64-mingw32-ld: /home/user/src/github.com/ahf/tor-win32/prefix/lib/libcrypto.a(rand_win.o):rand_win.c:(.text+0x100d): undefined reference to `_imp__GetDeviceCaps@8'
/usr/bin/i686-w64-mingw32-ld: /home/user/src/github.com/ahf/tor-win32/prefix/lib/libcrypto.a(rand_win.o):rand_win.c:(.text+0x103b): undefined reference to `_imp__CreateCompatibleBitmap@12'
/usr/bin/i686-w64-mingw32-ld: /home/user/src/github.com/ahf/tor-win32/prefix/lib/libcrypto.a(rand_win.o):rand_win.c:(.text+0x105d): undefined reference to `_imp__GetObjectA@12'
/usr/bin/i686-w64-mingw32-ld: /home/user/src/github.com/ahf/tor-win32/prefix/lib/libcrypto.a(rand_win.o):rand_win.c:(.text+0x113d): undefined reference to `_imp__GetDIBits@28'
/usr/bin/i686-w64-mingw32-ld: /home/user/src/github.com/ahf/tor-win32/prefix/lib/libcrypto.a(rand_win.o):rand_win.c:(.text+0x11a1): undefined reference to `_imp__DeleteObject@4'
```
This is because we are missing to include the library from `@TOR_LIB_GDI@`. Patch coming up.Tor: 0.3.5.x-finalAlexander Færøyahf@torproject.orgAlexander Færøyahf@torproject.orghttps://gitlab.torproject.org/tpo/core/tor/-/issues/28506Assertion onion_pk failed in introduce1_set_encrypted_onion_key at hs_cell.c:2572020-06-27T13:51:37ZTracAssertion onion_pk failed in introduce1_set_encrypted_onion_key at hs_cell.c:257[ERR] tor_assertion_failed_(): Bug: hs_cell.c:257: introduce1_set_encrypted_onion_key: Assertion onion_pk failed; aborting. (on Tor 0.3.4.8 da95b91355248ad8)
Bug: Assertion onion_pk failed in introduce1_set_encrypted_onion_key at hs_cel...[ERR] tor_assertion_failed_(): Bug: hs_cell.c:257: introduce1_set_encrypted_onion_key: Assertion onion_pk failed; aborting. (on Tor 0.3.4.8 da95b91355248ad8)
Bug: Assertion onion_pk failed in introduce1_set_encrypted_onion_key at hs_cell.c:257. (Stack trace not available) (on Tor 0.3.4.8 da95b91355248ad8)
=====Logs from Tor
11/18/18, 22:10:13.527 [NOTICE] Bootstrapped 90%: Establishing a Tor circuit
11/18/18, 22:10:28.901 [NOTICE] Tor has successfully opened a circuit. Looks like client functionality is working.
11/18/18, 22:10:28.901 [NOTICE] Bootstrapped 100%: Done
11/18/18, 22:10:30.870 [NOTICE] New control connection opened from 127.0.0.1.
11/18/18, 22:10:31.366 [NOTICE] New control connection opened from 127.0.0.1.
11/18/18, 22:47:25.304 [ERR] tor_assertion_failed_(): Bug: hs_cell.c:257: introduce1_set_encrypted_onion_key: Assertion onion_pk failed; aborting. (on Tor 0.3.4.8 da95b91355248ad8)
11/18/18, 22:47:25.304 [ERR] Bug: Assertion onion_pk failed in introduce1_set_encrypted_onion_key at hs_cell.c:257. (Stack trace not available) (on Tor 0.3.4.8 da95b91355248ad8)
11/18/18, 22:49:38.634 [NOTICE] Bootstrapped 90%: Establishing a Tor circuit
11/18/18, 22:49:38.922 [NOTICE] Tor has successfully opened a circuit. Looks like client functionality is working.
11/18/18, 22:49:38.922 [NOTICE] Bootstrapped 100%: Done
**Trac**:
**Username**: BukavakTor: 0.3.5.x-finalhttps://gitlab.torproject.org/tpo/core/tor/-/issues/28524update control_free_all() for #271692020-06-27T13:51:36ZTaylor Yuupdate control_free_all() for #27169legacy/trac#27169 added some bootstrap tracking state that isn't reset by `control_free_all()`.legacy/trac#27169 added some bootstrap tracking state that isn't reset by `control_free_all()`.Tor: 0.3.5.x-finalTaylor YuTaylor Yuhttps://gitlab.torproject.org/tpo/core/tor/-/issues/28554Fix memory leaks and missing unmocks in test_entry_guard_outdated_dirserver_e...2020-06-27T13:51:36ZteorFix memory leaks and missing unmocks in test_entry_guard_outdated_dirserver_exclusiontest_entry_guard_outdated_dirserver_exclusion leaks memory, and is missing some unmockstest_entry_guard_outdated_dirserver_exclusion leaks memory, and is missing some unmocksTor: 0.3.5.x-finalteorteorhttps://gitlab.torproject.org/tpo/core/tor/-/issues/28568Stop running stem's unit tests in Tor's stem test2020-06-27T13:51:35ZteorStop running stem's unit tests in Tor's stem testAs noted by atagar in:
https://trac.torproject.org/projects/tor/ticket/28552#comment:4
We can use --integ rather than --all.As noted by atagar in:
https://trac.torproject.org/projects/tor/ticket/28552#comment:4
We can use --integ rather than --all.Tor: 0.3.5.x-finalteorteor