Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Tor Tor
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 823
    • Issues 823
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 29
    • Merge requests 29
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • Core
  • TorTor
  • Issues
  • #10505
Closed
Open
Created Dec 28, 2013 by Trac@tracbot

Broken ASLR in windows executable

ASLR (Address Space Layout Randomization) is a windows feature to complicate writing exploits. The provided tor executable in the windows expert bundle doesn't have full ASLR support.

A windows executable must have two features to fully support ASLR:

  1. In the PE header the following DllCharacteristics flag must be set IMAGE_DLLCHARACTERISTICS_DYNAMIC_BASE (0x0040). Tor has this value correctly set.

  2. PE relocation table. To successfully randomize the address space of the executable, the PE loader must know what addresses need to be adjusted. Therefore to randomize the image base (standard image base: 0x00400000) the PE file must have a relocation table. Tor is missing the relocation table. As a result, the image base is always 0x00400000 and this is bad.

The linker should provide a switch to include a relocation table.

PS: Greetings from the 30C3. Nice presentation yesterday.

Trac:
Username: Blueberry

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking