Clarification about new CIRC attributes

10:37 < atagar> nickm: it would be nice if the socks username/password had a description: https://gitweb.torproject.org/torspec.git/commit/?id=29759745fe1a3a216af7eb9e7ddfa20a10e60f47
10:37 < atagar> example for my unit tests would be nice too if you have one handy
10:49 < nickm> atagar: will try to add.  doing about a million other things.  plase keep bugging me if you can

Can do. Questions I have when I look at the new spec addition is...

• It's not clear to me what these credentials are for. Please describe what the attributes are.

• You say 'EscapedUsername' and 'EscapedPassword'. What kind of escaping is at play here? Below instead of 'Escaped*' you say "SocksUsername = SocksPassword = a quoted string" which makes me suspect it's just mislabelled.

• Please keep in mind that you're saying we can have a username without a password or a password without a username. Not sure if that's intended.

• Not spec related but if you have an example of this event handy (especially an example that demos the escaping if that's really a thing) I'd love to have it so I can add it to our unit tests.

Cheers! -Damian