Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Tor Tor
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 823
    • Issues 823
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 33
    • Merge requests 33
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • Core
  • TorTor
  • Issues
  • #14828
Closed
Open
Created Feb 09, 2015 by Yawning Angel@yawning

Multiple hidden services can share a pk_digest/service_id.

This may be a duplicate, it's past my bed time, so I don't have time to check.

The current rendservice code's duplication check doesn't enforce uniqueness of pk_digest and service_id. It probably should do so for both things, since I can't think of a reason why this would ever be well defined, or desirable behavior.

The trivial fix would be to add a pair of checks to rendservice.c:rend_service_load_keys(s), that log on LD_CONFIG, and return an error if a collision is detected.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking