Relay with HSDir flag but no DirPort fail to respond to BEGIN_DIR

Because of legacy/trac#14202 (moved), directory authorities now can assign HSDir flag to a relay without a DirPort. However, relays don't accept BEGIN_DIR cells if options->DirPort_set is set to 0 (see directory_permits_begindir_requests()).

This is very problematic right now because as I'm opening this bug, we currently have 4348 HSDir in the consensus but 1497 of them (34%) of them don't have a DirPort thus not working.

Unless all relay updates with the patch, this situation will continue thus we should maybe bring back the need for a DirPort to get the HSDir flag on the autority sides?

changed milestone to %Tor: 0.2.8.x-final in legacy/trac

added 2016-bug-retrospective in Legacy / Trac component::core tor/tor in Legacy / Trac milestone::Tor: 0.2.8.x-final in Legacy / Trac owner::dgoulet in Legacy / Trac points::medium in Legacy / Trac priority::very high in Legacy / Trac resolution::fixed in Legacy / Trac severity::normal in Legacy / Trac sponsor::R in Legacy / Trac status::closed in Legacy / Trac tor-hs in Legacy / Trac type::defect in Legacy / Trac labels

Hm. It looks as though legacy/trac#1693 (moved) may not be as fixed as we had thought.

If that's how it goes, we need to stop handing out the HSDir flag to anything that isn't actually going to answer BEGIN_DIR.

We should also make it so stuff does answer BEGIN_DIR if it's a relay, and start assigning HSDir to relays of the right version.

I broke down the two issues here that need a fix. See child tickets.

Trac:
Cc: N/A to s7r@sky-ip.org

Trac:
Username: Cthulhu
Cc: s7r@sky-ip.org to s7r@sky-ip.org, thomaswhite@riseup.net

Trac:

From Torperf logs, thanks to karsten for doing this graph, we can clearly see the issue being resolved. See the attached graph hsdesc-fetches-unknown.png.

Trac:
Status: new to assigned

Trac:
Milestone: Tor: 0.2.7.x-final to Tor: 0.2.8.x-final

Bulk-replace SponsorR keyword with SponsorR sponsor field in Tor component.

Trac:
Sponsor: N/A to SponsorR
Keywords: SponsorR deleted, N/A added

Trac:
Points: N/A to medium

I strongly suspect this is fixed in legacy/trac#12538 (moved), as it makes all relays directory caches, and has them respond to BEGIN_DIR. (Unless they're bandwidth-constrained.)

Can someone check it works for HSDir functionality?

Trac:
Severity: N/A to Normal
Status: assigned to needs_information

Replying to teor:

I strongly suspect this is fixed in legacy/trac#12538 (moved), as it makes all relays directory caches, and has them respond to BEGIN_DIR. (Unless they're bandwidth-constrained.)

Can someone check it works for HSDir functionality?

This should be fixed yes. We have couple of relays already that are advertising tunnelled-dir-server for which they have the HSDir flag. No relay right now has no DirPort and advertises this option so I've restarted my relay with master and disabled the DirPort. We'll see in 96 hours if this works out but I don't see how it shouldn't but we can be surprised! :)

Let's keep this ticket open until we really confirm that it's working in the network. Will close once I have a confirmation. Would be good also if someone can confirm as well.

Trac:
Priority: High to Very High

Trac:
Status: needs_information to accepted
Owner: N/A to dgoulet

Ok I was confused 12 days ago apparently. We won't be able to confirmed it works in the tor network until most dirauth upgrade to 028.

However, I can confirm that relay with 028 do advertise tunnelled-dir-server. I have a relay without a DirPort running on 028 so once majority of dirauth migrate, I'll closely watch this to make sure it's working as expected. Closing for now and we'll reopen in case it goes south.

Trac:
Status: accepted to closed
Resolution: N/A to fixed

Marking for bug retrospective based on Priority.

Trac:
Keywords: N/A deleted, 2016-bug-retrospective added

closed

mentioned in issue legacy/trac#15849 (moved)

mentioned in issue legacy/trac#15850 (moved)

moved from legacy/trac#15801 (moved)

added Bug label and removed 1 deleted label

added 1 deleted label and removed 1 deleted label