Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Tor Tor
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 313
    • Issues 313
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 34
    • Merge requests 34
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • Core
  • TorTor
  • Issues
  • #1806
Closed
Open
Created Aug 06, 2010 by Damian Johnson@atagar

Tor warns about config abbreviations every time a controller does an ambiguous getconf

The torrc and GETCONF accepts command abbreviations (for instance "ControlPo" instead of "ControlPort"). This was a mistake since it results in ambiguity for similarly named commands (for instance does "Socks" match "SocksPort" or "SocksBindAddress"?). Hence, use of this is discouraged and results in a warning.

Warnings are emitted in the 'expand_abbrev' function of 'or/config.c' (line 1353). The problem is that this is a getter function, called for a variety of purposes like GETCONF. This means that controllers may accidentally spam users with warnings by requesting an alias repeatedly.

In my opinion the proper handling of this is to either remember the warnings we've given (avoiding duplication), or even better to just provide warnings when reading in the torrc. Cheers! -Damian

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking