Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Tor Tor
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 328
    • Issues 328
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 31
    • Merge requests 31
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • Core
  • TorTor
  • Issues
  • #20458
Closed
Open
Issue created Oct 25, 2016 by Chelsea Komlo@chelsea

Integration tests should be run locally before committing code changes

Currently, it is easy to submit a patch for code changes without first running integration tests locally.

Two changes could help with this:

  1. Adding this information to documentation for contributors
  2. Adding a make task that runs all necessary tasks before contributing new code, which are:

make check-spaces make check make test-network-all

We should investigate how to handle:

  • Someone not having have chutney
  • Someone not having the necessary network connection for integration tests to succeed
  • If chutney tests fail because of flakiness (race conditions for example) rather than legitimate failures.
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking