Refactor dirserv_generate_networkstatus_vote_obj

dirserv_generate_networkstatus_vote_obj in dirserv.c can have pieces of its logic pulled into smaller functions.

This will help with readability/testability. Furthermore, future versions could use these functions where applicable (v4, v5, etc).

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information