Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Tor Tor
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 325
    • Issues 325
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 30
    • Merge requests 30
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • Core
  • TorTor
  • Issues
  • #22449
Closed
Open
Issue created May 30, 2017 by Nick Mathewson@nickm🌻Owner

Remove timestamp_dirty kludge from mark_circuit_unusable_for_new_conns()

In mark_circuit_unsusable_for_new_conns(), we set the unusable_for_new_conns flag... but we also carry around some old code that messes around with timestamp_dirty.

The root problem here is that the old code makes timestamp_dirty into a lie; "unusable" and "dirty" are not the same concept.

We should carefully audit timestamp_dirty and its users to make sure that it's safe to remove this old kludge, and then remove it or replace it with something more accurate.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking