Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Tor Tor
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 319
    • Issues 319
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 37
    • Merge requests 37
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • Core
  • TorTor
  • Issues
  • #2313
Closed
Open
Created Dec 24, 2010 by Sebastian Hahn@sebastian

pthreads on windows includes config.h

Attempting to compile Tor fails for me, because we use AM_CONFIG_HEADER(orconfig.h). This means that autofoo defines HAVE_CONFIG_H, and pthread.h attempts to include config.h when HAVE_CONFIG_H is defined.

There are a two solutions that I can see: We can just manually undefine HAVE_CONFIG_H (we don't use it anywhere), so that pthread won't include it. This doesn't seem to have negative side effects (orconfig.h is already included by our source anyways, so the definitions are available).

We could rename our config.[ch] files to something else and use config.h for the file generated during configure. This is a lot of work and doesn't mean a functional improvement that I can think of, so this is probably not what we want to do.

A third possible solution that I don't know how to make work is to stop configure from defining HAVE_CONFIG_H. Maybe that is easily possible and could be an alternative to the first idea.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking