Update dir-spec.txt with recent consensus param additions
We have a section in dir-spec.txt that tries to describe the possible consensus parameters, and their ranges, and their meanings.
We just added a bunch of new ones in legacy/trac#24902 (moved). And maybe we missed a few recently, like hs_service_max_rdv_failures.
We should patch dir-spec.txt to specify all of them.
- Show closed items
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Roger Dingledine changed milestone to %Tor: 0.3.3.x-final in legacy/trac
changed milestone to %Tor: 0.3.3.x-final in legacy/trac
- Roger Dingledine added component::core tor/tor in Legacy / Trac milestone::Tor: 0.3.3.x-final in Legacy / Trac owner::dgoulet in Legacy / Trac priority::medium in Legacy / Trac resolution::fixed in Legacy / Trac reviewer::ahf in Legacy / Trac severity::normal in Legacy / Trac status::closed in Legacy / Trac tor-dos in Legacy / Trac tor-spec in Legacy / Trac type::task in Legacy / Trac labels
added component::core tor/tor in Legacy / Trac milestone::Tor: 0.3.3.x-final in Legacy / Trac owner::dgoulet in Legacy / Trac priority::medium in Legacy / Trac resolution::fixed in Legacy / Trac reviewer::ahf in Legacy / Trac severity::normal in Legacy / Trac status::closed in Legacy / Trac tor-dos in Legacy / Trac tor-spec in Legacy / Trac type::task in Legacy / Trac labels
- Owner
Trac:
Cc: dgoulet to N/A
Type: defect to task
Owner: N/A to dgoulet
Status: new to accepted
Keywords: torspec deleted, tor-spec, tor-dos added - Owner
Spec branch:
ticket25095_01
Trac:
Status: accepted to needs_review - Owner
I think the patch looks good, I have two questions:
-
DoSCircuitCreationBurst
andDoSCircuitCreationRate
seems related. IsDoSCircuitCreationRate
also per Client IP address or not? Maybe that is worth addressing explicitly if it is. -
DoSCircuitCreationDefenseType
is a bit vaguely defined here -- what are the possible values this could have? From the other entries I think it's possible to deduct the data-type, but not for this one.
Other than that it looks good.
Trac:
Reviewer: N/A to ahf
Status: needs_review to needs_revision -
- Owner
Thanks for the review!
Fixup commit
032af0b700c4b915
pushed. I've also put the possible values for theDoSConnectionDefenseType
.Trac:
Status: needs_revision to needs_review - Owner
LGTM.
Trac:
Status: needs_review to merge_ready - Owner
merged to torspec!
Trac:
Status: merge_ready to closed
Resolution: N/A to fixed - Trac closed
closed
- Trac moved from legacy/trac#25095 (moved)
moved from legacy/trac#25095 (moved)
- Trac added Specifications + 1 deleted label and removed 1 deleted label
added Specifications + 1 deleted label and removed 1 deleted label