TROVE-2018-005

Tracking issue for TROVE-2018-005.

(The bug here is a memory-related denial-of-service attack, but only applies to directory authorities. They've all been informed.)

changed milestone to %Tor: 0.3.3.x-final in legacy/trac

added 033-included-20180320 in Legacy / Trac 033-must in Legacy / Trac 033-triage-20180320 in Legacy / Trac component::core tor/tor in Legacy / Trac milestone::Tor: 0.3.3.x-final in Legacy / Trac owner::isis in Legacy / Trac priority::medium in Legacy / Trac resolution::fixed in Legacy / Trac reviewer::nickm in Legacy / Trac security in Legacy / Trac severity::normal in Legacy / Trac status::closed in Legacy / Trac trove in Legacy / Trac type::defect in Legacy / Trac labels

Trac:
Milestone: N/A to Tor: 0.3.3.x-final

Trac:
Keywords: trove deleted, trove 033-must security added

Marking all tickets reached by current round of 033 triage.

Trac:
Keywords: trove 033-must security deleted, 033-must, 033-triage-20180320, trove, security added

Mark 033-must tickets as triaged-in for 0.3.3

Trac:
Keywords: N/A deleted, 033-included-20180320 added

Trac:
Owner: N/A to isis
Status: new to assigned

Please review! See the patchset in the TROVE-2018-005 thread on the security list.

Trac:
Status: assigned to needs_review

I agree with Teor's comments on that thread. Additionally, it needs a changes file. Then I think it should be good to go!

Trac:
Status: needs_review to needs_revision

On further thought, I'm no longer sure I agree about needing a new consensus method here. I'll send email later.

Consensus method 29 added, and a way to be backwards compatible with older consensus methods. I'll send the torspec patch to the security list as well.

Trac:
Status: needs_revision to needs_review

Trac:
Reviewer: N/A to nickm

I'm calling this merge-ready, but I have open questions and comments in my most recent email to network-team-security@.

For timing reasons discussed there, I believe the best time to apply this fix is once we are comfortable asking authorities to all run 0.3.3.

Trac:
Status: needs_review to merge_ready

Okay, we've finally got this ready. I've merged trove-2018-005_033 to maint-0.3.3, and trove-2018-005-034 to master. I have trove-2018-005_032 sitting ready for a backport to maint-0.3.2, if we decide to do that.

Trac:
Milestone: Tor: 0.3.3.x-final to Tor: 0.3.2.x-final
Description: Tracking issue for TROVE-2018-005.

to

Tracking issue for TROVE-2018-005.

(The bug here is a memory-related denial-of-service attack, but only applies to directory authorities. They've all been informed.)

I ran into a compilation error on windows, and fixed it with 240bb177140099690213dfc524a235abd2aa0eb8

We won't backport to 0.3.2, because all authorities except the bridge authority are running 0.3.3 now.

Trac:
Status: merge_ready to closed
Milestone: Tor: 0.3.2.x-final to Tor: 0.3.3.x-final
Resolution: N/A to fixed

closed

mentioned in issue legacy/trac#26435 (moved)

mentioned in issue legacy/trac#27206 (moved)

mentioned in issue legacy/trac#27739 (moved)