Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Tor Tor
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 831
    • Issues 831
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 31
    • Merge requests 31
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • Core
  • TorTor
  • Issues
  • #25988

Closed
Open
Created May 01, 2018 by David Goulet@dgoulet🔆Owner

module: Post-merge tasks for dirauth modularization

We've identified a series of things to do post-merge. They aren't that big and should be quite straightforward to achieve (no need to do them in that order):

  1. Splitting up dirvote_common.

nickm and I have discussed this and the decision is:

  • voting_schedule.{c|h} for the dirvote_common.c stuff
  • shared_random_client.{c|h} for shared_random_common.c.
  1. Adding more #ifdefs (nickm)

  2. Rename and move dirvote_get_voter_sig_by_alg()

We'll move this to networkstatus.c and namespace is networkstatus_

  1. Make dirvote_parse_sr_commits take a const ptr for tokens.

For this to happen, we need to refactor the code so find_opt_by_keyword() can take a const pointer.

  1. Add a changes file.
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking