Coverity issues for week 25
- CID 1437460: Fixed: Patch in commit e13eac62357d810996a53ff1b5c3532096935833 in the branch coverity-week-25-maint-0.3.1.
- CID 1437459: Not fixed: Odd issue:
if (BUG(x == NULL)) { ... x leaks here? ...; return y; }
- CID 1437458: Not fixed: Odd issue:
if (BUG(x == NULL)) { ... x leaks here? ...; return y; }
- CID 1437457: Not fixed: The service variable is free'd in hs_free_all() - is this to "deeply" hidden away from Coverity to spot? Calling
hs_service_free(service)
before the hs_free_all()
leads to a segfault.
- CID 1437456: Fixed: Should be fixed by the changes made for CID 1437460.
- CID 1437455: Not fixed: Same problem as in 1437457, but for
test_desc_reupload_logic()
.
- CID 1437454: Fixed: Patch in commit a2d6e0b16a254913275f4536e2796ac5a59d2fee in the branch coverity-week-25-maint-0.3.3.
- CID 1437453: Fixed: Patch in commit 1724f995 in the branch coverity-week-25-maint-0.2.9. Note that this have existed for longer, but 0.2.9 is our oldest maintained version of Tor.
- CID 1437452: Not fixed: Same problem as in 1437457, but for
test_service_event()
.
- CID 1437451: Fixed: Patch in commit 3525267b83fd0030929c407ff94f30dbd5b4bd9f in the branch coverity-week-25-maint-0.2.9.
- CID 1437450: Fixed: This should be fixed by the patch for CID 14377460 in commit e13eac62357d810996a53ff1b5c3532096935833, but needs to be ported to the maint-0.3.2 branch.
- CID 1437449: Fixed: Patch in commit ce5d055e in the branch coverity-week-25-maint-0.3.2.
- CID 1437448: Fixed: Patch in commit dc2384da in the branch coverity-week-25-maint-0.3.1.
- CID 1437447: Fixed: Patch in commit d86c45bf in the branch coverity-week-25-maint-0.3.1.
- CID 1437446: Not fixed. Same problem as in 1437457, but for
test_closing_intro_circs()
.
- CID 1437445: Fixed: Patch in commit 8e805bf0 in the branch coverity-week-25-maint-0.3.2.
- CID 1437444: Not fixed: Odd issue:
if (BUG(x == NULL)) { ... x leaks here? ...; return y; }
- CID 1437443: Not fixed. Same problem as in 1437457, but for
test_introduce2()
.
- CID 1437442: Not fixed: Same issue as with the
service
variables, but with a channel_listener_t.
- CID 1437441: Fixed: Patch in commit 9999f57789c994a499fbb9bb1bb8f37599abe297 in the branch coverity-week-25-maint-0.2.9.
- CID 1437440: Fixed: Patch in commit b35fc51a2e6bd72707c88fa5067ab90e837b0c03 in the branch coverity-week-25-maint-0.2.9.
- CID 1437439: Not fixed: Odd issue:
if (BUG(x == NULL)) { ... x leaks here? ...; return y; }
- CID 1437438: Fixed: Patch in commit d8230d8ba2f11bc060862f88efd49ae3178c3c5a in the branch coverity-week-25-maint-0.3.3.
- CID 1437437: Fixed: Patch in commit 3d80c086 in the branch coverity-week-25-maint-0.3.0.
- CID 1437436: Fixed: Patch in commit 3b6c93782d97839ced3f57d0cea3904c200da6ed in the branch coverity-week-25-maint-0.3.3.
- CID 1437435: Not fixed. Same problem as in 1437457, but for
test_closing_intro_circs()
.
- CID 1437434: Fixed: Patch in commit c997d49a in the branch coverity-week-25-maint-0.3.0.
- CID 1437433: Not fixed: Odd issue:
if (BUG(x == NULL)) { ... x leaks here? ...; return y; }
- CID 1437432: Not fixed. Same problem as in 1437457, but for
test_helper_functions()
.
- CID 1437431: Fixed: Patch in commit 8550016e in the branch coverity-week-25-maint-0.3.1.
- CID 1437430: Not fixed. Same problem as in 1437457, but for
test_rotate_descriptors()
.
- CID 1437429: Fixed: Should be fixed by the patch for CID 1437454.
- CID 1437428: Not fixed. Same problem as in 1437457, but for
test_build_update_descriptors()
.
- CID 1437427: Fixed: patch in commit a2e623f6 in the branch coverity-week-25-maint-0.3.2.
- CID 1437426: Not fixed. Same problem as in 1437457, but for
test_intro_established()
.