Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Tor Tor
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 311
    • Issues 311
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 35
    • Merge requests 35
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • Core
  • TorTor
  • Issues
  • #27185
Closed
Open
Created Aug 17, 2018 by Trac@tracbot

test/test.c and lround() prototype

First off, I have to express my frustration with this Trac-system. Clumsy as hell; the Markdown support is a joke. I'd wish you'd moved to Github or Gitlab.

Okay. To the issue. Compiling test/test.c using MSVC-2017 or clang-cl, spits out this warning:

test.c(42,10):  warning: 'lround' redeclared without 'dllimport' attribute: previous 'dllimport' ignored [-Winconsistent-dllimport]
long int lround(double x);

From MSVC:

test.c(42): warning C4273: 'lround': inconsistent dll linkage
f:\ProgramFiler-x86\WindowsKits\Include\10.0.16299.0\ucrt\corecrt_math.h(520): 
note: see previous definition of 'lround'

For Windows, it's already prototypes as (after C-preprocessing):

__declspec (dllimport)
  long long __cdecl llround (double _X);

Why not use tor_lround() instead? Same goes for fabs() I guess, but this function is not marked with dllimport!? Seems to be an intrinsic for clang-cl + MSVC.

Trac:
Username: gvanem

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking