Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
T
Tor
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,067
    • Issues 1,067
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 17
    • Merge Requests 17
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • The Tor Project
  • Core
  • Tor
  • Issues
  • #28760

Closed
Open
Opened Dec 06, 2018 by Trac@tracbot

Option/* format for ControlPort options needs to be homogeneous

According to [[https://gitweb.torproject.org/torspec.git/tree/control-spec.txt|control-spec.txt]]:

The OptionPrefix form indicates a number of options beginning with the prefix. So if config/* is listed, other options beginning with config/ will work, but config/* itself is not an option.

In Nyx and tor-prompt interpreters' /help, if the format Option/* is used to name a group of options (each of them is still described separately), it must be done for everything. However, e.g., we have many options inside accounting, but key accounting/* doesn't exist:

accounting/bytes          - Number of bytes read/written so far in the accounting interval.
accounting/bytes-left     - Number of bytes left to write/read so far in the accounting interval.
accounting/enabled        - Is accounting currently enabled?
accounting/hibernating    - Are we hibernating or awake?
accounting/interval-end   - Time when the accounting period ends.
accounting/interval-start - Time when the accounting period starts.
accounting/interval-wake  - Time to wake up in this accounting period.

Compare it with:

config/*                  - Current configuration values.
config/defaults           - List of default values for configuration options. See also config/names
config/names              - List of configuration options, types, and documentation.

If grouping syntax is used, it should be used everywhere (for all groups) or nowhere. Otherwise, it is confusing, because for many other options the syntax option/* implies that something not listed here (in list of options) should be substituted (e.g. fingerprint of a relay, IP address, etc.).

P.S. At first glance it looks like Nyx controller interpreter's bug, but atagar [[https://trac.torproject.org/projects/tor/ticket/28300#comment:5|says]] that it is taken literally from control-spec.txt. Initially it was reported in [comment]. Separate ticket was created because of [suggestion].

Trac:
Username: wagon

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: tpo/core/tor#28760