Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Tor Tor
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 823
    • Issues 823
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 33
    • Merge requests 33
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • Core
  • TorTor
  • Issues
  • #28981
Closed
Open
Created Jan 04, 2019 by Trac@tracbot

Use HW_PHYSMEM in get_total_system_memory_impl

An upcoming PR will change get_total_system_memory_impl to use HW_PHYSMEM instead of HW_USERMEM in the case where HW_PHYSMEM is defined but some other methods are not available for getting the total physical memory (one example: FreeBSD).

The code actually checks that HW_PHYSMEM is defined, and comments reference HW_PHYSMEM, but HW_USERMEM is simply used instead.

For OpenBSD, NetBSD and OSX a 64-bit variant of HW_PHYSMEM is used when available.

The same PR will also contain a commit to update/fix a couple of comments in this same file. It will fix a typo in a comment and update another comment which suggests that HW_PHYSMEM64 is something only on OpenBSD when NetBSD actually defines it as well.

Trac:
Username: kjak

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking