Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Tor Tor
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 319
    • Issues 319
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 37
    • Merge requests 37
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • Core
  • TorTor
  • Issues
  • #29669
Closed
Open
Created Mar 06, 2019 by David Goulet@dgoulet🔆Owner

hs: ADD_ONION with NEW:BEST is still pinned on v2

Even though the control spec says:

  (The "NEW:BEST" option obeys the HiddenServiceVersion torrc option default
  value. Since 0.3.5.1-alpha, it is 3. For Tor versions before 0.3.5.1-alpha,
  default HiddenServiceVersion is 2.)

... in control.c, the ADD_ONION command has this condition that basically pins the NEW:BEST to v2:

    if (!strcasecmp(key_type_rsa1024, key_blob) ||
        !strcasecmp(key_type_best, key_blob)) {
      /* "RSA1024", RSA 1024 bit, also currently "BEST" by default. */

Not good! NEW:BEST should obey the default version, not something hardcoded like so. This will need a spec update to mention the correct tor version.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking