Clear memory in smartlist_remove_keeporder.

The smartlist functions take great care to reset unused pointers inside the smartlist memory to NULL.

The function smartlist_remove_keeporder does not clear memory in such way when elements have been removed. Therefore call memset after the for-loop that removes elements. If no element is removed, it is effectively a no-op.

Trac:
Username: paldium

changed milestone to %Tor: 0.4.1.x-final in legacy/trac

added component::core tor/tor in Legacy / Trac defense-in-depth? in Legacy / Trac dgoulet-merge in Legacy / Trac milestone::Tor: 0.4.1.x-final in Legacy / Trac priority::medium in Legacy / Trac reporter::paldium in Legacy / Trac resolution::fixed in Legacy / Trac reviewer::nickm in Legacy / Trac severity::minor in Legacy / Trac status::closed in Legacy / Trac type::defect in Legacy / Trac version::tor unspecified in Legacy / Trac labels

Trac:
Username: paldium

0001-Add-test-to-verify-that-unused-pointers-are-NULL.patch

Trac:
Username: paldium

Trac:
Username: paldium

0002-Clear-memory-in-smartlist_remove_keeporder.patch

Trac:
Username: paldium

Trac:
Keywords: N/A deleted, 035-backport? 040-backport? defense-in-depth? added
Milestone: N/A to Tor: 0.4.1.x-final
Status: new to needs_review

Trac:
Reviewer: N/A to nickm

Looks good to me. I've put it in a branch called ticket30176, and added a changes file and a comment. For CI purposes I've made a PR at https://github.com/torproject/tor/pull/955 . If CI passes, let's merge.

CI has passed.

Trac:
Status: needs_review to merge_ready

Trac:
Keywords: 035-backport? 040-backport? defense-in-depth? deleted, 035-backport? 040-backport? defense-in-depth? dgoulet-merge added

Merged!

I don't think this qualifies as a backport contender considering 0.4.0 is in -rc.

Trac:
Status: merge_ready to closed
Resolution: N/A to fixed

Agreed wrt the backport; this is a defense-in-depth thing, not a bug.

Trac:
Keywords: 035-backport? 040-backport? defense-in-depth? dgoulet-merge deleted, defense-in-depth? dgoulet-merge added

closed

moved from legacy/trac#30176 (moved)

added Bug label and removed 1 deleted label

removed 1 deleted label