undefined (#40410)

Thanks for the ticket. Let's see if !398 (closed) solves it.

It seems the compilation is busted for 0.4.6.5 on Ubuntu 18.04 as well: https://lists.torproject.org/pipermail/tor-relays/2021-June/019713.html.

0.4.6.5 is busted on CentOS 7 too with similar errors.

src/feature/dirclient/dirclient.c: In function 'dir_client_decompress_response_body':                                        
src/feature/dirclient/dirclient.c:1877:5: error: initializer element is not constant                                         
     static ratelim_t warning_limit = RATELIM_INIT(LOG_INTERVAL);                                                            
     ^
src/feature/dirclient/dirclient.c:1877:5: error: (near initialization for 'warning_limit.rate')                              
  CC       src/feature/dircommon/core_libtor_app_testing_a-consdiff.o                                                        
  CC       src/feature/dircommon/core_libtor_app_testing_a-directory.o                                                       
make[1]: *** [src/feature/dirclient/core_libtor_app_testing_a-dirclient.o] Error 1                                           
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory `/home/fedora/rpmbuild/BUILD/tor-0.4.6.5'                                                         
make: *** [all] Error 2

This was merged.

So apparently, this is on 0.4.5.11 now. I got a report from someone using Slackware 14.2:

   CC       src/feature/dirclient/dirclient.o 
 In file included from ./src/core/or/or.h:50:0, 
                  from src/feature/dirclient/dirclient.c:13: 
 src/feature/dirclient/dirclient.c: In function 
 'dir_client_decompress_response_body': 
 ./src/lib/log/ratelim.h:55:27: error: initializer element is not constant 
  #define RATELIM_INIT(r) { (r), 0, 0, 0 } 
                            ^ 
 src/feature/dirclient/dirclient.c:1963:38: note: in expansion of macro 
 'RATELIM_INIT' 
      static ratelim_t warning_limit = RATELIM_INIT(LOG_INTERVAL); 
                                       ^ 
 ./src/lib/log/ratelim.h:55:27: note: (near initialization for 
 'warning_limit.rate') 
  #define RATELIM_INIT(r) { (r), 0, 0, 0 } 
                            ^ 
 src/feature/dirclient/dirclient.c:1963:38: note: in expansion of macro 
 'RATELIM_INIT' 
      static ratelim_t warning_limit = RATELIM_INIT(LOG_INTERVAL); 
                                       ^ 
 Makefile:12415: recipe for target 'src/feature/dirclient/dirclient.o' failed 
 make[1]: *** [src/feature/dirclient/dirclient.o] Error 1 
 make[1]: Leaving directory '/usr/local/lib/tor-0.4.5.11' 
 Makefile:7344: recipe for target 'all' failed 
 make: *** [all] Error 2

Was this a 046+ problem only in the first place?

Update: Operator is using gcc (GCC) 5.5.0

Activity