Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Tor Tor
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 345
    • Issues 345
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 35
    • Merge requests 35
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • Core
  • TorTor
  • Issues
  • #31338
Closed
Open
Issue created Aug 05, 2019 by teor@teor

Practracker --list-overbroad produces confusing output when there is an exception

connection_control_process_inbuf() is 115 lines long, but the exceptions file says it should be 113.

This line is spurious and should not appear in the output:

problem function-size /src/feature/control/control.c:connection_control_process_inbuf() 113 -> 0

Ideally, practracker should log a message that there are no over-broad exceptions, but there are violations.

Here is the full output:

$ scripts/maint/practracker/practracker.py --list-overbroad
problem function-size /src/feature/control/control.c:connection_control_process_inbuf() 115
FAILURE: practracker found 1 new problem(s) in the code: see warnings above.

Please fix the problems if you can, and update the exceptions file
(./scripts/maint/practracker/./exceptions.txt) if you can't.

See doc/HACKING/HelpfulTools.md for more information on using practracker.
You can disable this message by setting the TOR_DISABLE_PRACTRACKER environment
variable.

problem function-size /src/feature/control/control.c:connection_control_process_inbuf() 113 -> 0
Exit 1
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking