Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Tor Tor
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 318
    • Issues 318
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 36
    • Merge requests 36
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • Core
  • TorTor
  • Issues
  • #32798
Closed
Open
Created Dec 18, 2019 by teor@teor

Compile every header by itself as part of "make check"

In legacy/trac#32764 (moved), we need to make sure that some headers include their dependencies (or remove those dependencies), so that clang-format can re-order headers.

We should compile every header by itself, to check that it lists all its dependencies. Some headers contain conditional code, so we also need to compile with and without:

  • HAVE_MODULE_* (already in CI, as long as we use the defined from configure)
  • {INTERNAL,PRIVATE,EXPOSE} (not sure how to do this in CI, I guess we could script it using grep)
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking